From 0300dbdeb378fa5797a23ce8b3f72e2749c3ce50 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bla=C5=BE=20Hrastnik?= Date: Mon, 16 Aug 2021 14:08:21 +0900 Subject: [PATCH] Avoid cloning a request on send --- helix-dap/src/transport.rs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/helix-dap/src/transport.rs b/helix-dap/src/transport.rs index e17dc53d5..bca1351c7 100644 --- a/helix-dap/src/transport.rs +++ b/helix-dap/src/transport.rs @@ -127,11 +127,13 @@ impl Transport { async fn send_payload_to_server( &self, server_stdin: &mut Box, - req: Request, + mut req: Request, ) -> Result<()> { - let json = serde_json::to_string(&Payload::Request(req.clone()))?; - if let Some(back) = req.back_ch { - self.pending_requests.lock().await.insert(req.seq, back); + let back_ch = req.back_ch.take(); + let seq = req.seq; + let json = serde_json::to_string(&Payload::Request(req))?; + if let Some(back) = back_ch { + self.pending_requests.lock().await.insert(seq, back); } self.send_string_to_server(server_stdin, json).await }