Fix scrollbar length proportional to total menu items (#2860)

The scrollbar length used to increase with more entries in the menu,
which was counter-intuitive to how scrollbars worked in most
applications. Turns out there was a typo in the floor division
implementation :)
pull/2870/head
Gokul Soumya 2 years ago committed by GitHub
parent b365f2d614
commit 301065fe4d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -288,7 +288,7 @@ impl<T: Item + 'static> Component for Menu<T> {
let win_height = area.height as usize; let win_height = area.height as usize;
const fn div_ceil(a: usize, b: usize) -> usize { const fn div_ceil(a: usize, b: usize) -> usize {
(a + b - 1) / a (a + b - 1) / b
} }
let scroll_height = std::cmp::min(div_ceil(win_height.pow(2), len), win_height as usize); let scroll_height = std::cmp::min(div_ceil(win_height.pow(2), len), win_height as usize);

Loading…
Cancel
Save