From 50b191a7dff4a6c311437d3e5fcd1ce36b300643 Mon Sep 17 00:00:00 2001 From: Michael Davis Date: Sun, 16 Oct 2022 14:59:57 -0500 Subject: [PATCH] Log failures to load tree-sitter parsers as error (#4315) Info logs don't show up in the log file by default, but this line should: failures to load tree-sitter parser objects are useful errors. A parser might fail to load it is misconfigured (https://github.com/helix-editor/helix/pull/4303#discussion_r996448543) or if the file does not exist. --- helix-core/src/syntax.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/helix-core/src/syntax.rs b/helix-core/src/syntax.rs index 8c51d5ebb..61d382fde 100644 --- a/helix-core/src/syntax.rs +++ b/helix-core/src/syntax.rs @@ -368,7 +368,13 @@ impl LanguageConfiguration { None } else { let language = get_language(self.grammar.as_deref().unwrap_or(&self.language_id)) - .map_err(|e| log::info!("{}", e)) + .map_err(|err| { + log::error!( + "Failed to load tree-sitter parser for language {:?}: {}", + self.language_id, + err + ) + }) .ok()?; let config = HighlightConfiguration::new( language,