133 Commits (21d12e1487f98b5dea93eba7bdc53d303932f990)

Author	SHA1	Message	Date
farwyler	f92a25a856	Passing extra formatting options to LSPs (#2635) ... * allows passing extra formatting options to LSPs - adds optional field 'format' to [[language]] sections in 'languages.toml' - passes specified options the LSPs via FormattingOptions * cleaner conversion of formatting properties * move formatting options inside lsp::Client * cleans up formatting properties merge	2 years ago
Blaž Hrastnik	3d91c99c3e	fix: lsp: Sort edits by start range, Omnisharp sends them in reverse	2 years ago
Michael Davis	50dd11985c	prevent panic when handling an LSP response with no request (#2475) ... A language server may push a response which doesn't belong to any request. With this change, we discard the response rather than crashing. In the case of #2474, the language server sends an error message with a null request ID which should not ever exist in the `pending_requests` HashMap. closes #2474	3 years ago
Blaž Hrastnik	7ae6cad52e	Don't panic on LSP parsing errors ... This made sense initially when the implementation was still new (so we got user reports more frequently), but a parsing error now generally signifies a language server isn't properly implementing the spec.	3 years ago
EmmChriss	807cdc60bf	configurable lsp request timeout (#2405)	3 years ago
chunghha	3a398eec56	fix typos (#2304)	3 years ago
matt rice	db47761154	register publish_diagnostics client capability (#2241)	3 years ago
ttys3	19d042dde6	chore(lsp): check rename capabilities before send rename action (#2203)	3 years ago
Michael Davis	449d1dfdfb	prevent panic when receiving malformed LSP PublishDiagnostic (#2160) ... Instead of panicing we can discard the malformed diagnostic. This `.parse()` fails commonly when a non-conformant language server gives a diagnostic with a location that breaks the spec: { "character": 0, "line": -1 } can currently be returned by ElixirLS and the python LS. Other messages in this block are discarded but this one feels special enough to log.	3 years ago
Robin Jadoul	33b7483db5	Send active diagnostics to LSP when requesting code actions. (#2005) ... * Send active diagnostics to LSP when requesting code actions. This allows for e.g. clangd to properly send the quickfix code actions corresponding to those diagnostics as options. The LSP spec v3.16.0 introduced an opaque `data` member that would allow the server to persist arbitrary data between the diagnostic and the code actions request, but this is not supported yet by this commit. * Reuse existing range_to_lsp_range functionality	3 years ago
Andrey Tkachenko	dc8fef5dd3	Fixes #1991 LSP Auto-import (#2088)	3 years ago
Blaž Hrastnik	8adf0c1b3a	lsp: Implement support for workspace_folders (currently just one) ... Refs #1898	3 years ago
Blaž Hrastnik	84e799f0e4	fix: Some LSPs still want rootPath, so provide it ... Refs #1898	3 years ago
Triton171	f044059a2a	Implement LSP `workspace/configuration` and `workspace/didChangeConfiguration` (#1684) ... * Implement LSP `workspace/configuration` request * Implement LSP `workspace/didChangeConfiguration` notification. * Simplify retrieval of LSP configuration * Implement suggestions from PR discussion Co-authored-by: Triton171 <triton0171@gmail.com>	3 years ago
Blaž Hrastnik	9712bbb23b	Use which to resolve lsp/dap binaries ... This resolves the following issue: https://github.com/helix-editor/helix/discussions/962#discussioncomment-1580046	3 years ago
Blaž Hrastnik	f88c077f99	Replace tendril with smartstring ... Slightly smaller API surface, less dependencies.	3 years ago
Kirawi	ea095ca5fb	Optimize lsp_pos_to_pos (#1423) ... lines().count() is slow compared to len_lines()	3 years ago
Alexis Mousset	8a019b423f	Detect workspace root using language markers (#1370) ... * Detect workspace root using language markers * Avoid allocating root_markers * Update helix-core/src/lib.rs Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> * Update helix-core/src/lib.rs Co-authored-by: Kirawi <67773714+kirawi@users.noreply.github.com> Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Kirawi <67773714+kirawi@users.noreply.github.com>	3 years ago
Gabriel Berto	5d7b5db8ab	Resolve completion item (#1315) ... Co-authored-by: Gabriel Berto <gabriel.berto@pottencial.com.br>	3 years ago
Matouš Dzivjak	75a8b789d2	LSP code action commands (#1304) ... * feat(lsp): codeAction commands * Don't block on command call * Fix lifetime of command execution * Fix lint issues	3 years ago
Blaž Hrastnik	d31bef7fea	lsp: Don't panic if init fails ... We correctly filter out the language server inside Document to ignore it if the capabilities are missing, so this way it'll simply ignore the errored out LSP rather than panicking.	3 years ago
CossonLeo	29e6849413	Add LSP rename_symbol (space-r) (#1011) ... improve apply_workspace_edit	3 years ago
Ivan Tham	49f6c2623f	Bump lsp-types to 0.91.0 (#932)	3 years ago
Midnight Exigent	eedcea7e6b	Allow `language.config` (in languages.toml) to be passed in as a toml object (#807) ... * allow language.config (in languages.toml) to be passed in as a toml object * Change config field for languages from json string to toml object * remove indents on languages.toml config * fix: remove patch version from serde_json import in helix-core * Use same tree-sitter-zig as upstream/master	3 years ago
Kirawi	ef532e0c0d	log errors produced when trying to initialize the LSP (#746)	3 years ago
Blaž Hrastnik	bb47a9a0b8	fix: Fix regression where formatting would fail on null response	3 years ago
Blaž Hrastnik	be81f40df8	lsp: This doesn't need to be a mutable reference	3 years ago
Blaž Hrastnik	37606bad47	lsp: doc.language_server() is None until initialize completes	3 years ago
Blaž Hrastnik	46f3c69f06	lsp: Don't send notifications until initialize completes ... Then send open events for all documents with the LSP attached.	3 years ago
Blaž Hrastnik	2793ff3832	lsp: SyncKind::Full: we need to send the whole document on each change	3 years ago
Blaž Hrastnik	48fd4843fc	lsp: Outdated comment	3 years ago
Blaž Hrastnik	800d79b584	ls: Refactor textDocument/didSave in a similar vein	3 years ago
Blaž Hrastnik	184637c55a	lsp: refactor format so we stop cloning the language_server	3 years ago
Blaž Hrastnik	8744f367bd	wip	3 years ago
Blaž Hrastnik	5a558e0d8e	lsp: Delay requests & notifications until initialization is complete	3 years ago
Blaž Hrastnik	c3a58cdadd	lsp: Refactor capabilities as an async OnceCell ... First step in making LSP init asynchronous	3 years ago
Blaž Hrastnik	41f1e8e4fb	fix: lsp: Terminate transport on EOF ... If stdout/stderr is closed, read_line will return 0 indicating EOF.	3 years ago
Blaž Hrastnik	fe17b99ab3	fix: lsp: Don't consume \n\n as a single newline	3 years ago
Blaž Hrastnik	57ed5180e0	lsp: Improve line ending handling when generating TextEdit	3 years ago
Blaž Hrastnik	847d1fa496	fix: Work around crashes on LSPs that don't just emit JSON-RPC	3 years ago
Blaž Hrastnik	7eff905680	lsp: slightly refactor header parsing, add more logging	3 years ago
Timothy DeHerrera	ed8c3e6574	don't panic on defunct lsp process (#583)	3 years ago
Blaž Hrastnik	385a6b5a1a	lsp: Refactor duplex to avoid issues with select! + read_exact ... read_exact isn't cancellation safe. Fixes #504	3 years ago
Grzegorz Baranski	48e344a2a8	feat: code actions - document edits (#478) ... * wip: Code actions * fix(term): use current macro instead Context::context * feat(lsp): set code_action capabilities * feat(term): set SPC-a to code_action * feat(term): wip on applying code actions * deps: `cargo update` * feat(term): applying code actions edits * fix(term): cleanup of apply_edit * fix(term): applying edits as a whole thing instead one by one * refactor(term): move apply_edits below * fix(term): improve unimplemented messages for further investigation * fix(term): change code action command comment Co-authored-by: Ivan Tham <pickfire@riseup.net> * fix(term): add matching `}` * fix(term): cleanup, todo!() on workspace edit * fix(term): remove unrelated workspace_symbol_picker * fix(term): apply cargo-clippy suggestions * fix(term): replace todo!'s with editor.set_error Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Ivan Tham <pickfire@riseup.net>	3 years ago
Cor Peters	0aa43902ca	Added option to provide a custom config file to the lsp. (#460) ... * Added option to provide a custom config file to the lsp. * Simplified lsp loading routine with anyhow * Moved config to language.toml * Fixed test case * Cargo fmt * Revert now-useless changes * Renamed custom_config to config Co-authored-by: Cor <prive@corpeters.nl>	3 years ago
Joe Neeman	c9be480bf8	Make formatting happen asynchronously.	3 years ago
Blaž Hrastnik	cad14c6b46	Address nightly clippy warnings	3 years ago
Blaž Hrastnik	a70de6e980	Merge pull request #224 from helix-editor/line_ending_detection ... Line ending detection	3 years ago
wojciechkepka	cc357d5096	Add progress spinners to status line	3 years ago
Nathan Vegdahl	4efd6713c5	Work on moving code over to LineEnding instead of assuming '\n'. ... Also some general cleanup and some minor fixes along the way.	3 years ago