helix

Commit Graph

Author	SHA1	Message	Date
Blaž Hrastnik	63e54e30a7	Implement in-memory prompt history Implementation is similar to kakoune: we store the entries into a register.	3 years ago
Omnikar	112ae5cffe	Determine whether to use a margin of 0 or 1 when uncommenting (#476 ) * Implement `margin` calculation for uncommenting * Move `margin` calculation to `find_line_comment` * Fix comment bug with multiple selections on a line * Fix `find_line_comment` test for new return type * Generate a single vec of lines for comment toggle `toggle_line_comments` collects the lines covered by all selections into a `Vec`, skipping duplicates. `find_line_comment` now returns the lines to operate on, instead of returning the lines to skip. * Fix test for `find_line_comment` * Reserve length of `to_change` instead of `lines` The length of `lines` includes blank lines which will be skipped, and as such do not need space for a change reserved for them. `to_change` includes only the lines which will be changed. * Use `token.chars().count()` for token char length * Create `changes` with capacity instead of reserving * Remove unnecessary clones in `test_find_line_comment` * Add test case for 0 margin comments * Add comments explaining `find_line_comment`	3 years ago
Nathan Vegdahl	f96b8b769b	Switch to a cleaner range-head moving abstraction. Also fix a bunch of bugs related to it.	3 years ago
Nathan Vegdahl	43594049dd	Merge branch 'master' into great_line_ending_and_cursor_range_cleanup	3 years ago
Nathan Vegdahl	ad814b8c2e	Fix append mode, and make insertion always happen at head of range.	3 years ago
Nathan Vegdahl	ffb8057a7f	Fix ocassional panic when matching brackets.	3 years ago
Nathan Vegdahl	fd684ef693	Revert display-width-based vertical cursor movement. Still needs to be done, but should be part of a separate PR.	3 years ago
Nathan Vegdahl	5841954f58	Calculate the line that the range head is on correctly.	3 years ago
fossdd	d4bd5b3766	The item `fmt` was imported redundantly Fixed warning: ``` warning: the item `fmt` is imported redundantly --> helix-core/src/syntax.rs:98:9 \| 16 \| fmt, \| --- the item `fmt` is already imported here ... 98 \| use std::fmt; \| ^^^^^^^^ \| ```	3 years ago
Nathan Vegdahl	bc85c85501	Fix selections not being modified quite correctly with text edits.	3 years ago
Nathan Vegdahl	c848ed7abc	Fixes for misc bugs with view movement.	3 years ago
Nathan Vegdahl	c9300ec35f	Fix comment toggle command also sometimes toggling the next line.	3 years ago
Nathan Vegdahl	1c6b5581f0	Fix various bugs related to goto-end-of-line command. This also fixes a bug with `Selection::normalize()`, that could result in an out-of-bounds primary index.	3 years ago
Nathan Vegdahl	c400a60377	Fix `Selection::push()` to make the pushed range primary. Apparently I accidentally deleted that behavior in the cleanup.	3 years ago
Nathan Vegdahl	e98d669c30	Handle edge case in `range_to_target()` correctly.	3 years ago
Nathan Vegdahl	b0311f4fc2	Fixed primary cursor position calculation to use 1-width semantics. This had a bunch of knock-on effects that were buggy, such as bracket match highlighting.	3 years ago
Nathan Vegdahl	e462f32723	Merge branch 'master' into great_line_ending_and_cursor_range_cleanup	3 years ago
Nathan Vegdahl	6c038bb015	Update word selection/navigation to work with gap indexing. Also tweaked some of the existing behavior that seemed inconsistent and/or buggy. It's mostly identical, just a few corner cases are different.	3 years ago
Blaž Hrastnik	bf43fabf65	Remove ExactSizeIterator requirement on Transaction::change Size hint is enough.	3 years ago
Cor Peters	cd65a48635	Made toggle_comments language dependent (#463 ) * Made toggle_comments language dependent * Fixed Test Cases * Added clippy suggestion * Small Fixes * Clippy Suggestion Co-authored-by: Cor <prive@corpeters.nl>	3 years ago
Cor Peters	0aa43902ca	Added option to provide a custom config file to the lsp. (#460 ) * Added option to provide a custom config file to the lsp. * Simplified lsp loading routine with anyhow * Moved config to language.toml * Fixed test case * Cargo fmt * Revert now-useless changes * Renamed custom_config to config Co-authored-by: Cor <prive@corpeters.nl>	3 years ago
Nathan Vegdahl	a77274e8bb	Merge branch 'master' into great_line_ending_and_cursor_range_cleanup	3 years ago
Blaž Hrastnik	dd2903ff10	Dynamically load grammar libraries at runtime	3 years ago
Nathan Vegdahl	b4c59b444c	Update surround commands to work with gap indexing.	3 years ago
Kirawi	084a8a9522	Rewritten Rust `highlights.scm` (#425 ) * rewrote Rust highlights.scm * wip * wip * wip * wip * fixed type highlighting * wip * rewrite again * moved operators * missing newline * missing newline * update book * fix constructor highlighting * fix constructor highlighting * fix const highlighting * better constructor highlighting * remove dup, bug was my locals.scm file * fixed docs * merge * fixed for highlighting * add yield * remove yield * added yield back * fixed yield highlighting * unecessary	3 years ago
Nathan Vegdahl	753f7f381b	Implement `Range::put()` which manages range movements and extensions. In particular, this wraps the annoying logic involved in keeping the cursor width to 1 grapheme.	3 years ago
Nathan Vegdahl	85d5b399de	Merge branch 'master' into great_line_ending_and_cursor_range_cleanup	3 years ago
Nathan Vegdahl	6e15c9b874	Make vertical selection movement work properly.	3 years ago
Ivan Tham	6ccfa229ed	Fix typo on comment in surround	3 years ago
Gokul Soumya	351c1e7e55	Fix surround bug when cursor on same pair For example when the cursor is _on_ the `'` in `'word'`, the cursor wouldn't move because the search for a matching pair started _from_ the position of the cursor and simply found itself.	3 years ago
Gokul Soumya	c68fe1f2a3	Add object selection (textobjects) (#385 ) * Add textobjects for word * Add textobjects for surround characters * Apply clippy lints * Remove ThisWordPrevBound in favor of PrevWordEnd It's the same as PrevWordEnd except for taking the current char into account, so use a "flag" to capture that usecase * Add tests for PrevWordEnd movement * Remove ThisWord* movements They did not preserve anchor positions and were only used for textobject boundary search anyway so replace them with simple position finding functions * Rewrite tests of word textobject * Add tests for surround textobject * Add textobject docs * Refactor textobject word position functions * Apply clippy lints on textobject * Fix overflow error with textobjects	3 years ago
Nathan Vegdahl	28d2d68804	Make horizontal selection movement work properly.	3 years ago
Kirawi	c5b2973739	`:reload` (#374 ) * reloading functionality * fn with_newline_eof() * fmt * wip * wip * wip * wip * moved to core, added simd feature for encoding_rs * wip * rm * .gitignore * wip * local wip * wip * wip * no features * wip * nit * remove simd * doc * clippy * clippy * address comments * add indentation & line ending change	3 years ago
Nathan Vegdahl	22dca3b111	Allow last line in file to lack a line break character.	3 years ago
Perry Thompson	e177b27baf	Add missing import	3 years ago
Nathan Vegdahl	230248bbc3	Fix a couple additional `unused` warnings after merge.	3 years ago
Nathan Vegdahl	2224a1527e	Merge branch 'master' into great_line_ending_and_cursor_range_cleanup	3 years ago
Nathan Vegdahl	9f62ad0715	Fixed last `unused` warning.	3 years ago
Nathan Vegdahl	c389f41f14	Fix one of the two remaining warnings. One of them was a lot more obvious than I thought.	3 years ago
Nathan Vegdahl	220bc85821	Fix all remaining warnings in helix-core except for two. I'm not sure how to address them, because they look like they might be bugs, and code is involved. Will poke the relevant people.	3 years ago
Nathan Vegdahl	b571f28641	Remove #[allow(unused)] from helix-core, and fix unused imports. Still a bunch more warnings to fix in core, but it's a start.	3 years ago
Nathan Vegdahl	e725957704	Ensure a minimum selection width on commands that need it.	3 years ago
Nathan Vegdahl	7c7be6d583	Make `Selection`'s normalize and transform methods self-consuming only.	3 years ago
Nathan Vegdahl	0ae522f3df	Clean up `Selection` to not use so many allocations.	3 years ago
Nathan Vegdahl	77a266e818	Better validation method APIs for `Range`. This way they do less work, are more specific to what we actually need, and they compose.	3 years ago
Nathan Vegdahl	d07074740b	Add `Range` methods for various kinds of validation.	3 years ago
Nathan Vegdahl	c1b0a71975	Change the `Range` type and associated functions to gap indexing.	3 years ago
Blaž Hrastnik	3007478567	fix: Correctly merge multiple selection ranges together Fixes #391	3 years ago
PabloMansanet	de8745aea7	Incorporate long word commands into keymap	3 years ago
PabloMansanet	73572b7780	Add long word unit tests	3 years ago
PabloMansanet	073517a92f	Add long word motion implementation	3 years ago
Blaž Hrastnik	51162ae6b2	fix `ca98210d20`	3 years ago
Blaž Hrastnik	ca98210d20	fix: insert() \| delete() would calculate the new insert incorrectly Refs #386	3 years ago
Blaž Hrastnik	d4e1ec339e	Don't crash if diagnostics span past EOF	3 years ago
Blaž Hrastnik	1b102d5532	Extract the merge "operator" into helix-core	3 years ago
Blaž Hrastnik	44566ea812	Release 0.3.0	3 years ago
Nathan Vegdahl	a6cadddef4	Fix silly mistake in previous phantom line bug fix. Fixes #381. I was trying to change an index value that... wasn't even an index value.	3 years ago
Nathan Vegdahl	2dba228c76	Fix highlight code splitting graphemes. This resulted in phantom blank lines in files with CRLF line endings, but could potentially have manifested with other graphemes as well.	3 years ago
Gokul Soumya	394629ab73	Skip enclosed pairs in surround Surround operations previously ignored other pairs that are enclosed within which should be skipped. For example if the cursor is on the `,` in `{{a},{b}}`, doing `md{` previously would delete the `{` on the left of `a` and `}` on the right of `b` instead of the outermost braces. This commit corrects this behavior.	3 years ago
Nathan Vegdahl	9cbf564d08	Handle erroneously ignored case in RopeGraphemes iterator.	3 years ago
Blaž Hrastnik	7f6265ecf3	fix: crash with ctrl-c on empty file	3 years ago
Shafkath Shuhan	fd98e743e8	Handle non-UTF8 files	3 years ago
Nathan Vegdahl	38bf9c2576	Missed some items in the CRLF PR.	3 years ago
Blaž Hrastnik	9c53461429	fix: Select matching at the start of the doc could crash. Fixes #346	3 years ago
Gokul Soumya	892c80771a	Correctly identify pairs when cursor on pair	3 years ago
Gokul Soumya	86271bac18	Refactor and add tests for surround	3 years ago
Gokul Soumya	4754b2e5ae	Add more surround pair characters	3 years ago
Gokul Soumya	13648d28b9	Add surround keybinds	3 years ago
Nathan Vegdahl	f2954fa153	Flesh out the line ending utility unit tests.	3 years ago
Nathan Vegdahl	7c4fa18764	Fix clippy warnings.	3 years ago
Nathan Vegdahl	07e28802f6	Add function to get the line ending of a str slice. This is needed in some places.	3 years ago
Nathan Vegdahl	3d3149e0d5	Silence clippy warning.	3 years ago
Nathan Vegdahl	e686c3e462	Merge branch 'master' of github.com:helix-editor/helix into line_ending_detection Rebasing was making me manually fix conflicts on every commit, so merging instead.	3 years ago
Nathan Vegdahl	4efd6713c5	Work on moving code over to LineEnding instead of assuming '\n'. Also some general cleanup and some minor fixes along the way.	3 years ago
Nathan Vegdahl	5d22e3c4e5	Misc fixes and clean up of line ending detect code.	3 years ago
Blaž Hrastnik	e9a3245aae	Re-export unicode crates from helix_core	3 years ago
Jan Hrastnik	8634e04a31	added the line_end helper function	3 years ago
Jan Hrastnik	701eb0dd68	changed some hardcoded newlines, removed a else if in line_ending.rs	3 years ago
wojciechkepka	6825e19509	Only reconfiure highlights when setting theme	3 years ago
wojciechkepka	ce97a2f05f	Add ability to change theme on editor	3 years ago
Jan Hrastnik	cdd9347457	Merge remote-tracking branch 'origin/master' into line_ending_detection	3 years ago
Jan Hrastnik	97323dc2f9	ran cargo fmt	3 years ago
Jan Hrastnik	ecb884db98	added get_line_ending from pr comment	3 years ago
Wojciech Kępka	41b07486ad	Fix expansion of `~` (#284 ) * Fix expansion of `~`, dont use directory relative to cwd. * Add `expand_tilde` * Bring back `canonicalize_path`, use `expand_tilde` to `normalize` * Make `:open ~` completion work * Fix clippy * Fold home dir into tilde in Document `realitve_path`	4 years ago
Jan Hrastnik	8bccd6df30	applied changes from pr review	4 years ago
Jan Hrastnik	a4f5a0134e	trying out line ending helper functions in commands.rs	4 years ago
Jan Hrastnik	a9a718c3ca	added some tests and a line_ending helper function in document.rs	4 years ago
Jan Hrastnik	e4849f41be	fix typo	4 years ago
Jan Hrastnik	9c419fe05c	added more changes from pr review for line_ending_detection	4 years ago
Jan Hrastnik	5eb6918392	resolved conflict in rebase	4 years ago
Jan Hrastnik	17f69a03e0	ran cargo clippy and cargo fmt	4 years ago
Jan Hrastnik	3756c21bae	rebase on branch line_ending_detection	4 years ago
Benoît CORTIER	6bdf609caa	Remove RwLock for registers Registers are stored inside `Editor` and accessed without `RwLock`. To work around ownership, I added a sister method to `Editor::current`: `Editor::current_with_context`. I tried to modify `Editor::current` directly but it's used at a lot of places so I reverted into this for now at least.	4 years ago
Nathan Vegdahl	0a5580aa21	Address PR comments. - Move char functions into their own module under helix_core. - Use matches!() macro where appropriate. - Use a static lifetime on indent_unit() now that we can.	4 years ago
Ivan Tham	1bda454149	Add ctrl-w for prompt	4 years ago
Wojciech Kępka	4b6aff8c66	Use `runtime` dir when defaulting to executable location	4 years ago
Wojciech Kępka	4a40e935de	Make `runtime_dir` private	4 years ago
Wojciech Kępka	716067ba05	Add more ways to detect runtime directory	4 years ago
Blaž Hrastnik	1665bac1b6	Fix broken test	4 years ago
Blaž Hrastnik	278361a086	Only auto-format for certain languages Fixes #53 Fixes #207	4 years ago
Jakub Bartodziej	69fe46a122	Add :earlier and :later commands that can be used to navigate the full edit history. (#194 ) * Disable deleting from an empty buffer which can cause a crash. * Improve on the fix for deleting from the end of the buffer. * Clean up leftover log. * Avoid theoretical underflow. * Implement :before which accepts a time interval and moves the editor to the closest history state to the commit of the current time minus that interval. Current time is now by default, or the commit time if :before has just been used. * Add :earlier an :later commands that can move through the edit history and retrieve changes hidded by undoing and commiting new changes. The commands accept a number of steps or a time period relative to the currrent change. * Fix clippy lint error. * Remove the dependency on parse_duration, add a custom parser instead. * Fix clippy errors. * Make helix_core::history a public module. * Use the helper for getting the current document and view. * Handled some PR comments. * Fix the logic in :later n. Co-authored-by: Ivan Tham <pickfire@riseup.net> * Add an alias for :earlier. Co-authored-by: Ivan Tham <pickfire@riseup.net> * Add an alias for later. Co-authored-by: Ivan Tham <pickfire@riseup.net> * Run cargo fmt. * Add some tests for earlier and later. * Add more tests and restore the fix for later that diappeared somehow. * Use ? instead of a match on an option. Co-authored-by: Ivan Tham <pickfire@riseup.net> * Rename to UndoKind. * Remove the leftover match. * Handle a bunch of review comments. * More systemd.time compliant time units and additional description for the new commands. * A more concise rewrite of the time span parser using ideas from PR discussion. * Replace a match with map_err(). Co-authored-by: Ivan Tham <pickfire@riseup.net> Co-authored-by: Jakub Bartodziej <jqb@google.com> Co-authored-by: Ivan Tham <pickfire@riseup.net>	4 years ago
PabloMansanet	86af55c379	Movement fixes, refactor and unit test suite (#217 ) * Add convenience/clarity wrapper for Range initialization * Test horizontal moves * Add column jumping tests * Add failing movement conditions for multi-word moves * Refactor skip_over_next * Add complex forward movement unit tests * Add strict whitespace checks and edge case tests * Restore formatting * Remove unused function * Add empty test case for deletion and fix nth_prev_word_boundary * Add tests for backward motion * Refactor word movement * Address review comments and finish refactoring backwards move * Finish unit test suite * Fmt pass * Fix lint erors * Clean up diff restoring bad 'cargo fmt' actions * Simplify movement closures (thanks Pickfire) * Fmt pass * Replace index-based movement with iterator based movement, ensuring that each move incurs a single call to the RopeSlice API * Break down tuple function * Extract common logic to all movement functions * Split iterator helpers away into their own module * WIP reducing clones * Operate on spans * WIP simplifying iterators * Simplify motion helpers * Fix iterator * Fix all unit tests * Refactor and simplify * Simplify fold	4 years ago
notoria	1b14e9a19a	Downgrade `unicode-segmentation`	4 years ago
Ivan Tham	7cc13fefe9	Derive debug without feature Note that this also removed those `finish_non_exhaustive()`.	4 years ago
notoria	1a3a924634	Implement Debug for data structure as a feature	4 years ago
Blaž Hrastnik	aebdef8257	Reuse a cursor from the pool if available (fixes #202 )	4 years ago
Ivan Tham	5e2ba28e0e	Fix panic on ctrl-w empty document	4 years ago
Wojciech Kępka	c978d811d9	Cleanup find_first_non_whitespace_char funcs	4 years ago
Wojciech Kępka	48df05b16d	commands: Add goto first non-whitespace char of line	4 years ago
Kirawi	b873fb9897	Fix Unicode (#135 ) * init * wip * wip * fix unicode break * fix unicode break * Update helix-core/src/transaction.rs Co-authored-by: Benoît Cortier <benoit.cortier@fried-world.eu> * clippy * fix * add changes * added test * wip * wip * wip * wip * fix * fix view * fix #88 Co-authored-by: Benoît Cortier <benoit.cortier@fried-world.eu>	4 years ago
Benoît CORTIER	68affa3c59	Implement register selection User can select register to yank into with the " command. A new state is added to `Editor` and `commands::Context` structs. This state is managed by leveraging a new struct `RegisterSelection`.	4 years ago
Blaž Hrastnik	8d6fad4cac	lsp: Provide workspace root on client.initialize()	4 years ago
ahkrr	e2d780f993	fix: 2 panics while setting style + off by 1 The panics would occur because set_style would draw outside of the the surface. Both occured using `find_prev` or `till_prev` In my case the first panic! would appear in a terminal with around 80 columns in helix/README.md going to the end of the file with `geglf(` the second with `geglfX` The off by one fix ensures that `find_nth_prev` starts at the first character to the left	4 years ago
Benoît CORTIER	8a29086c1a	Fix panic when moving over unicode punctuation `is_ascii_punctuation` will only work for ASCII punctuations, and when we have unicode punctuation (or other) we jump into the `unreachable`. This patch fallback into categorizing everything in this branch as `Unknown`. Fixes https://github.com/helix-editor/helix/issues/123 https://github.com/helix-editor/helix/pull/135: add better support for unicode categories.	4 years ago
Ivan Tham	df80f3c966	Add test for prev word	4 years ago
Ivan Tham	40744ce835	Add ctrl-w in insert mode It seemed to panic when I pressed too many times, but that is from lsp side.	4 years ago
Brian Dawn	5463a436a8	Return an error if we request an embedded file that does not exist. This makes the load_runtime_file function behave like the non-embedded one.	4 years ago
Brian Dawn	e09b0f4eff	Add a smoke test around loading runtime files. This test makes sure we can read some amount of data from the runtime folder.	4 years ago
Brian Dawn	f3db12e240	Simplify the load_runtime_file code. Reduce the number of feature switches for the embed_runtime feature.	4 years ago
Brian Dawn	676719b361	Simplify creating pathbufs. Co-authored-by: Ivan Tham <pickfire@riseup.net>	4 years ago
Brian Dawn	ae105812d6	Apply suggestions from code review Co-authored-by: Ivan Tham <pickfire@riseup.net>	4 years ago
Brian Dawn	62d181de78	Provide a feature flag to be able to embed the runtime folder. These changes provide a new feature flag "embed_runtime" that when enabled and built in release mode will embed the runtime folder into the resulting binary.	4 years ago
ahkrr	444cd0b068	fix: make find_prev_char and till_prev_char work Bevore this PR `commands::find_prev_char` and `commands::till_prev_char` were triggerable through keys but `seach::find_nth_next()` was hardcoded in `_find_char`. The passed `fn` was nerver used. With this PR the passed `fn` is used. The change in search.rs resolves an off by one error in the behivor of `find_nth_prev`	4 years ago
Ivan Tham	6254720f53	Add unreachable context Better error for #123	4 years ago
notoria	2bb71a829e	Don't panic on empty file/buffer (#108 )	4 years ago
Kirawi	c17dcb8633	Fixing Multiple Panics (#121 ) * init * wip * wip	4 years ago
Blaž Hrastnik	06d8d3f55f	Try to detect language when document file path is set Fixes #91	4 years ago
notoria	8af5a9a5cf	Remove swapfile	4 years ago
notoria	f76f44c8af	Convert byte index to char index for `find`	4 years ago
Blaž Hrastnik	74e4ac8d49	Merge pull request #77 from notoria/match_brackets Fix match_brackets::find	4 years ago
notoria	4fe654cf9a	Fix match_brackets::find	4 years ago
Ivan Tham	d664d1dec0	Default log file to cache	4 years ago
Ivan Tham	f5f46b1fed	Separate document history into Cell As history is used separately from the rest of the edits, separating it can avoid needless borrowing and cloning. But one need to be aware later.	4 years ago
Blaž Hrastnik	f4560cb68a	Better fix for w/e that also covers `ia<esc>we`/`ia<esc>wb`	4 years ago
Blaž Hrastnik	0851110d10	f/t: Check if at bounds before searching, refs #43 , closes #37	4 years ago
Blaž Hrastnik	3ace581191	Fix panics when triggering w or e on the last char of the line Closes #32	4 years ago
Blaž Hrastnik	c0264b9f7f	fix: Don't allow moving past last line, fixes #30 , #24 Off by 1 error	4 years ago
Blaž Hrastnik	2cc30cd07c	Categorize _ as a word char, not punctuation	4 years ago
Blaž Hrastnik	17e9386388	Allow moving to EOL byte, also fixes #15	4 years ago
Blaž Hrastnik	6460501a44	Update architecture.md	4 years ago
Blaž Hrastnik	094203c74e	Update deps, introduce the new tree-sitter lifetimes	4 years ago
Blaž Hrastnik	0e5b421646	When calculating a new selection, we need to take newly inserted text into account.	4 years ago
Blaž Hrastnik	4a9d1163e0	Hacky way to specify indent scopes per language via toml configs. Can't do it via a scm query nicely because it returns an iterator over all the matches, whereas we want to traverse the tree ourselves. Can't extract the pattern data from a parsed query either. Oh well, toml files for now.	4 years ago
Blaž Hrastnik	0190fee1c2	Fix indent test, we need to use the in-tree runtime dir.	4 years ago
Blaž Hrastnik	cd1754f783	Fix runtime dir lookup.	4 years ago
Blaž Hrastnik	1f2d87cb95	Make the config dir locator work on Windows.	4 years ago
Blaž Hrastnik	0f77f543e5	Determine runtime dir based on executable location or env override.	4 years ago
Blaž Hrastnik	5954dafdbc	Indent array and tuple lists too.	4 years ago
Blaž Hrastnik	6c705f09e8	Lint	4 years ago
Blaž Hrastnik	7c915dc065	Add the :new command, don't crash if saving without filename.	4 years ago

1 2 3 4 5 ...

427 Commits (2e02a1d6bc004212033b9c4e5ed0de0fd880796c)