Diagnostics are currently extended if text is inserted at their end. This is
desirable when inserting text after an identifier. For example consider:
let foo = 2;
--- unused variable
Renaming the identifier should extend the diagnostic:
let foobar = 2;
------ unused variable
This is currently implemented in helix but as a consequence adding whitespaces
or a type hint also extends the diagnostic:
let foo = 2;
-------- unused variable
let foo: Bar = 2;
-------- unused variable
In these cases the diagnostic should remain unchanged:
let foo = 2;
--- unused variable
let foo: Bar = 2;
--- unused variable
As a heuristic helix will now only extend diagnostics that end on a word char
if new chars are appended to the word (so not for punctuation/ whitespace).
The idea for this mapping was inspired for the word level tracking vscode uses
for many positions. While VSCode doesn't currently update diagnostics after
receiving publishDiagnostic it does use this system for inlay hints for example.
Similarly, the new association mechanism implemented here can be used for word
level tracking of inlay hints.
A similar mapping function is implemented for word starts. Together
these can be used to make a diagnostic stick to a word. If that word
is removed that diagnostic is automatically removed too. This is the exact
same behavior VSCode inlay hints eixibit.
* chore(logo): PrettyPrint to reduce size by 93B ...
* Current size: 2,755 B
* Original size: 2,848 B
* Add file's final newline (linux convention)
* Remove tag separator spaces
* Add newlines
* Add tab indentation (instead of 2/4 spaces)
* Prettify root svg's attribs
* style(logo): Bring style attrb to front
* chore(logo): Remove tab characters
* chore(logo): Remove \n, use LF as final newline
* chore(logo): Minify logo.svg ...
* Remove final newline too
`.glif` files are standard files in the type design industry. From the
Unified Font Object specification website:
The Glyph Interchange Format (GLIF) is a simple and clear XML
representation of a single glyph. GLIF files typically have a .glif
extension.
https://unifiedfontobject.org/versions/ufo3/glyphs/glif/
* agda language support (wip)
* improve highlights
* disable agda-language-server
* minor addendum to documentation
* cargo xtask docgen
* oh i can just do this neat
* minor comment cleanup
* upstream updated
* imports: missed a spot
---------
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Since the tree-sitter grammar is not very good
at parsing function calls while they're being written,
this is not yet super useful.
However, it prevents the new `hybrid` indent heuristic
from choosing these lines as a baseline, making it
more robust.
* build(deps): bump gix from 0.55.2 to 0.56.0
Bumps [gix](https://github.com/Byron/gitoxide) from 0.55.2 to 0.56.0.
- [Release notes](https://github.com/Byron/gitoxide/releases)
- [Changelog](https://github.com/Byron/gitoxide/blob/main/CHANGELOG.md)
- [Commits](https://github.com/Byron/gitoxide/compare/gix-v0.55.2...gix-v0.56.0)
---
updated-dependencies:
- dependency-name: gix
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Adapt to changes in gix EntryMode/EntryKind
The rest of the gix codebase now calls `.kind()` on the mode and uses
the renamed `EntryKind` enum.
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* fix: #8977
fixes the issue that lines with only spaces are getting
joined as well
* reverting some renamings
* improve empty line check
* adding integration test
* reverting code block
* fix conditon check for line end
* applying suggested style
Gabriel Lopes Rodrigues
Sebastian Thiel
Pascal Kuthe
dependabot[bot]
goyalyashpal
Sharpened Blade
romi
Michael Davis
0rphee
Evan Richter
Passw
ath3
ves
Lucas Wagler
Matouš Dzivjak
Gabriel Dinner-David
Novus Nota
JJ
TornaxO7
Daniel Ebert
Susheel Thapa
JR
Jesús González
Matthew Toohey
Phil
Valerii Petryniak
Michal Rostecki
Tanguy
Frederick Schwalbe