1689 Commits (ac0fe29867012ba0840ee7c8893b41d976d5ab38)

Author	SHA1	Message	Date
James O. D. Hunt	ac0fe29867	commands: Make no arg ':theme' show name (#3740) ... Most commands that accept an argument show their current value if no argument is specified. The `:theme` command previously displayed an error message in the status bar if not provided with an argument: ``` Theme name not provided ``` It now shows the current theme name in the status bar if no argument is specified. Signed-off-by: James O. D. Hunt <jamesodhunt@gmail.com> Signed-off-by: James O. D. Hunt <jamesodhunt@gmail.com>	2 years ago
Gaurav Tyagi	ba9e50e93b	Add `:update` that will write the changes if the file has been modified. (#4426) ... * add command update that will write the changes if file hasn been modified * add docs * update the docs	2 years ago
Michał Zabielski	65edf9c198	fix: repeating repeat operator (#4450)	2 years ago
GabrielDertoni	9fae4b8118	fix: terminal freezing on `shell_insert_output` ... This bug occurs on `shell_insert_output` and `shell_append_output` commands. The previous implementation would create a child process using the Rust stdlib's `Command` builder. However, when nothing should be piped in from the editor, the default value for `stdin` would be used. According to the Rust stdlib documentation that is `Stdio::inherit` which will make the child process inherit the parent process' stdin. This would cause the terminal to freeze. This change will set the child process' stdin to `Stdio::null` whenever it doesn't pipe it. In the `if` statement where this change was made there was an extra condition for windows that I am not sure if would require some special treatment.	2 years ago
Michael Davis	c47ca33137	Render diagnostics in the file picker preview (#4324) ... This is mostly for the sake of the diagnostics pickers: without rendering the diagnostic styles, it's hard to tell where the entries in the picker are pointing to.	2 years ago
Michael Davis	d7d0d5ffb7	lsp: Resolve completion items missing documentation on idle (#4406) ... Some language servers may not send the `documentation` field if it is expensive to compute. Clients can request the missing field with a completionItem/resolve request. In this change we use the idle-timeout event to ensure that the current completion item is resolved.	2 years ago
Alexis (Poliorcetics) Bourget	34389e1d54	nit: Do less allocations in `ui::menu::Item::label` implementations ... This complicates the code a little but it often divides by two the number of allocations done by the functions. LSP labels especially can easily be called dozens of time in a single menu popup, when listing references for example.	2 years ago
Alexis (Poliorcetics) Bourget	3aea33a415	nit: move an allocation to happen after a `continue`, making sure it's ... not done for nothing	2 years ago
Skyler Hawthorne	5a848344a9	fix: write-all crash (#4384) ... When we do auto formatting, the code that takes the LSP's response and applies the changes to the document are just getting the currently focused view and giving that to the function, basically always assuming that the document that we're applying the change to is in focus, and not in a background view. This is usually fine for a single view, even if it's a buffer in the background, because it's still the same view and the selection will get updated accordingly for when you switch back to it. But it's obviously a problem for when there are multiple views, because if you don't have the target document in focus, it will ask the document to update the wrong view, hence the crash. The problem with this is picking which view to apply any selection change to. In the absence of any more data points on the views themselves, we simply pick the first view associated with the document we are saving.	2 years ago
Nimrod	bad49ef2d0	Fix unexpected behavior in delete_word_backward and delete_word_forward (#4392)	2 years ago
Skyler Hawthorne	f486f34ebe	flush writes on force quit (#4397) ... When force quitting, we need to block on the pending writes to ensure that write commands succeed before exiting, and also to avoid a crash when all the views are gone before the auto format call returns from the LS.	2 years ago
Charlie Groves	7e29ee6dae	Autosave all when the terminal loses focus (#3178) ... * Autosave all when the terminal loses focus * Correct comment on focus config Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> * Need a block_try_flush_writes in all quit_all paths Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>	2 years ago
Pascal Kuthe	9af7c1c9f3	Sort by fixed diagnostics/is_preffered within codeaction categories	2 years ago
Pascal Kuthe	189aa0bfcf	never sort menu items when no fuzzy matching is possible	2 years ago
Pascal Kuthe	dc3527f52d	use permalink to vscode repo	2 years ago
Pascal Kuthe	8d8b5d6624	use stable sort instead of allocating new vectors	2 years ago
Pascal Kuthe	c70d762a7b	sort autocompletins by fuzzy match	2 years ago
Pascal Kuthe	8673c1ec0c	sort codeaction by their kind instead of alphabetically	2 years ago
Matouš Dzivjak	4cff625054	chore(view): remove indent_unit helper fn (#4389)	2 years ago
Matouš Dzivjak	eee8362015	fix(commands): no last picker error (#4387)	2 years ago
Blaž Hrastnik	78c0cdc519	Merge pull request #2267 from dead10ck/fix-write-fail ... Write path fixes	2 years ago
Fisher Darling	4174b25b3d	Pretty print `tree-sitter-subtree` expression (#4295)	2 years ago
Skyler Hawthorne	756253b43f	fix tree_sitter_scopes	2 years ago
Skyler Hawthorne	e645804b0a	Editor::flush_writes returns an error	2 years ago
Blaž Hrastnik	52ba550098	Use flush_writes in application.close()	2 years ago
Blaž Hrastnik	55b50d9e83	Seems like this flush is unnecessary	2 years ago
Blaž Hrastnik	b0212b3611	Deduplicate flush_writes	2 years ago
Blaž Hrastnik	30c93994b5	Use a single save_queue on the editor	2 years ago
Skyler Hawthorne	beb3427bfb	improve app close failure display	2 years ago
Skyler Hawthorne	31d1bbfddb	review comments	2 years ago
Skyler Hawthorne	3f07885b35	document should save even if formatter fails	2 years ago
Skyler Hawthorne	b530a86d1f	remove Callback::Compositor variant ... To reduce likelihood of accidental discarding of important callbacks	2 years ago
Skyler Hawthorne	b3fc31a211	move language server refresh to document saved event handler	2 years ago
Skyler Hawthorne	af03df3413	fix write scratch buffer to file	2 years ago
Skyler Hawthorne	18c32118b1	Save text in document saved events, use in status message	2 years ago
Skyler Hawthorne	f82a551b98	Rename doc save event names to past tense	2 years ago
Skyler Hawthorne	57de4e6251	various fixes in write-all path	2 years ago
Skyler Hawthorne	d544376590	reset idle timer for all events	2 years ago
Skyler Hawthorne	e5fd5e2a9c	fix panic when view of pending write is closed	2 years ago
Skyler Hawthorne	8c667ef8de	factor editor event handling into function	2 years ago
Skyler Hawthorne	aaa1450678	fix write-quit with auto format ... write-quit will now save all files successfully even when there is auto formatting	2 years ago
Skyler Hawthorne	c9418582d2	fix modified status with auto format	2 years ago
Skyler Hawthorne	cb23399dee	improve reliability of shutdown	2 years ago
Skyler Hawthorne	b8a07f7d15	add conditional noop render back ... It makes it much slower without stubbing this out	2 years ago
Skyler Hawthorne	69c9e44ef2	update write-quit to wait for saves	2 years ago
Skyler Hawthorne	e1f7bdb1d2	fix buffer-close	2 years ago
Skyler Hawthorne	83b6042b97	fix(write): do not set new path on document until write succeeds ... If a document is written with a new path, currently, in the event that the write fails, the document still gets its path changed. This fixes it so that the path is not updated unless the write succeeds.	2 years ago
Skyler Hawthorne	a5a93182cd	fix: buffer-close ensuring writes ... Make sure buffer-close waits for the document to finish its writes.	2 years ago
Skyler Hawthorne	d706194597	chore(write): serialize write operations within a Document ... The way that document writes are handled are by submitting them to the async job pool, which are all executed opportunistically out of order. It was discovered that this can lead to write inconsistencies when there are multiple writes to the same file in quick succession. This seeks to fix this problem by removing document writes from the general pool of jobs and into its own specialized event. Now when a user submits a write with one of the write commands, a request is simply queued up in a new mpsc channel that each Document makes to handle its own writes. This way, if multiple writes are submitted on the same document, they are executed in order, while still allowing concurrent writes for different documents.	2 years ago
Jonathan LEI	1a772d1b67	Fix deleting word from end of buffer (#4328)	2 years ago