129 Commits (b85ca7b2b636c9922231c25328ccecd828f4a71f)

Author	SHA1	Message	Date
sigmaSd	4960c41f18	feat(lsp): add support for lsp Diagnostic{}.data (#4935)	2 years ago
Michael Davis	8be2d1dcbf	Handle language server termination (#4797) ... This change handles a language server exiting. This was a UX sore-spot: if a language server crashed, Helix did not recognize the exit and continued to send requests to it. All requests would timeout since they would not receive responses. This would also hold-up Helix closing itself down since it would try to gracefully shutdown the server which is implemented in the LSP spec as a request. We could attempt to automatically restart the language server on crash. I left this for future work since that change will need to be slightly complicated: it will need to cover the case of a language server repeatedly crashing.	2 years ago
ath3	7c9809eeb2	Find workspace from document path (#3553)	2 years ago
Alexis Kalabura	b9ff5d0e0a	[lsp-restart]: call the force_shutdown method for the old_client (#3972) ... * [lsp-restart]: call the shutdown_and_exit method for the old_client * change shutdown_and_exit to force_shutdown * remove extra log	2 years ago
Kirawi	8c2cc43017	diff full-doc LSP edits (#4041) ... Co-authored-by: Michael Davis <mcarsondavis@gmail.com>	2 years ago
Filipe Azevedo	385ccdfc9c	add :lsp-restart command (#3435)	2 years ago
Blaž Hrastnik	1df32c917c	diagnostics: Use Vec<Tag> instead of Option<Vec<Tag>>	2 years ago
Luke Cycon	64b0745413	Track source and tags in diagnostics (#3898)	2 years ago
Blaž Hrastnik	a123fb6057	Remove LspNotDefined, instead return an Option<>	2 years ago
Blaž Hrastnik	1caba2d3e8	lsp: Don't log "LSP not defined" errors in the logfile	2 years ago
PiergiorgioZagaria	219d2c2515	Change default formatter for any language (#2942) ... * Change default formatter for any language * Fix clippy error * Close stdin for Stdio formatters * Better indentation and pattern matching * Return Result<Option<...>> for fn format instead of Option * Remove unwrap for stdin * Handle FormatterErrors instead of Result<Option<...>> * Use Transaction instead of LspFormatting * Use Transaction directly in Document::format * Perform stdin type formatting asynchronously * Rename formatter.type values to kebab-case * Debug format for displaying io::ErrorKind (msrv fix) * Solve conflict? * Use only stdio type formatters * Remove FormatterType enum * Remove old comment * Check if the formatter exited correctly * Add formatter configuration to the book * Avoid allocations when writing to stdin and formatting errors * Remove unused import Co-authored-by: Gokul Soumya <gokulps15@gmail.com>	2 years ago
Erasin	42115d02bc	Suport diagnostic code (#3096) ... * add code for diagnostic. This PR provides a solution to resolve #2994. missing Code Actions for lsp * remote unused import	2 years ago
Michael Davis	45ce1ebdb6	embed jsonrpc types from jsonrpc-core crate (#2801) ... We should not depend on jsonrpc-core anymore: * The project just announced it's no longer actively maintained[^1], preferring their new implementation in `jsonrpsee`. * The types are too strict: we would benefit from removing some `#[serde(deny_unknown_fields)]` annotations to allow language servers that disrespect the spec[^2]. * We don't use much of the project. Just the types out of core. These are easy to embed directly into the `helix-lsp` crate. [^1]: https://github.com/paritytech/jsonrpc/pull/674 [^2]: https://github.com/helix-editor/helix/issues/2786	2 years ago
Blaž Hrastnik	3d91c99c3e	fix: lsp: Sort edits by start range, Omnisharp sends them in reverse	3 years ago
Blaž Hrastnik	7ae6cad52e	Don't panic on LSP parsing errors ... This made sense initially when the implementation was still new (so we got user reports more frequently), but a parsing error now generally signifies a language server isn't properly implementing the spec.	3 years ago
EmmChriss	807cdc60bf	configurable lsp request timeout (#2405)	3 years ago
chunghha	3a398eec56	fix typos (#2304)	3 years ago
Michael Davis	449d1dfdfb	prevent panic when receiving malformed LSP PublishDiagnostic (#2160) ... Instead of panicing we can discard the malformed diagnostic. This `.parse()` fails commonly when a non-conformant language server gives a diagnostic with a location that breaks the spec: { "character": 0, "line": -1 } can currently be returned by ElixirLS and the python LS. Other messages in this block are discarded but this one feels special enough to log.	3 years ago
Robin Jadoul	33b7483db5	Send active diagnostics to LSP when requesting code actions. (#2005) ... * Send active diagnostics to LSP when requesting code actions. This allows for e.g. clangd to properly send the quickfix code actions corresponding to those diagnostics as options. The LSP spec v3.16.0 introduced an opaque `data` member that would allow the server to persist arbitrary data between the diagnostic and the code actions request, but this is not supported yet by this commit. * Reuse existing range_to_lsp_range functionality	3 years ago
Blaž Hrastnik	8adf0c1b3a	lsp: Implement support for workspace_folders (currently just one) ... Refs #1898	3 years ago
Triton171	f044059a2a	Implement LSP `workspace/configuration` and `workspace/didChangeConfiguration` (#1684) ... * Implement LSP `workspace/configuration` request * Implement LSP `workspace/didChangeConfiguration` notification. * Simplify retrieval of LSP configuration * Implement suggestions from PR discussion Co-authored-by: Triton171 <triton0171@gmail.com>	3 years ago
Kirawi	ea095ca5fb	Optimize lsp_pos_to_pos (#1423) ... lines().count() is slow compared to len_lines()	3 years ago
Alexis Mousset	8a019b423f	Detect workspace root using language markers (#1370) ... * Detect workspace root using language markers * Avoid allocating root_markers * Update helix-core/src/lib.rs Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> * Update helix-core/src/lib.rs Co-authored-by: Kirawi <67773714+kirawi@users.noreply.github.com> Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Kirawi <67773714+kirawi@users.noreply.github.com>	3 years ago
Matouš Dzivjak	75a8b789d2	LSP code action commands (#1304) ... * feat(lsp): codeAction commands * Don't block on command call * Fix lifetime of command execution * Fix lint issues	3 years ago
Blaž Hrastnik	d31bef7fea	lsp: Don't panic if init fails ... We correctly filter out the language server inside Document to ignore it if the capabilities are missing, so this way it'll simply ignore the errored out LSP rather than panicking.	3 years ago
Midnight Exigent	eedcea7e6b	Allow `language.config` (in languages.toml) to be passed in as a toml object (#807) ... * allow language.config (in languages.toml) to be passed in as a toml object * Change config field for languages from json string to toml object * remove indents on languages.toml config * fix: remove patch version from serde_json import in helix-core * Use same tree-sitter-zig as upstream/master	3 years ago
Kirawi	ef532e0c0d	log errors produced when trying to initialize the LSP (#746)	3 years ago
Blaž Hrastnik	46f3c69f06	lsp: Don't send notifications until initialize completes ... Then send open events for all documents with the LSP attached.	3 years ago
Blaž Hrastnik	48fd4843fc	lsp: Outdated comment	3 years ago
Blaž Hrastnik	5a558e0d8e	lsp: Delay requests & notifications until initialization is complete	3 years ago
Blaž Hrastnik	c3a58cdadd	lsp: Refactor capabilities as an async OnceCell ... First step in making LSP init asynchronous	3 years ago
Cor Peters	0aa43902ca	Added option to provide a custom config file to the lsp. (#460) ... * Added option to provide a custom config file to the lsp. * Simplified lsp loading routine with anyhow * Moved config to language.toml * Fixed test case * Cargo fmt * Revert now-useless changes * Renamed custom_config to config Co-authored-by: Cor <prive@corpeters.nl>	3 years ago
Joe Neeman	c9be480bf8	Make formatting happen asynchronously.	3 years ago
Blaž Hrastnik	cad14c6b46	Address nightly clippy warnings	3 years ago
wojciechkepka	cc357d5096	Add progress spinners to status line	3 years ago
wojciechkepka	c2aad859b1	Handle language server shutdown with timeout	3 years ago
wojciechkepka	38cb934d8f	Add unique id to each lsp client/server pair	3 years ago
wojciechkepka	52fb90b81e	Add `MethodCall`, `ProgressStatus`, `LspProgressMap`	3 years ago
Robin	9baf1ecc90	add symbol picker (#230) ... * add symbol picker use the lsp document_symbol request * fix errors from merging in master * add docs for symbol picker	4 years ago
Wojciech Kępka	c754df12b3	lsp: Check bounds when converting lsp positions (#204) ... * lsp: Make position conversion funcs return `Option` * Add tests * Fixes * Revert pos_to_lsp_pos to panic	4 years ago
Wojciech Kępka	098806ce2a	lsp: Display LSP progress messages (#216)	4 years ago
Ivan Tham	7cc13fefe9	Derive debug without feature ... Note that this also removed those `finish_non_exhaustive()`.	4 years ago
notoria	1a3a924634	Implement Debug for data structure as a feature	4 years ago
Egor Karavaev	ea6667070f	helix-lsp cleanup	4 years ago
Egor Karavaev	960bc9f134	Don't panic on LSP not starting	4 years ago
Egor Karavaev	d55419604c	Remove select_all implementation	4 years ago
Blaž Hrastnik	e4ff75b4d4	Add :fmt (formats the whole file).	4 years ago
Blaž Hrastnik	6c705f09e8	Lint	4 years ago
Blaž Hrastnik	caf4349925	Remove some of the panics, just log instead.	4 years ago
Blaž Hrastnik	ba97005495	Work around the rest of the blocking issues.	4 years ago
Blaž Hrastnik	355ad3cb82	Tokio migration.	4 years ago
Blaž Hrastnik	3b90317060	Add window/showMessage / logMessage stubs so gopls fully starts.	4 years ago
Blaž Hrastnik	3e5f24a9d5	lsp: support both utf-8 and utf-16 offsets. ... Still need to implement the clangd encoding negotiation, but it's a start. Should also manually override to utf8 for pyls.	4 years ago
Blaž Hrastnik	5aed1f3c00	lsp: Gracefully fail if binary doesn't exist.	4 years ago
Blaž Hrastnik	2a3910c1d9	wip: Async async. Delay response handling with a callback.	4 years ago
Blaž Hrastnik	e3c4edae32	Add the machinery to load syntax config from TOML. ... It's embedded into the binary at build time for now, but it's progress.	4 years ago
Blaž Hrastnik	e9bd9e72c3	Pos conversions always operate on whole documents.	4 years ago
Blaž Hrastnik	5237084d98	Don't publicly re-export once_cell in lsp.	4 years ago
Blaž Hrastnik	59e6024186	Remove State from a few more signatures.	4 years ago
Blaž Hrastnik	8eaf9a432d	Make Transaction::change only rely on the rope.	4 years ago
Blaž Hrastnik	87e3cd3df2	ui: Render diagnostic errors in sideline.	4 years ago
Blaž Hrastnik	bb87b08fc9	Configure language servers via LanguageConfiguration.	4 years ago
Blaž Hrastnik	1ae7c43391	commands: = as range formatting (via lsp)	4 years ago
Blaž Hrastnik	c9dd1c930e	treewide: &RopeSlice -> RopeSlice. It's Copy so no reason to pass by ref	4 years ago
Blaž Hrastnik	05c7fb98df	Refactoring: move language_servers into Editor, proper load for doc.	4 years ago
Blaž Hrastnik	777a80917d	Address clippy lints.	4 years ago
Blaž Hrastnik	3cbab20908	lsp: Fix pos_to_lsp_pos calculation.	4 years ago
Blaž Hrastnik	cd16df19c1	lsp: generate_transaction_from_text_edits	4 years ago
Blaž Hrastnik	955cb81687	Init lsp through the registry.	4 years ago
Blaž Hrastnik	39bf1ca825	Update deps.	4 years ago
Blaž Hrastnik	a7869c728c	wip	4 years ago
Blaž Hrastnik	cc6bdf8f66	Text change generation, RPC call handling.	4 years ago
Blaž Hrastnik	81ccca0c6a	Improve error typing.	4 years ago
Blaž Hrastnik	ef5e5f9296	state.version tracking	4 years ago
Blaž Hrastnik	49254d7180	Total mess but it works: diagnostic marking.	4 years ago
Blaž Hrastnik	f9bfba4d96	Reroute LSP notification events into the main app event loop.	4 years ago
Blaž Hrastnik	13cb442850	wip: Fetching diagnostics, parsing notifications.	4 years ago
Blaž Hrastnik	f03830b047	wip: Basic LSP lifecycle requests/notifications.	4 years ago
Blaž Hrastnik	8adcf5083f	wip	4 years ago