79 Commits (e2d2f19fd02419b8d144ae7a8a359d31bd773af7)

Author	SHA1	Message	Date
Matouš Dzivjak	2e02a1d6bc	feat(commands): shrink_selection (#1340) ... * feat(commands): shrink_selection Add `shrink_selection` command that can be used to shrink previously expanded selection. To make `shrink_selection` work it was necessary to add selection history to the Document since we want to shrink the selection towards the syntax tree node that was initially selected. Selection history is cleared any time the user changes selection other way than by `expand_selection`. This ensures that we don't get some funky edge cases when user calls `shrink_selection`. Related: https://github.com/helix-editor/helix/discussions/1328 * Refactor shrink_selection, move history to view * Remove useless comment * Add default key mapping for extend&shrink selection * Rework contains_selection method * Shrink selection without expand selects first child	3 years ago
Matouš Dzivjak	bd2ab5be43	feat(commands): ensure_selections_forward (#1393) ... * feat(commands): ensure_selections_forward Add command that ensures that selections are in forward direction. Fixes: https://github.com/helix-editor/helix/issues/1332 * Add keybinding for ensure_selections_forward Add `A-:` keybinding for the ensure_selections_forward command. * Re-use range.flip for flip_selections command	3 years ago
Skyler Hawthorne	5b4540fc2d	Auto pairs selection (#1254) ... * use auto pairs with selections Previously, the auto pairs code was converting the user selection into its cursor form, and setting the transaction's selection to that cursor. This has the effect of destroying the user's selection if they type a pair character that gets auto completed. This fixes the code to work with the user's selection, inserting auto pairs where appropriate, but either keeping or extending the user's selection. * use movement::Direction instead of bool * assume 0-width cursor is forward	3 years ago
Gokul Soumya	dc53e65b9e	Fix surround cursor position calculation (#1183) ... Fixes #1077. This was caused by the assumption that a block cursor is represented as zero width internally and simply rendered to be a single width selection, where as in reality a block cursor is an actual single width selection in form and function. Behavioural changes: 1. Surround selection no longer works when cursor is _on_ a surround character that has matching pairs (like `'` or `"`). This was the intended behaviour from the start but worked till now because of the cursor position calculation mismatch.	3 years ago
ath3	90fd09f2cc	Fix selection remove doc comment (#1122)	3 years ago
Omnikar	bf95a9ed04	Add `remove_selections` command (#1065) ... * Add `remove_selections` command * Document `remove_selections` * Update helix-term/src/keymap.rs Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>	3 years ago
Blaž Hrastnik	6431b26a6a	Implement Selection::replace to replace a single range ... Fixes #985 Co-authored-by: Daniel S Poulin <crimsonmage+github@gmail.com>	3 years ago
Ivan Tham	4260b31ec0	Update mdbook style and fix unreadable table head (#806) ... The styles are now pulled from upstream styles, some of the changes I submitted it back to upstream. Fix #796	3 years ago
Blaž Hrastnik	2e0803c8d9	Implement 'remove_primary_selection' as Alt-, ... This allows removing search matches from the selection Fixes #713	3 years ago
Blaž Hrastnik	62eb8c6b40	mouse: Remove verify_screen_coords, refactor primary selection modification	3 years ago
Nathan Vegdahl	cd7302ffd3	Enforce cursor/selection invariants in one place. ... Rather than per-command like before.	3 years ago
Nathan Vegdahl	5229c5387f	Add unit tests for some of the new `Range` methods.	3 years ago
Nathan Vegdahl	b2c76dc627	Improve `Range` documentation and organization.	3 years ago
Nathan Vegdahl	0883b4fae0	Collect some common patterns into methods on `Range`.	3 years ago
Nathan Vegdahl	f96b8b769b	Switch to a cleaner range-head moving abstraction. ... Also fix a bunch of bugs related to it.	3 years ago
Nathan Vegdahl	ad814b8c2e	Fix append mode, and make insertion always happen at head of range.	3 years ago
Nathan Vegdahl	5841954f58	Calculate the line that the range head is on correctly.	3 years ago
Nathan Vegdahl	bc85c85501	Fix selections not being modified quite correctly with text edits.	3 years ago
Nathan Vegdahl	c848ed7abc	Fixes for misc bugs with view movement.	3 years ago
Nathan Vegdahl	c9300ec35f	Fix comment toggle command also sometimes toggling the next line.	3 years ago
Nathan Vegdahl	1c6b5581f0	Fix various bugs related to goto-end-of-line command. ... This also fixes a bug with `Selection::normalize()`, that could result in an out-of-bounds primary index.	3 years ago
Nathan Vegdahl	c400a60377	Fix `Selection::push()` to make the pushed range primary. ... Apparently I accidentally deleted that behavior in the cleanup.	3 years ago
Nathan Vegdahl	b0311f4fc2	Fixed primary cursor position calculation to use 1-width semantics. ... This had a bunch of knock-on effects that were buggy, such as bracket match highlighting.	3 years ago
Nathan Vegdahl	b4c59b444c	Update surround commands to work with gap indexing.	3 years ago
Nathan Vegdahl	753f7f381b	Implement `Range::put()` which manages range movements and extensions. ... In particular, this wraps the annoying logic involved in keeping the cursor width to 1 grapheme.	3 years ago
Nathan Vegdahl	85d5b399de	Merge branch 'master' into great_line_ending_and_cursor_range_cleanup	3 years ago
Gokul Soumya	c68fe1f2a3	Add object selection (textobjects) (#385) ... * Add textobjects for word * Add textobjects for surround characters * Apply clippy lints * Remove ThisWordPrevBound in favor of PrevWordEnd It's the same as PrevWordEnd except for taking the current char into account, so use a "flag" to capture that usecase * Add tests for PrevWordEnd movement * Remove ThisWord* movements They did not preserve anchor positions and were only used for textobject boundary search anyway so replace them with simple position finding functions * Rewrite tests of word textobject * Add tests for surround textobject * Add textobject docs * Refactor textobject word position functions * Apply clippy lints on textobject * Fix overflow error with textobjects	3 years ago
Nathan Vegdahl	230248bbc3	Fix a couple additional `unused` warnings after merge.	3 years ago
Nathan Vegdahl	2224a1527e	Merge branch 'master' into great_line_ending_and_cursor_range_cleanup	3 years ago
Nathan Vegdahl	220bc85821	Fix all remaining warnings in helix-core except for two. ... I'm not sure how to address them, because they look like they might be bugs, and code is involved. Will poke the relevant people.	3 years ago
Nathan Vegdahl	b571f28641	Remove #[allow(unused)] from helix-core, and fix unused imports. ... Still a bunch more warnings to fix in core, but it's a start.	3 years ago
Nathan Vegdahl	e725957704	Ensure a minimum selection width on commands that need it.	3 years ago
Nathan Vegdahl	7c7be6d583	Make `Selection`'s normalize and transform methods self-consuming only.	3 years ago
Nathan Vegdahl	0ae522f3df	Clean up `Selection` to not use so many allocations.	3 years ago
Nathan Vegdahl	77a266e818	Better validation method APIs for `Range`. ... This way they do less work, are more specific to what we actually need, and they compose.	3 years ago
Nathan Vegdahl	d07074740b	Add `Range` methods for various kinds of validation.	3 years ago
Nathan Vegdahl	c1b0a71975	Change the `Range` type and associated functions to gap indexing.	3 years ago
Blaž Hrastnik	3007478567	fix: Correctly merge multiple selection ranges together ... Fixes #391	3 years ago
Blaž Hrastnik	9c53461429	fix: Select matching at the start of the doc could crash. Fixes #346	3 years ago
PabloMansanet	86af55c379	Movement fixes, refactor and unit test suite (#217) ... * Add convenience/clarity wrapper for Range initialization * Test horizontal moves * Add column jumping tests * Add failing movement conditions for multi-word moves * Refactor skip_over_next * Add complex forward movement unit tests * Add strict whitespace checks and edge case tests * Restore formatting * Remove unused function * Add empty test case for deletion and fix nth_prev_word_boundary * Add tests for backward motion * Refactor word movement * Address review comments and finish refactoring backwards move * Finish unit test suite * Fmt pass * Fix lint erors * Clean up diff restoring bad 'cargo fmt' actions * Simplify movement closures (thanks Pickfire) * Fmt pass * Replace index-based movement with iterator based movement, ensuring that each move incurs a single call to the RopeSlice API * Break down tuple function * Extract common logic to all movement functions * Split iterator helpers away into their own module * WIP reducing clones * Operate on spans * WIP simplifying iterators * Simplify motion helpers * Fix iterator * Fix all unit tests * Refactor and simplify * Simplify fold	3 years ago
Kirawi	c17dcb8633	Fixing Multiple Panics (#121) ... * init * wip * wip	3 years ago
Blaž Hrastnik	6c705f09e8	Lint	4 years ago
Blaž Hrastnik	95dd55ba94	Fix overlap calculation.	4 years ago
Blaž Hrastnik	73f4abbb37	N as extend with search (for now, N should be search_prev).	4 years ago
Blaž Hrastnik	35b4fe4cd0	Fix range.overlap()	4 years ago
Blaž Hrastnik	742b3a709f	Store intra-files jumps (goto) on the jumplist.	4 years ago
Blaž Hrastnik	06aca7691c	clippy lint	4 years ago
Blaž Hrastnik	bd607b4cbd	Provide a capacity on Selection::new's normalize.	4 years ago
Blaž Hrastnik	c4792efead	clippy lints	4 years ago
Blaž Hrastnik	798dbd27c5	Selection: fail early if new() is called with no ranges.	4 years ago