mirror of https://github.com/helix-editor/helix
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
72b9311678
The top of a view is marked by a char idx anchor. That char idx is usually the first character of the visual line it's on. We use a char index instead of a line index because the view may start in the middle of a line with soft wrapping. However, it's possible to temporarily endup in a state where this anchor is not the first character of the first visual line. This is pretty rare because edits usually happen inside/after the view. In most cases we handle this case correctly. However, if the cursor is before the anchor (but still in view) there can be crashes or visual artifacts. This is caused by the fact that visual_offset_from_anchor (and the positioning code in view.rs) incorrectly assumed that the (cursor) position is always after the view anchor if the cursor is in view. But if the anchor is not the first character of the first visual line this is not the case anymore. In that case crashes and visual artifacts are possible. This commit fixes that problem by changing `visual_offset_from_anchor` (and callsites) to properly consider that case. |
2 years ago | |
|---|---|---|
| .. | ||
| handlers | 2 years ago | |
| base64.rs | 2 years ago | |
| clipboard.rs | 2 years ago | |
| document.rs | 2 years ago | |
| editor.rs | 2 years ago | |
| env.rs | 2 years ago | |
| graphics.rs | 2 years ago | |
| gutter.rs | 2 years ago | |
| info.rs | 2 years ago | |
| input.rs | 2 years ago | |
| keyboard.rs | 2 years ago | |
| lib.rs | 2 years ago | |
| macros.rs | 2 years ago | |
| theme.rs | 2 years ago | |
| tree.rs | 2 years ago | |
| view.rs | 2 years ago | |