mirror of https://github.com/helix-editor/helix
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
d5f17d3f69
The purpose of this change is to remove the mutable self borrow on
`HighlightIterLayer::sort_key` so that we can sort layers with the
correct ordering using the `Vec::sort` function family.
`HighlightIterLayer::sort_key` needs `&mut self` since it calls
`Peekable::peek` which needs `&mut self`. `Vec::sort` functions
only give immutable borrows of the elements to ensure the
correctness of the sort.
We could instead approach this by creating an eager Peekable and using
that instead of `std::iter::Peekable` to wrap `QueryCaptures`:
```rust
struct EagerPeekable<I: Iterator> {
iter: I,
peeked: Option<I::Item>,
}
impl<I: Iterator> EagerPeekable<I> {
fn new(mut iter: I) -> Self {
let peeked = iter.next();
Self { iter, peeked }
}
fn peek(&self) -> Option<&I::Item> {
self.peeked.as_ref()
}
}
impl<I: Iterator> Iterator for EagerPeekable<I> {
type Item = I::Item;
fn next(&mut self) -> Option<Self::Item> {
std::mem::replace(&mut self.peeked, self.iter.next())
}
}
```
This would be a cleaner approach (notice how `EagerPeekable::peek`
takes `&self` rather than `&mut self`), however this doesn't work in
practice because the Items emitted by the `tree_sitter::QueryCaptures`
Iterator must be consumed before the next Item is returned.
`Iterator::next` on `tree_sitter::QueryCaptures` modifies the
`QueryMatch` returned by the last call of `next`. This behavior is
not currently reflected in the lifetimes/structure of `QueryCaptures`.
This fixes an issue with layers being out of order when using combined
injections since the old code only checked the first range in the
layer. Layers being out of order could cause missing highlights for
combined-injections content.
|
2 years ago | |
|---|---|---|
| .. | ||
| doc_formatter | 2 years ago | |
| increment | 2 years ago | |
| auto_pairs.rs | 2 years ago | |
| chars.rs | 3 years ago | |
| comment.rs | 2 years ago | |
| config.rs | 3 years ago | |
| diagnostic.rs | 2 years ago | |
| diff.rs | 2 years ago | |
| doc_formatter.rs | 2 years ago | |
| graphemes.rs | 2 years ago | |
| history.rs | 2 years ago | |
| indent.rs | 2 years ago | |
| lib.rs | 2 years ago | |
| line_ending.rs | 2 years ago | |
| macros.rs | 4 years ago | |
| match_brackets.rs | 3 years ago | |
| movement.rs | 2 years ago | |
| object.rs | 2 years ago | |
| path.rs | 2 years ago | |
| position.rs | 2 years ago | |
| register.rs | 2 years ago | |
| search.rs | 3 years ago | |
| selection.rs | 2 years ago | |
| shellwords.rs | 2 years ago | |
| surround.rs | 2 years ago | |
| syntax.rs | 2 years ago | |
| test.rs | 2 years ago | |
| text_annotations.rs | 2 years ago | |
| textobject.rs | 2 years ago | |
| transaction.rs | 2 years ago | |
| wrap.rs | 3 years ago | |