You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
helix/helix-term/src
Cole Helbling 34934733b3
helix-term: send the STOP signal to all processes in the process group (#3546)
* helix-term: send the STOP signal to all processes in the process group

From kill(3p):

    If pid is 0, sig shall be sent to all processes (excluding an unspecified set
    of  system processes) whose process group ID is equal to the process group ID
    of the sender, and for which the process has permission to send a signal.

This fixes the issue of running `git commit`, attempting to suspend
helix with ^Z, and then not regaining control over the terminal and
having to press ^Z again.

* helix-term: use libc directly to send STOP signal

* helix-term: document safety of libc::kill

* helix-term: properly handle libc::kill's failure

I misread the manpage for POSIX `kill` -- it returns `-1` in
the failure case, and sets `errno`, which is retrieved via
`std::io::Error::last_os_error()`, has its string representation printed
out, and then exits with the matching status code (or 1 if, for whatever
reason, there is no matching status code).

* helix-term: expand upon why we need to SIGSTOP the entire process group

Also add a link back to one of the upstream issues.
2 years ago
..
commands Feat: LSP Type Hints (#5934) 2 years ago
keymap feat(dap): implement Restart request (#5651) 2 years ago
ui indent snippets to line indent instead of completion start (#6263) 2 years ago
application.rs helix-term: send the STOP signal to all processes in the process group (#3546) 2 years ago
args.rs Fix confusion with using --hsplit --vsplit on startup at same time (#4202) 2 years ago
commands.rs Feat: LSP Type Hints (#5934) 2 years ago
compositor.rs bump msrv to 1.63 (#5570) 2 years ago
config.rs Move top level lsp config to editor.lsp (#1868) 3 years ago
health.rs Generalised to multiple runtime directories with priorities (#5411) 2 years ago
job.rs bump msrv to 1.63 (#5570) 2 years ago
keymap.rs keymap: Test backslash escaping in commands 2 years ago
lib.rs Fix new clippy lints (#5892) 2 years ago
main.rs feat(lsp): pass client_info on initialization (#4904) 2 years ago