From 1789dfabfe68c00dda3b861b828ea7a50860f6e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bla=C5=BE=20Hrastnik?= Date: Fri, 23 Jul 2021 18:12:33 +0900 Subject: [PATCH] fix: ui/menu: Don't allow scrolling past the end of completion Fixes #472 --- helix-term/src/ui/menu.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/helix-term/src/ui/menu.rs b/helix-term/src/ui/menu.rs index dc3bbf7f..5a6f6256 100644 --- a/helix-term/src/ui/menu.rs +++ b/helix-term/src/ui/menu.rs @@ -90,13 +90,13 @@ impl Menu { pub fn move_up(&mut self) { // TODO: wrap around to end - let pos = self.cursor.map_or(0, |i| i.saturating_sub(1)) % self.options.len(); + let pos = self.cursor.map_or(0, |i| i.saturating_sub(1)) % self.matches.len(); self.cursor = Some(pos); self.adjust_scroll(); } pub fn move_down(&mut self) { - let pos = self.cursor.map_or(0, |i| i + 1) % self.options.len(); + let pos = self.cursor.map_or(0, |i| i + 1) % self.matches.len(); self.cursor = Some(pos); self.adjust_scroll(); }