From 2a853cd41dd15d2891ac6ca17372c9f5f00a8528 Mon Sep 17 00:00:00 2001 From: Ivan Tham Date: Wed, 20 Apr 2022 09:46:46 +0800 Subject: [PATCH] Fix open on multiline selection (#2161) Select multiple line and open should be based on the whole selection and not just the line of the cursor, which causes weird behavior like opening in the middle of the selection which user might not expect. --- helix-term/src/commands.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/helix-term/src/commands.rs b/helix-term/src/commands.rs index 15ccc247..4e13f74a 100644 --- a/helix-term/src/commands.rs +++ b/helix-term/src/commands.rs @@ -2292,8 +2292,10 @@ fn open(cx: &mut Context, open: Open) { let mut offs = 0; let mut transaction = Transaction::change_by_selection(contents, selection, |range| { - let cursor_line = range.cursor_line(text); - + let cursor_line = text.char_to_line(match open { + Open::Below => graphemes::prev_grapheme_boundary(text, range.to()), + Open::Above => range.from(), + }); let new_line = match open { // adjust position to the end of the line (next line - 1) Open::Below => cursor_line + 1,