lldb: use stdio transport by default

helix-core/src/syntax.rs

@@ -98,6 +98,7 @@ pub struct DebugAdapterConfig {
     pub name: String,
     pub transport: String,
     pub command: String,
+    #[serde(default)]
     pub args: Vec<String>,
     pub port_arg: Option<String>,
     pub templates: Vec<DebugTemplate>,

helix-dap/src/client.rs

@@ -116,12 +116,16 @@ impl Client {
         // TODO: do we need bufreader/writer here? or do we use async wrappers on unblock?
         let writer = BufWriter::new(process.stdin.take().expect("Failed to open stdin"));
         let reader = BufReader::new(process.stdout.take().expect("Failed to open stdout"));
-        let errors = BufReader::new(process.stderr.take().expect("Failed to open stderr"));
+        let errors = process.stderr.take().map(BufReader::new);
 
         Self::streams(
             Box::new(BufReader::new(reader)),
             Box::new(writer),
-            Some(Box::new(BufReader::new(errors))),
+            // errors.map(|errors| Box::new(BufReader::new(errors))),
+            match errors {
+                Some(errors) => Some(Box::new(BufReader::new(errors))),
+                None => None,
+            },
             id,
             Some(process),
         )

languages.toml

@@ -22,10 +22,8 @@ indent = { tab-width = 4, unit = "    " }
 
 [language.debugger]
 name = "lldb-vscode"
-transport = "tcp"
+transport = "stdio"
 command = "lldb-vscode"
-args = []
-port-arg = "-p {}"
 
 [[language.debugger.templates]]
 name = "binary"
@@ -91,10 +89,8 @@ indent = { tab-width = 2, unit = "  " }
 
 [language.debugger]
 name = "lldb-vscode"
-transport = "tcp"
+transport = "stdio"
 command = "lldb-vscode"
-args = []
-port-arg = "-p {}"
 
 [[language.debugger.templates]]
 name = "binary"
@@ -121,10 +117,8 @@ indent = { tab-width = 2, unit = "  " }
 
 [language.debugger]
 name = "lldb-vscode"
-transport = "tcp"
+transport = "stdio"
 command = "lldb-vscode"
-args = []
-port-arg = "-p {}"
 
 [[language.debugger.templates]]
 name = "binary"