Don't add empty prompt input to history (#3259)

2 years ago · 5ca98edfb1
parent a8b123fe17
commit 5ca98edfb1
1 changed files with 6 additions and 5 deletions
--- a/helix-term/src/ui/prompt.rs
+++ b/helix-term/src/ui/prompt.rs
@ -533,16 +533,17 @@ impl Component for Prompt {
                            .map(|entry| entry.into())
                            .unwrap_or_else(|| Cow::from(""))
                    } else {
+                        if let Some(register) = self.history_register {
+                            // store in history
+                            let register = cx.editor.registers.get_mut(register);
+                            register.push(self.line.clone());
+                        }
+
                        self.line.as_str().into()
                    };

                    (self.callback_fn)(cx, &input, PromptEvent::Validate);

-                    if let Some(register) = self.history_register {
-                        // store in history
-                        let register = cx.editor.registers.get_mut(register);
-                        register.push(self.line.clone());
-                    }
                    return close_fn;
                }
            }