From 7bdead5b4b79ca81b645eb488a979d85b668f185 Mon Sep 17 00:00:00 2001 From: Dmitry Sharshakov Date: Sun, 5 Sep 2021 08:20:21 +0300 Subject: [PATCH] Drop old commands TODO: edit logpoints with a keybinding and mouse --- helix-term/src/commands.rs | 104 +------------------------------------ 1 file changed, 2 insertions(+), 102 deletions(-) diff --git a/helix-term/src/commands.rs b/helix-term/src/commands.rs index 6252939a..73bf58b0 100644 --- a/helix-term/src/commands.rs +++ b/helix-term/src/commands.rs @@ -1998,62 +1998,6 @@ mod cmd { i.map(|i| (i, breakpoints.get(i).unwrap().clone())) } - fn edit_breakpoint_impl( - cx: &mut compositor::Context, - condition: Option, - log_message: Option, - ) -> anyhow::Result<()> { - use helix_lsp::block_on; - - let (_, doc) = current!(cx.editor); - let path = match doc.path() { - Some(path) => path.to_path_buf(), - None => { - bail!("Can't edit breakpoint: document has no path") - } - }; - - if let Some((pos, mut bp)) = get_breakpoint_at_current_line(cx.editor) { - let breakpoints = cx.editor.breakpoints.entry(path.clone()).or_default(); - breakpoints.remove(pos); - - bp.condition = condition; - bp.log_message = log_message; - breakpoints.push(bp); - - if let Some(debugger) = &mut cx.editor.debugger { - // TODO: handle capabilities correctly again, by filterin breakpoints when emitting - // if breakpoint.condition.is_some() - // && !debugger - // .caps - // .as_ref() - // .unwrap() - // .supports_conditional_breakpoints - // .unwrap_or_default() - // { - // bail!( - // "Can't edit breakpoint: debugger does not support conditional breakpoints" - // ) - // } - // if breakpoint.log_message.is_some() - // && !debugger - // .caps - // .as_ref() - // .unwrap() - // .supports_log_points - // .unwrap_or_default() - // { - // bail!("Can't edit breakpoint: debugger does not support logpoints") - // } - let request = debugger.set_breakpoints(path, breakpoints.clone()); - if let Err(e) = block_on(request) { - bail!("Failed to set breakpoints: {:?}", e) - } - } - } - Ok(()) - } - fn debug_start( cx: &mut compositor::Context, args: &[&str], @@ -2087,36 +2031,6 @@ mod cmd { Ok(()) } - fn debug_breakpoint_condition( - cx: &mut compositor::Context, - args: &[&str], - _event: PromptEvent, - ) -> anyhow::Result<()> { - let condition = args.join(" "); - let condition = if condition.is_empty() { - None - } else { - Some(condition) - }; - - edit_breakpoint_impl(cx, condition, None) - } - - fn debug_set_logpoint( - cx: &mut compositor::Context, - args: &[&str], - _event: PromptEvent, - ) -> anyhow::Result<()> { - let log_message = args.join(" "); - let log_message = if log_message.is_empty() { - None - } else { - Some(log_message) - }; - - edit_breakpoint_impl(cx, None, log_message) - } - pub const TYPABLE_COMMAND_LIST: &[TypableCommand] = &[ TypableCommand { name: "quit", @@ -2361,14 +2275,14 @@ mod cmd { alias: Some("dbg"), doc: "Start a debug session from a given template with given parameters.", fun: debug_start, - completer: Some(completers::filename), + completer: None, }, TypableCommand { name: "debug-remote", alias: Some("dbg-tcp"), doc: "Connect to a debug adapter by TCP address and start a debugging session from a given template with given parameters.", fun: debug_remote, - completer: Some(completers::filename), + completer: None, }, TypableCommand { name: "debug-eval", @@ -2377,20 +2291,6 @@ mod cmd { fun: debug_eval, completer: None, }, - TypableCommand { - name: "debug-breakpoint-condition", - alias: None, - doc: "Set current breakpoint condition.", - fun: debug_breakpoint_condition, - completer: None, - }, - TypableCommand { - name: "debug-set-logpoint", - alias: None, - doc: "Make current breakpoint a log point.", - fun: debug_set_logpoint, - completer: None, - }, TypableCommand { name: "vsplit", alias: Some("vs"),