Commit Graph

2124 Commits (feature/icons)

Author SHA1 Message Date
trivernis ab350b9b9f
Fix text overlapping in tree explorer 2 years ago
trivernis 8c87021a53
Properly add icon support into tree rendering
The icon to render is passed as an additonal field
and rendered directly to the surface so that the
style can be rendered as well
2 years ago
trivernis 7ccbea2a31
Add rudimentary nerdfonts support 2 years ago
trivernis 82adbb35ab
Merge remote-tracking branch 'lazytanuki/icons' into feature/icons 2 years ago
LazyTanuki d9e342796e feat: handle icons in statusline widget, bufferline and gutter 2 years ago
LazyTanuki 18945587ff feat: add icons to pickers 2 years ago
LazyTanuki cfcf2ff4ff feat: add icons launch and runtime loading 2 years ago
LazyTanuki 55de407681 wip: documented and moved `theme::Loader::read_names` to `helix_loader::read_toml_names` 2 years ago
Daniel Sedlak e856906f76
Fix typos (#6643) 2 years ago
Dmitry Ulyanov dd6e0cce3b
Fix line number display for LSP goto pickers (#6559)
Line numbers are 0-indexed in the LSP spec but 1-indexed for display
and jumping purposes in Helix.
2 years ago
Casper Rogild Storm 9420ba7484
Let..else refactor (#6562) 2 years ago
Pascal Kuthe 1073dd6329
robustly handle invalid LSP ranges (#6512) 2 years ago
Trivernis 27e965ef2f Merge pull request 'File Explorer Patches' (#10) from feature/file-explorer into main
Reviewed-on: #10
2 years ago
trivernis bd32cb3114
Add --show-explorer cli arg 2 years ago
trivernis 432522e724
Add update of selected file in explorer when switching buffers 2 years ago
Trivernis bfb2ce8a7a Merge pull request 'feature/file-explorer' (#9) from feature/file-explorer into main
Reviewed-on: #9
2 years ago
trivernis 2f169b172f
Add `rm` command to delete the current file 2 years ago
Pascal Kuthe 9fe3adcff9
add option to enable/disable lsp snippets 2 years ago
Pascal Kuthe 7a69c40524
Hide signature help if it overlays completion menu (#5523) 2 years ago
Pascal Kuthe ab819d80f1
Correctly reload theme on :config-reload
The current implementation didn't reload the theme if no no theme was
explicitly configured (so the default theme was used). This commit
brings `refresh_theme` in line with the initialization code.
2 years ago
mWalrus e72be52996
Truncate paths in the file picker (#6410) 2 years ago
jazzfool d04288e0f3
Canonicalize paths before stripping current dir as prefix (#6290)
Co-authored-by: jazzfool <shamoslover69@gmail.com>
2 years ago
Pascal Kuthe 5b3dd6a678 implement proper lsp-workspace support
fix typo

Co-authored-by: LeoniePhiline <22329650+LeoniePhiline@users.noreply.github.com>
2 years ago
Pascal Kuthe 2d10a429eb add workspace config and manual LSP root management
fixup documentation

Co-authored-by: LeoniePhiline <22329650+LeoniePhiline@users.noreply.github.com>

fixup typo

Co-authored-by: LeoniePhiline <22329650+LeoniePhiline@users.noreply.github.com>
2 years ago
Filip Dutescu d59b80514e
feat(debug): highlight current line (#5957)
Add new theme highlight keys, for setting the colour of the breakpoint
character and the current line at which execution has been paused at.
The two new keys are `ui.highlight.frameline` and `ui.debug.breakpoint`.
Highlight according to those keys, both the line at which debugging
is paused at and the breakpoint indicator.

Add an indicator for the current line at which execution is paused
at, themed by the `ui.debug.active` theme scope. Update various themes
to showcase how the new functionality works.

Better icons are dependent on #2869, and as such will be handled in the
future, once it lands.

Closes: #5952

Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
2 years ago
Philipp Mildenberger 198ff2c3f9
Fix clippy lints (#6454) 2 years ago
Pascal Kuthe 9fac574178 do not ignore mouse scrolling when on top of virtual text 2 years ago
Pascal Kuthe 15e751b9a2 make scrolloff calculation consistent
While scrolling (with the `scroll`) command scrolloff was calculated
slightly differently than in `ensure_cursor_in_view` which could cause
the cursor to get stuck while scrolling
2 years ago
Pascal Kuthe d6c8e0c946 allow scrolling past virtual text line
Virtual text lines (either caused by softwrapped inlay hints that take
multiple or line annotations) currently block scrolling downwards.

if the visual offset passed to char_idx_at_visual_offset or
visual_offset_from_block is within a virtual text line then the char
position before the virtual text and a visual offset are returned.
We previously ignored that visual offset and as a result the cursor
would be stuck at the start of the virtual text. This commit fixes
that by simply moving the cursor to the next char (so past the virtual
text) if this visual offset is non-zero
2 years ago
Pascal Kuthe 0ab96cc257 remove incorrect assert
This assert was added during early development of #5420 and makes no
sense with the current code. We simply forgot to remove it.
2 years ago
wongjiahau cf9669f276 fix(ci): clippy error 2 years ago
wongjiahau 88ac941407 Merge branch 'master' of https://github.com/helix-editor/helix into tree_explore 2 years ago
wongjiahau f37c795c96 chore(ui/prompt): use &str instead of Cow<str>
- Resolve https://github.com/helix-editor/helix/pull/5768/files#r1140994104
2 years ago
wongjiahau a331e52971 chore(keymap): remove "<space>E"
- Personally, I never uses this shortcut
- Secondly, we are running out of keys for mappings, so I would like to
  reserve "<space>E" for other more useful mappings
2 years ago
wongjiahau f5aec54fe2 chore(commands): revert accidental typo
- Resolve https://github.com/helix-editor/helix/pull/5768/files#r1143859919
2 years ago
wongjiahau 33542e9ddb refactor: remove unnecessary dev-dependencies
- Resolve https://github.com/helix-editor/helix/pull/5768/files#r1126720143
2 years ago
wongjiahau 898c1670d1 fix(integration-test/test_goto_file_impl): failing due to untested changes 2 years ago
wongjiahau 404f950b09 fix(tests/explorer/new_folder): failing on Windows
Co-authored-by: LEI <github@lei.sh>
Reference: https://github.com/helix-editor/helix/pull/5768#discussion_r1143991188
2 years ago
Francesc Elies 05ee673197
Show diagnostic codes for LSP diagnostics (#6378)
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2 years ago
sarah 28632c6cee
Run shell commands asynchronously (#6373) 2 years ago
Skyler Hawthorne 4bdeb9927b migrate test_with_config to use AppBuilder 2 years ago
Skyler Hawthorne d3b051d28e fix test::plain
test::plain uses char indices when it should use byte indices
2 years ago
Skyler Hawthorne 58ea193054 Allow explicit newlines in test DSL
The current test DSL currently has no way to express being at the end of
a line, save for putting an explicit LF or CRLF inside the `#[|]#`. The
problem with this approach is that it can add unintended extra new lines
if used in conjunction with raw strings, which insert newlines for you.

This is a simple attempt to mitigate this problem. If there is an
explicit newline character at the end of the selection, and then it
is immediately followed by the same newline character at the right end
of the selection, this following newline is removed. This way, one can
express a cursor at the end of a line explicitly.
2 years ago
Skyler Hawthorne a264faa98d refactor test editor config 2 years ago
Skyler Hawthorne 1db252913b print doc state during tests 2 years ago
Skyler Hawthorne 5b07ce76fc make TestCase::From more generic 2 years ago
Skyler Hawthorne 8c5ec95ac0 factor write command tests to own module 2 years ago
exp80 770496511c
Fix highlighting in picker with multiple columns (#6333) 2 years ago
wongjiahau ee34720a31 style(explorer): move title to statusline
- so that the UI is more consistent with other component of the editor
- also it may improve the focus indication
2 years ago
wongjiahau 1be2ac286b fix(ui/explorer): tree search cursor not rendered 2 years ago