156 Commits (63a879d156f75d58e4912805a6c838d545b39502)

Author	SHA1	Message	Date
trivernis	beeca2d823	Merge branch 'master' of github.com:helix-editor/helix	2 years ago
Filipe Azevedo	385ccdfc9c	add :lsp-restart command (#3435)	2 years ago
Blaž Hrastnik	1df32c917c	diagnostics: Use Vec<Tag> instead of Option<Vec<Tag>>	2 years ago
Luke Cycon	64b0745413	Track source and tags in diagnostics (#3898)	2 years ago
trivernis	59c0c41a74	Merge branch 'lsp-execute-command'	2 years ago
trivernis	3cec10e1b1	Fix missing error variant	2 years ago
trivernis	2da81760f5	Merge branch 'master' of github.com:helix-editor/helix	2 years ago
trivernis	388181bab7	Merge branch 'master' of github.com:helix-editor/helix	2 years ago
Blaž Hrastnik	a123fb6057	Remove LspNotDefined, instead return an Option<>	2 years ago
Blaž Hrastnik	1caba2d3e8	lsp: Don't log "LSP not defined" errors in the logfile	2 years ago
trivernis	151ac52741	Merge branch 'master' of github.com:helix-editor/helix	2 years ago
Michael Davis	672ea98b05	Advertise WorkspaceSymbolClientCapabilities support (#3361)	2 years ago
PiergiorgioZagaria	219d2c2515	Change default formatter for any language (#2942) ... * Change default formatter for any language * Fix clippy error * Close stdin for Stdio formatters * Better indentation and pattern matching * Return Result<Option<...>> for fn format instead of Option * Remove unwrap for stdin * Handle FormatterErrors instead of Result<Option<...>> * Use Transaction instead of LspFormatting * Use Transaction directly in Document::format * Perform stdin type formatting asynchronously * Rename formatter.type values to kebab-case * Debug format for displaying io::ErrorKind (msrv fix) * Solve conflict? * Use only stdio type formatters * Remove FormatterType enum * Remove old comment * Check if the formatter exited correctly * Add formatter configuration to the book * Avoid allocations when writing to stdin and formatting errors * Remove unused import Co-authored-by: Gokul Soumya <gokulps15@gmail.com>	2 years ago
MDeiml	90d40b70e8	Add workspace command picker	2 years ago
Erasin	42115d02bc	Suport diagnostic code (#3096) ... * add code for diagnostic. This PR provides a solution to resolve #2994. missing Code Actions for lsp * remote unused import	2 years ago
trivernis	c3c50517ee	Merge branch 'lsp-restart' ... Signed-off-by: trivernis <trivernis@protonmail.com>	2 years ago
Gokul Soumya	791bf7e50a	Add lsp signature help (#1755) ... * Add lsp signature help * Do not move signature help popup on multiple triggers * Highlight current parameter in signature help * Auto close signature help * Position signature help above to not block completion * Update signature help on backspace/insert mode delete * Add lsp.auto-signature-help config option * Add serde default annotation for LspConfig * Show LSP inactive message only if signature help is invoked manually * Do not assume valid signature help response from LSP Malformed LSP responses are common, and these should not crash the editor. * Check signature help capability before sending request * Reuse Open enum for PositionBias in popup * Close signature popup and exit insert mode on escape * Add config to control signature help docs display * Use new Margin api in signature help * Invoke signature help on changing to insert mode	2 years ago
Gokul Soumya	21b66ba068	lsp: Add workspace/applyEdit to client capabilites (#3012) ... The functionality already existed, but the capability wasn't being reported correctly to the server: 230ba264bf/helix-term/src/application.rs (L716-L728)	2 years ago
lazytanuki	096abdd19b	feat: highlight / select symbol under cursor using LSP textDocument/documentHighlight (#2738) ... * feat: highlight symbol under cursor using LSP textDocument/documentHighlight * fix: please clippy * fix: shorter description and code style	2 years ago
Blaž Hrastnik	425de09d21	Fix tests again	2 years ago
Blaž Hrastnik	24f03097e3	Remove some more unwraps	2 years ago
Michael Davis	45ce1ebdb6	embed jsonrpc types from jsonrpc-core crate (#2801) ... We should not depend on jsonrpc-core anymore: * The project just announced it's no longer actively maintained[^1], preferring their new implementation in `jsonrpsee`. * The types are too strict: we would benefit from removing some `#[serde(deny_unknown_fields)]` annotations to allow language servers that disrespect the spec[^2]. * We don't use much of the project. Just the types out of core. These are easy to embed directly into the `helix-lsp` crate. [^1]: https://github.com/paritytech/jsonrpc/pull/674 [^2]: https://github.com/helix-editor/helix/issues/2786	2 years ago
farwyler	f92a25a856	Passing extra formatting options to LSPs (#2635) ... * allows passing extra formatting options to LSPs - adds optional field 'format' to [[language]] sections in 'languages.toml' - passes specified options the LSPs via FormattingOptions * cleaner conversion of formatting properties * move formatting options inside lsp::Client * cleans up formatting properties merge	2 years ago
Blaž Hrastnik	3d91c99c3e	fix: lsp: Sort edits by start range, Omnisharp sends them in reverse	2 years ago
Michael Davis	50dd11985c	prevent panic when handling an LSP response with no request (#2475) ... A language server may push a response which doesn't belong to any request. With this change, we discard the response rather than crashing. In the case of #2474, the language server sends an error message with a null request ID which should not ever exist in the `pending_requests` HashMap. closes #2474	3 years ago
Blaž Hrastnik	7ae6cad52e	Don't panic on LSP parsing errors ... This made sense initially when the implementation was still new (so we got user reports more frequently), but a parsing error now generally signifies a language server isn't properly implementing the spec.	3 years ago
EmmChriss	807cdc60bf	configurable lsp request timeout (#2405)	3 years ago
chunghha	3a398eec56	fix typos (#2304)	3 years ago
matt rice	db47761154	register publish_diagnostics client capability (#2241)	3 years ago
ttys3	19d042dde6	chore(lsp): check rename capabilities before send rename action (#2203)	3 years ago
Michael Davis	449d1dfdfb	prevent panic when receiving malformed LSP PublishDiagnostic (#2160) ... Instead of panicing we can discard the malformed diagnostic. This `.parse()` fails commonly when a non-conformant language server gives a diagnostic with a location that breaks the spec: { "character": 0, "line": -1 } can currently be returned by ElixirLS and the python LS. Other messages in this block are discarded but this one feels special enough to log.	3 years ago
Carter Green	46ff498766	Add command to restart LSP server ... Useful if LSP configuration changes or crashes	3 years ago
Robin Jadoul	33b7483db5	Send active diagnostics to LSP when requesting code actions. (#2005) ... * Send active diagnostics to LSP when requesting code actions. This allows for e.g. clangd to properly send the quickfix code actions corresponding to those diagnostics as options. The LSP spec v3.16.0 introduced an opaque `data` member that would allow the server to persist arbitrary data between the diagnostic and the code actions request, but this is not supported yet by this commit. * Reuse existing range_to_lsp_range functionality	3 years ago
Andrey Tkachenko	dc8fef5dd3	Fixes #1991 LSP Auto-import (#2088)	3 years ago
Blaž Hrastnik	8adf0c1b3a	lsp: Implement support for workspace_folders (currently just one) ... Refs #1898	3 years ago
Blaž Hrastnik	84e799f0e4	fix: Some LSPs still want rootPath, so provide it ... Refs #1898	3 years ago
Triton171	f044059a2a	Implement LSP `workspace/configuration` and `workspace/didChangeConfiguration` (#1684) ... * Implement LSP `workspace/configuration` request * Implement LSP `workspace/didChangeConfiguration` notification. * Simplify retrieval of LSP configuration * Implement suggestions from PR discussion Co-authored-by: Triton171 <triton0171@gmail.com>	3 years ago
Blaž Hrastnik	9712bbb23b	Use which to resolve lsp/dap binaries ... This resolves the following issue: https://github.com/helix-editor/helix/discussions/962#discussioncomment-1580046	3 years ago
Blaž Hrastnik	f88c077f99	Replace tendril with smartstring ... Slightly smaller API surface, less dependencies.	3 years ago
Kirawi	ea095ca5fb	Optimize lsp_pos_to_pos (#1423) ... lines().count() is slow compared to len_lines()	3 years ago
Alexis Mousset	8a019b423f	Detect workspace root using language markers (#1370) ... * Detect workspace root using language markers * Avoid allocating root_markers * Update helix-core/src/lib.rs Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> * Update helix-core/src/lib.rs Co-authored-by: Kirawi <67773714+kirawi@users.noreply.github.com> Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Kirawi <67773714+kirawi@users.noreply.github.com>	3 years ago
Gabriel Berto	5d7b5db8ab	Resolve completion item (#1315) ... Co-authored-by: Gabriel Berto <gabriel.berto@pottencial.com.br>	3 years ago
Matouš Dzivjak	75a8b789d2	LSP code action commands (#1304) ... * feat(lsp): codeAction commands * Don't block on command call * Fix lifetime of command execution * Fix lint issues	3 years ago
Blaž Hrastnik	d31bef7fea	lsp: Don't panic if init fails ... We correctly filter out the language server inside Document to ignore it if the capabilities are missing, so this way it'll simply ignore the errored out LSP rather than panicking.	3 years ago
CossonLeo	29e6849413	Add LSP rename_symbol (space-r) (#1011) ... improve apply_workspace_edit	3 years ago
Ivan Tham	49f6c2623f	Bump lsp-types to 0.91.0 (#932)	3 years ago
Midnight Exigent	eedcea7e6b	Allow `language.config` (in languages.toml) to be passed in as a toml object (#807) ... * allow language.config (in languages.toml) to be passed in as a toml object * Change config field for languages from json string to toml object * remove indents on languages.toml config * fix: remove patch version from serde_json import in helix-core * Use same tree-sitter-zig as upstream/master	3 years ago
Kirawi	ef532e0c0d	log errors produced when trying to initialize the LSP (#746)	3 years ago
Blaž Hrastnik	bb47a9a0b8	fix: Fix regression where formatting would fail on null response	3 years ago
Blaž Hrastnik	be81f40df8	lsp: This doesn't need to be a mutable reference	3 years ago