helix-plus

Commit Graph

Author	SHA1	Message	Date
trivernis	3893898ffc	Merge branch 'master'	2 years ago
Michael Davis	3814987298	Fix panic on paste from blackhole register (#4497 ) The sequence "_y"_p panics because the blackhole register contains an empty values vec. This causes a panic when pasting since it unwraps a `slice::last`.	2 years ago
Michael Davis	d6323b7cbc	Select text inserted by shell or paste (#4458 ) This follows changes in Kakoune to the same effects: * p/<space>p: `266d1c37d0` * !/<A-!>: `85b78dda2e` Selecting the new data inserted by shell or pasting is often more useful than retaining a selection of the pre-paste/insert content.	2 years ago
Blaž Hrastnik	c2c1280f02	Resolve a bunch of upcoming clippy lints	2 years ago
Michael Davis	ba394dca6d	Fix panic from two windows editing the same document (#4570 ) * Clamp highlighting range to be within document This fixes a panic possible when two vsplits of the same document exist and enough lines are deleted from the document so that one of the windows focuses past the end of the document. * Ensure cursor is in view on window change If two windows are editing the same document, one may delete enough of the document so that the other window is pointing at a blank page (past the document end). In this change we ensure that the cursor is within view whenever we switch to a new window (for example with `<C-w>w`). * Update helix-term/src/ui/editor.rs Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>	2 years ago
Jonathan LEI	db3383c76e	Exit select mode on replace commands (#4554 )	2 years ago
Yuriy Gabuev	c803ef8753	Fix `delete_char_backward` for paired characters (#4558 ) When backward-deleting a character, if this character and the following character form a Pair, we want to delete both. However, there is a bug that deletes both characters also if both characters are closers of some Pair. This commit fixes that by adding an additional check that the deleted character should be an opener in a Pair. Closes https://github.com/helix-editor/helix/issues/4544.	2 years ago
Armin Ronacher	8584b38cfb	Correctly handle escaping in completion (#4316 ) * Correctly handle escaping in completion * Added escaping tests	2 years ago
Matthew Toohey	00cf12f571	fix: make `scroll` aware of tabs and wide characters (#4519 )	2 years ago
Matthias Deiml	5e256e4a98	Make shell_impl concurrent (#3180 )	2 years ago
Poliorcetics	c58e1729ce	fix: Never create automatic doc popups outside of Insert mode (#4456 )	2 years ago
Michael Davis	cefdface3b	Include colons for typable commands in command palette (#4495 ) Before: Goto next buffer. [buffer-next] After: Goto next buffer. [:buffer-next]	2 years ago
Dario Oddenino	6752c7d347	Trim quotes and braces from paths in goto_file_impl (#4370 ) Co-authored-by: Michael Davis <mcarsondavis@gmail.com>	2 years ago
SoraTenshi	bb48889200	Resolve conflicts	2 years ago
SoraTenshi	c14320f26e	Merge branch 'master' into colored-indent-guides	2 years ago
lazytanuki	b4a3dd8f89	feat(lsp): LSP preselected items appear first in completion menu (#4480 ) * feat(lsp): LSP preselected items appear first in completion menu * fix: shorter diff	2 years ago
James O. D. Hunt	ac0fe29867	commands: Make no arg ':theme' show name (#3740 ) Most commands that accept an argument show their current value if no argument is specified. The `:theme` command previously displayed an error message in the status bar if not provided with an argument: ``` Theme name not provided ``` It now shows the current theme name in the status bar if no argument is specified. Signed-off-by: James O. D. Hunt <jamesodhunt@gmail.com> Signed-off-by: James O. D. Hunt <jamesodhunt@gmail.com>	2 years ago
Gaurav Tyagi	ba9e50e93b	Add `:update` that will write the changes if the file has been modified. (#4426 ) * add command update that will write the changes if file hasn been modified * add docs * update the docs	2 years ago
Michał Zabielski	65edf9c198	fix: repeating repeat operator (#4450 )	2 years ago
GabrielDertoni	9fae4b8118	fix: terminal freezing on `shell_insert_output` This bug occurs on `shell_insert_output` and `shell_append_output` commands. The previous implementation would create a child process using the Rust stdlib's `Command` builder. However, when nothing should be piped in from the editor, the default value for `stdin` would be used. According to the Rust stdlib documentation that is `Stdio::inherit` which will make the child process inherit the parent process' stdin. This would cause the terminal to freeze. This change will set the child process' stdin to `Stdio::null` whenever it doesn't pipe it. In the `if` statement where this change was made there was an extra condition for windows that I am not sure if would require some special treatment.	2 years ago
Michael Davis	c47ca33137	Render diagnostics in the file picker preview (#4324 ) This is mostly for the sake of the diagnostics pickers: without rendering the diagnostic styles, it's hard to tell where the entries in the picker are pointing to.	2 years ago
SoraTenshi	52db599f2b	Add style for rainbow ig, dimming, normal and none	2 years ago
trivernis	46b135bdc5	Merge branch 'master'	2 years ago
Michael Davis	d7d0d5ffb7	lsp: Resolve completion items missing documentation on idle (#4406 ) Some language servers may not send the `documentation` field if it is expensive to compute. Clients can request the missing field with a completionItem/resolve request. In this change we use the idle-timeout event to ensure that the current completion item is resolved.	2 years ago
Alexis (Poliorcetics) Bourget	34389e1d54	nit: Do less allocations in `ui::menu::Item::label` implementations This complicates the code a little but it often divides by two the number of allocations done by the functions. LSP labels especially can easily be called dozens of time in a single menu popup, when listing references for example.	2 years ago
Alexis (Poliorcetics) Bourget	3aea33a415	nit: move an allocation to happen after a `continue`, making sure it's not done for nothing	2 years ago
Skyler Hawthorne	5a848344a9	fix: write-all crash (#4384 ) When we do auto formatting, the code that takes the LSP's response and applies the changes to the document are just getting the currently focused view and giving that to the function, basically always assuming that the document that we're applying the change to is in focus, and not in a background view. This is usually fine for a single view, even if it's a buffer in the background, because it's still the same view and the selection will get updated accordingly for when you switch back to it. But it's obviously a problem for when there are multiple views, because if you don't have the target document in focus, it will ask the document to update the wrong view, hence the crash. The problem with this is picking which view to apply any selection change to. In the absence of any more data points on the views themselves, we simply pick the first view associated with the document we are saving.	2 years ago
Nimrod	bad49ef2d0	Fix unexpected behavior in delete_word_backward and delete_word_forward (#4392 )	2 years ago
Skyler Hawthorne	f486f34ebe	flush writes on force quit (#4397 ) When force quitting, we need to block on the pending writes to ensure that write commands succeed before exiting, and also to avoid a crash when all the views are gone before the auto format call returns from the LS.	2 years ago
Charlie Groves	7e29ee6dae	Autosave all when the terminal loses focus (#3178 ) * Autosave all when the terminal loses focus * Correct comment on focus config Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> * Need a block_try_flush_writes in all quit_all paths Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>	2 years ago
Pascal Kuthe	9af7c1c9f3	Sort by fixed diagnostics/is_preffered within codeaction categories	2 years ago
Pascal Kuthe	189aa0bfcf	never sort menu items when no fuzzy matching is possible	2 years ago
Pascal Kuthe	dc3527f52d	use permalink to vscode repo	2 years ago
Pascal Kuthe	8d8b5d6624	use stable sort instead of allocating new vectors	2 years ago
Pascal Kuthe	c70d762a7b	sort autocompletins by fuzzy match	2 years ago
Pascal Kuthe	8673c1ec0c	sort codeaction by their kind instead of alphabetically	2 years ago
Matouš Dzivjak	4cff625054	chore(view): remove indent_unit helper fn (#4389 )	2 years ago
Matouš Dzivjak	eee8362015	fix(commands): no last picker error (#4387 )	2 years ago
Blaž Hrastnik	78c0cdc519	Merge pull request #2267 from dead10ck/fix-write-fail Write path fixes	2 years ago
Fisher Darling	4174b25b3d	Pretty print `tree-sitter-subtree` expression (#4295 )	2 years ago
Skyler Hawthorne	756253b43f	fix tree_sitter_scopes	2 years ago
Skyler Hawthorne	e645804b0a	Editor::flush_writes returns an error	2 years ago
Blaž Hrastnik	52ba550098	Use flush_writes in application.close()	2 years ago
Blaž Hrastnik	55b50d9e83	Seems like this flush is unnecessary	2 years ago
Blaž Hrastnik	b0212b3611	Deduplicate flush_writes	2 years ago
Blaž Hrastnik	30c93994b5	Use a single save_queue on the editor	2 years ago
Skyler Hawthorne	beb3427bfb	improve app close failure display	2 years ago
Skyler Hawthorne	31d1bbfddb	review comments	2 years ago
Skyler Hawthorne	3f07885b35	document should save even if formatter fails	2 years ago
Skyler Hawthorne	b530a86d1f	remove Callback::Compositor variant To reduce likelihood of accidental discarding of important callbacks	2 years ago
Skyler Hawthorne	b3fc31a211	move language server refresh to document saved event handler	2 years ago
Skyler Hawthorne	af03df3413	fix write scratch buffer to file	2 years ago
Skyler Hawthorne	18c32118b1	Save text in document saved events, use in status message	2 years ago
Skyler Hawthorne	f82a551b98	Rename doc save event names to past tense	2 years ago
Skyler Hawthorne	57de4e6251	various fixes in write-all path	2 years ago
Skyler Hawthorne	d544376590	reset idle timer for all events	2 years ago
Skyler Hawthorne	e5fd5e2a9c	fix panic when view of pending write is closed	2 years ago
Skyler Hawthorne	8c667ef8de	factor editor event handling into function	2 years ago
Skyler Hawthorne	aaa1450678	fix write-quit with auto format write-quit will now save all files successfully even when there is auto formatting	2 years ago
Skyler Hawthorne	c9418582d2	fix modified status with auto format	2 years ago
Skyler Hawthorne	cb23399dee	improve reliability of shutdown	2 years ago
Skyler Hawthorne	b8a07f7d15	add conditional noop render back It makes it much slower without stubbing this out	2 years ago
Skyler Hawthorne	69c9e44ef2	update write-quit to wait for saves	2 years ago
Skyler Hawthorne	e1f7bdb1d2	fix buffer-close	2 years ago
Skyler Hawthorne	83b6042b97	fix(write): do not set new path on document until write succeeds If a document is written with a new path, currently, in the event that the write fails, the document still gets its path changed. This fixes it so that the path is not updated unless the write succeeds.	2 years ago
Skyler Hawthorne	a5a93182cd	fix: buffer-close ensuring writes Make sure buffer-close waits for the document to finish its writes.	2 years ago
Skyler Hawthorne	d706194597	chore(write): serialize write operations within a Document The way that document writes are handled are by submitting them to the async job pool, which are all executed opportunistically out of order. It was discovered that this can lead to write inconsistencies when there are multiple writes to the same file in quick succession. This seeks to fix this problem by removing document writes from the general pool of jobs and into its own specialized event. Now when a user submits a write with one of the write commands, a request is simply queued up in a new mpsc channel that each Document makes to handle its own writes. This way, if multiple writes are submitted on the same document, they are executed in order, while still allowing concurrent writes for different documents.	2 years ago
Jonathan LEI	1a772d1b67	Fix deleting word from end of buffer (#4328 )	2 years ago
Roberto Vidal	1f74cf45d4	display tree sitter scopes in a popup (#4337 )	2 years ago
Philipp Mildenberger	d17ffc47f0	Use the same `WalkBuilder` configuration for the global search file picker as the default file picker (#4334 ) Skip searching .git in global search, similar to how file picker skips listing files in .git.	2 years ago
A-Walrus	8bbddf90ff	Replace `in_bounds` with calculation of end_indent Instead of repeatedly checking if it is in_bounds, calculate the max_indent beforehand and just loop. I added a debug_assert to "prove" that it never tries drawing out of bounds.	2 years ago
A-Walrus	1de02a147c	Only draw indent guides within bounds Better performance, and otherwise very long lines with lots of tabs will wrap around the u16 and come back on the other side, messing up the beginning skip_levels.	2 years ago
A-Walrus	2c36e33e0a	Make skip_levels a u8	2 years ago
A-Walrus	3ba665d804	Fix rendering of lines longer than 2^16 Before things would be cast to u16 earlier than needed, which would cause problems for insanely long lines (longer than 2^16 ~ 65 thousand)	2 years ago
Gokul Soumya	4e691d6247	Change diagnostic picker keybind to <space>d (#4229 ) Also changes workspace diagnostic picker bindings to <space>D and changes the debug menu keybind to <space>g, the previous diagnostic picker keybind. This brings the diagnostic picker bindings more in line with the jump to next/previous diagnostic bindings which are currently on ]d and [d.	2 years ago
Michael Davis	5f4f171b73	Fix debug assertion for diagnostic sort order (#4319 ) The debug assertion that document diagnostics are sorted incorrectly panics for cases like `[161..164, 162..162]`. The merging behavior in the following lines that relies on the assertion only needs the input ranges to be sorted by `range.start`, so this change simplifies the assertion to only catch violations of that assumption.	2 years ago
ZJPzjp	0e8e7cae3b	fix `:insert-output` doc: inserting output before each selection (#4286 )	2 years ago
Poliorcetics	45e038f4d5	nit: remove a String allocation that is immediately used as an &str (#4277 )	2 years ago
Nathaniel Graham	e80beaa7b0	Changed Selection Yank Message (#4275 ) Co-authored-by: Nathaniel Graham <ngraham@protonmail.com>	2 years ago
Michael Davis	e16c632760	Apply transactions to the jumplist for undo/redo (#4227 ) Undo/redo/earlier/later call `Document::apply_impl` which applies transactions to the document. These transactions also need to be applied to the view as in `0aedef0`.	2 years ago
Armin Ronacher	7f75458e6f	Fix some commands not showing names in palette (#4223 )	2 years ago
trivernis	37bb8a80d1	Add completion trigger chars	2 years ago
Graic	68909dcef4	Fix append cursor location when selection anchor is at end of document (#4147 )	2 years ago
trivernis	1ad06ee586	Merge branch 'master'	2 years ago
trivernis	8b789b6b86	Merge branch 'seperate_code_action'	2 years ago
Pascal Kuthe	f813ccc1fc	use permalink to vscode repo	2 years ago
Pascal Kuthe	a36bb1d27c	use stable sort instead of allocating new vectors	2 years ago
Brian Orwe	f4d96b2ca3	Fix confusion with using --hsplit --vsplit on startup at same time (#4202 )	2 years ago
Alexis (Poliorcetics) Bourget	b58899bc8e	fix: remove unneeded allocations when calling helix_view::Info::new	2 years ago
Michael Davis	65febe0cf4	Overlay all diagnostics with highest severity on top (#4113 ) Here we separate the diagnostics by severity and then overlay the Vec of spans for each severity on top of the highlights. The error diagnostics end up overlaid on the warning diagnostics, which are overlaid on the hints, overlaid on info, overlaid on any other severity (default), then overlaid on the syntax highlights. This fixes two things: * Error diagnostics are now always visible when overlapped with other diagnostics. * Ghost text is eliminated. * Ghost text was caused by duplicate diagnostics at the EOF: overlaps within the merged `Vec<(usize, Range<usize>)>` violate assumptions in `helix_core::syntax::Merge`. * When we push a new range, we check it against the last range and merge the two if they overlap. This is safe because they both have the same severity and therefore highlight. The actual merge is skipped for any of these when they are empty, so this is very fast in practice. For some data, I threw together an FPS counter which renders as fast as possible and logs the renders per second. With no diagnostics, I see an FPS gain from this change from 868 FPS to 878 (+1.1%) on a release build on a Rust file. On an Erlang file with 12 error diagnostics and 6 warnings in view (233 errors and 66 warnings total), I see a decrease in average FPS from 795 to 790 (-0.6%) on a release build.	2 years ago
Pascal Kuthe	1a87cbd508	remove filterting with C-space from picker	2 years ago
Pascal Kuthe	7af599e0af	Treat space as a seperator instead of a character in fuzzy picker	2 years ago
Michael Davis	c388e16e09	Add a helper function for applying transactions It is easy to forget to call `Document::apply` and/or `View::apply` in the correct order. This commit introduces a helper function which closes over both calls.	2 years ago
Michael Davis	0aedef0333	Apply transactions to Views This change adds View::apply calls for all Document::apply call-sites, ensuring that changes to a document do not leave invalid entries in the View's jumplist.	2 years ago
Blaž Hrastnik	a85e386298	picker: Highlight the document on idle timeout	2 years ago
Gokul Soumya	001858b11f	Propagate idle timeout event to components (#3172 )	2 years ago
A-Walrus	c15f1ea274	Add cursorcolumn (#4084 ) * Implement cursorcolumn * Add documentation * Separate column style from line with fallback * Fallback to cursorcolumn first * Switch to non-fallback try_get_exact Add new function `try_get_exact`, which doesn't perform fallback, and use that instead because the fallback behaviour is being handled manually.	2 years ago
s0LA1337	dbd0932921	Merge branch 'master' into colored-indent-guides	2 years ago
Pascal Kuthe	63a54ee19b	sort autocompletins by fuzzy match	2 years ago
Pascal Kuthe	6b16b9dfc8	sort codeaction by their kind instead of alphabetically	2 years ago
s0LA1337	b02d6d98ce	Add get_rainbow method, added a todo for rainbow	2 years ago
trivernis	18b0d42fa6	Change tree viewer to not allow one to change dirs	2 years ago
trivernis	31447a7340	Change keybind <space>-E to close the explorer instead of toggling recursion	2 years ago
trivernis	d18a064fad	Merge branch 'colored-indent-guides'	2 years ago
A-Walrus	c927d61791	Fix bugs in search wraparound message (#4101 )	2 years ago
Skyler Hawthorne	27b70696df	Exit gracefully when close operation fails (#4081 ) If the close method fails, the editor will quit before restoring the terminal. This causes the shell to break if, e.g. the LS times out shutting down. This fixes this by always restoring the terminal after closing, and printing out a message to stderr if there is an error.	2 years ago
Michael Davis	6cca7375ec	Automatically track pseudo-pending text (#4077 ) This change automatically tracks pending text for for commands which use on-next-key callbacks. For example, `t` will await the next key event and "t" will be shown in the bottom right-hand corner to show that we're in a pending state. Previously, the text for these on-next-key commands needed to be hard-coded into the command definition which had some drawbacks: * It was easy to forget to write and clear the pending text. * If a command was remapped in a custom config, the pending text would still show the old key. With this change, pending text is automatically tracked based on the key events that lead to the command being executed. This works even when the command is remapped in config and when the on-next-key callback is nested under some key sequence (for example `mi`).	2 years ago
Karsten Gebbert	9124c231f4	respond to SIGUSR1 by reloading config (#3952 ) * respond to SIGUSR1 by reloading config * document USR1 signal handling	2 years ago
Ivan Tham	3d59d3f8be	Keep arrow and special keys in insert (#3915 ) * Keep arrow and special keys in insert Advanced users won't need it and is useful for beginners. Revert part of #3671. * Change text for insert mode section Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> * Remove ctrl-up/down in insert * Reorganize insert keys and docs * Improve page up experience on last tutor The last tutor page can page down multiple times and it will break the heading on the 80x24 screen paging when reaching the last page, this keeps the style the same and make sure page up and down won't break it. Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>	2 years ago
A-Walrus	1d8bb2249b	Change focus to modified docs on quit (#3872 ) * Change focus to modified docs on quit When quitting with modified documents, automatically switch focus to one of them. * Update helix-term/src/commands/typed.rs Co-authored-by: Poliorcetics <poliorcetics@users.noreply.github.com> * Make it work with buffer-close-all and the like * Cleanup Use Cow instead of String, and rename DoesntExist -> DoesNotExist Co-authored-by: Poliorcetics <poliorcetics@users.noreply.github.com>	2 years ago
Robin	6764744ce9	Add option to skip the first indent guide (#3819 ) * Add option to skip the first indent guide * reorder skip_first option * change indent-guides.skip_first to a number * rename skip -> skip_levels * add skip_levels to the book * Update book/src/configuration.md Co-authored-by: A-Walrus <58790821+A-Walrus@users.noreply.github.com> * Update helix-term/src/ui/editor.rs Co-authored-by: Michael Davis <mcarsondavis@gmail.com> Co-authored-by: Robin <robinvandijk@klippa.com> Co-authored-by: A-Walrus <58790821+A-Walrus@users.noreply.github.com> Co-authored-by: Michael Davis <mcarsondavis@gmail.com>	2 years ago
Michael Davis	dbec057363	Rename I/A "Insert at start/end of line" (#3753 ) * keymap: Rename A "Insert at end of line" The language for the `A` binding is potentially confusing because `A` behaves like `i` done at the end of the line rather than `a`. This change renames the command to match Kakoune's language[^1]. [^1]: `021da117cf/src/normal.cc (L2229)` * keymap: Rename I `insert_at_line_start`	2 years ago
ath3	7c9809eeb2	Find workspace from document path (#3553 )	2 years ago
Ivan Tham	66bbba9024	Select inserted space after join (#3549 ) * Select inserted space after join * Split join_selections with space selection to A-J Kakoune does that too and some users may still want to retain their selections. * Update join_selections docs	2 years ago
nuid32	576c34f84e	Add command names to command palette (#4071 )	2 years ago
Ivan Tham	93f26a3048	Fix signature help panic when too large (#4030 ) When signature help is too large it may cause a panic when it is too large, now I just make the hover do an intersection with surface to make sure it never overflow.	2 years ago
greg-enbala	63ff9309ce	goto_window_* extends selection (#3985 ) * goto_window_* extends selection * Don't push to the jumplist	2 years ago
Joshua Pauline	c144cc0b04	feat(statusline): add option to show total line numbers in file (#3960 ) * feat(statusline): add option to show total line numbers in file * feat(line numbers): add config to doc book	2 years ago
PeepNSheep	77f33e7b20	Add configureable statusline mode names (#3311 ) * Added 'long-mode' statusline element * Added customizable statusline mode names * Removed a string clone * Added documentation * Updated documentation, moved modenames to a seperate section * Update configuration.md * Documentation update * Documentation update * Documentation update * Update configuration.md * Update configuration.md * Fixed merge error * Update configuration.md * Update configuration.md	2 years ago
ChrHorn	589d17c758	Add `ui.gutter.selected` option for themes (#3303 ) * add `ui.gutter.selected` * add `ui.gutter`, `ui.gutter.selected` to docs	2 years ago
Michael Davis	c253139790	Extend textobject selections in select mode	2 years ago
Michael Davis	032d76ccf2	Use Range::with_direction consistently	2 years ago
Michael Davis	274f2ea459	Use requested direction for new textobject selection range This changes the behavior of operations like `]f`/`[f` to set the direction of the new range to the direction of the action. The original behavior was to always use the head of the next function. This is inconsistent with the behavior of goto_next_paragraph and makes it impossible to create extend variants of the textobject motions. This causes a behavior change when there are nested functions. The behavior in the parent commit is that repeated uses of `]f` will select every function in the file even if nested. With this commit, functions are skipped. It's notable that it's possible to emulate the original behavior by using the `ensure_selections_forward` (A-:) command between invocations of `]f`.	2 years ago
A-Walrus	f3958aa1fd	Cycled to end/beginning + no more matches msgs (#3176 ) * Show status msg when next/prev cycles around * Add msg when there is no wraparound * Cleanup code * Change msg to "Wrapped around document"	2 years ago
A-Walrus	57dc5fbe3a	Show "Invalid regex" message on enter (Validate) (#3049 ) * Show "Invalid regex" message on enter (Validate) * Reset selection on invalid regex * Add popup for invalid regex * Replace set_position with position * Make popup auto close	2 years ago
Joe	bcba5d67f9	Add goto preview (#2982 )	2 years ago
s0LA1337	16312e3b15	Create new style variable that patches on rainbow enabled	2 years ago
Matt Freitas-Stavola	9d1793c45b	Add pseudo_pending for t/T/f/F (#4062 )	2 years ago
s0LA1337	210a7e1c12	patch full style instead of just the foreground	2 years ago
s0LA1337	5989ba88e7	Adjust to use rainbow style array in themes	2 years ago
trivernis	817c2a7e6d	Add blocking on file deletion Signed-off-by: trivernis <trivernis@protonmail.com>	2 years ago
trivernis	092163bd8f	Add command to delete the file of the current buffer	2 years ago
zensayyy	c9584251f3	Ensure cursor in view after format (#4047 ) Co-authored-by: Michael Davis <mcarsondavis@gmail.com>	2 years ago
trivernis	0725aa1046	Add flag to open the file explorer on startup Signed-off-by: trivernis <trivernis@protonmail.com>	2 years ago
s0LA1337	9bbc12d7b6	Remove unnecessary typing	2 years ago
s0LA1337	a27c384dd2	Initial implementation of colored indentation guides	2 years ago
trivernis	a864b63b0f	Add space to open files in the explorer as an alternative to enter	2 years ago
trivernis	423435d12a	Add auto-select of tree explorer nodes when jumping between buffers	2 years ago
trivernis	c7492aea1f	Merge branch 'completion'	2 years ago
trivernis	1e1967308d	Merge branch 'master'	2 years ago
Poliorcetics	e8f0886b21	chore: remove unneeded attribute after MSRV bump to 1.61 (#3961 )	2 years ago
Riccardo Binetti	888f4fef6f	Split helix_core::find_root and helix_loader::find_local_config_dirs (#3929 ) * Split helix_core::find_root and helix_loader::find_local_config_dirs The documentation of find_root described the following priority for detecting a project root: - Top-most folder containing a root marker in current git repository - Git repository root if no marker detected - Top-most folder containing a root marker if not git repository detected - Current working directory as fallback The commit contained in https://github.com/helix-editor/helix/pull/1249 extracted and changed the implementation of find_root in find_root_impl, actually reversing its result order (since that is the order that made sense for the local configuration merge, from innermost to outermost ancestors). Since the two uses of find_root_impl have different requirements (and it's not a matter of reversing the order of results since, e.g., the top repository dir should be used by find_root only if there's not marker in other dirs), this PR splits the two implementations in two different specialized functions. In doing so, find_root_impl is removed and the implementation is moved back in find_root, moving it closer to the documented behaviour thus making it easier to verify it's actually correct * helix-core: remove Option from find_root return type It always returns some result, so Option is not needed	2 years ago
Pascal Kuthe	4133f1f424	Document MSRV policy (#3913 )	2 years ago
A-Walrus	eb6fd283dc	Deduplicate regexes in search_selection command (#3941 )	2 years ago
Michael Davis	6e168b5099	Improve keymap errors from command typos (#3931 ) * Improve keymap errors from command typos Currently, opening helix with a config containing a bad command mapping fails with a cryptic error. For example, say we have a config (bad.toml) with a command name that doesn't exist: [keys.normal] b = "buffer_close" # should be ":buffer-close" When we `hx -c bad.toml`, we get... > Bad config: data did not match any variant of untagged enum KeyTrie for key `keys.normal` at line 1 column 1 > Press <ENTER> to continue with default config This is because of the way that Serde tries to deserialize untagged enums such as `helix_term::keymap::KeyTrie`. From the Serde docs[^1]: > Serde will try to match the data against each variant in order and the > first one that deserializes successfully is the one returned. `MappableCommand::deserialize` fails (returns an Err variant) when a command does not exist. Serde interprets this as the `KeyTrie::Leaf` variant failing to match and declares that the input data doesn't "match any variant of untagged enum KeyTrie." Luckily the variants of KeyTrie are orthogonal in structure: we can tell them apart by the type hints from a `serde:🇩🇪:Visitor`. This change uses a custom Deserialize implementation along with a Visitor that discerns which variant of the KeyTrie applies. With this change, the above failure becomes: > Bad config: No command named 'buffer_close' for key `keys.normal.b` at line 2 column 5 > Press <ENTER> to continue with default config We also provide more explicit information about the expectations on the field. A config with an unexpected type produces a message with that information and the expectation: [keys.normal] b = 1 > Bad config: invalid type: integer `1`, expected a command, list of commands, or sub-keymap for key `keys.normal.b` at line 2 column 5 > Press <ENTER> to continue with default config [^1]: https://serde.rs/enum-representations.html#untagged * Update helix-term/src/keymap.rs Co-authored-by: Ivan Tham <pickfire@riseup.net> Co-authored-by: Ivan Tham <pickfire@riseup.net>	2 years ago
trivernis	32079b7ed9	Change some default config values and default theme Signed-off-by: trivernis <trivernis@protonmail.com>	2 years ago
trivernis	4487f144bd	Swap screenshot in README Signed-off-by: trivernis <trivernis@protonmail.com>	2 years ago
trivernis	9d1d6a74ec	Merge remote-tracking branch 'tree-explorer-icons/tree_explorer_icons'	2 years ago
Roland Singer	92ebab74b5	adjusted explorer to new helix code	2 years ago
Roland Singer	eec845cc34	adjusted explorer to new helix code	2 years ago

1 2 3 4 5 ...

1863 Commits (cfe575764dfc48359ab2e21f6049d857308174cb)