Commit Graph

85 Commits (e20886dd6058a0b31fb99fb71a523b2ec3dfec64)

Author SHA1 Message Date
A-Walrus 2f9ca3840a
Add preview for scratch buffers in buffer picker (#3454) 2 years ago
Skyler Hawthorne b530a86d1f remove Callback::Compositor variant
To reduce likelihood of accidental discarding of important callbacks
2 years ago
Skyler Hawthorne aaa1450678 fix write-quit with auto format
write-quit will now save all files successfully even when there is auto
formatting
2 years ago
Frojdholm 4c9f144dac
fix: Recalculate completion when going through prompt history (#3193)
* fix: Recalculate completion when going through prompt history

* Update completion when the prompt line is changed

It should not be possible to update the line without also updating the
completion since the completion holds an index into the line.

* Fix Prompt::with_line recalculate completion

with_line was the last function where recalculate completion had to be
done manually. This function now also recalculates the completion so
that it's impossible to forget.

* Exit selection when recalculating completion

Keeping the selection index when the completion has been recalculated
doesn't make sense. This clears the selection automatically, removing
most needs to manually clear it.

* Remove &mut on save_filter

Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>
2 years ago
Danilo Spinella 110eb73045
Add cwd parameter which is not optional anymore (#3240) 2 years ago
Gokul Soumya 6e2aaed5c2
Reuse menu::Item trait in picker (#2814)
* Refactor menu::Item to accomodate external state

Will be useful for storing editor state when reused by pickers.

* Add some type aliases for readability

* Reuse menu::Item trait in picker

This opens the way for merging the menu and picker code in the
future, since a picker is essentially a menu + prompt. More
excitingly, this change will also allow aligning items in the
picker, which would be useful (for example) in the command palette
for aligning the descriptions to the left and the keybinds to
the right in two separate columns.

The item formatting of each picker has been kept as is, even though
there is room for improvement now that we can format the data into
columns, since that is better tackled in a separate PR.

* Rename menu::Item::EditorData to Data

* Call and inline filter_text() in sort_text() completion

* Rename diagnostic picker's Item::Data
2 years ago
Blaž Hrastnik 20cf75dfa1
Strip some more params 2 years ago
Blaž Hrastnik 9a6ee88e66
Split off dap event handlers into helix-view to allow reuse 2 years ago
Blaž Hrastnik 5a60989efe
Bump dependencies 2 years ago
Blaž Hrastnik 7b1d682fe5 dap: fix runInTerminal with lldb-vscode 2 years ago
Blaž Hrastnik 4e1b3b12f3 Refactor symbol picker to share code 2 years ago
Cole Helbling 6118486eb2 helix-term: implement buffer completer
In order to implement this completer, the completion function needs to
be able to access the compositor's context (to allow it to get the
list of buffers currently open in the context's editor).
2 years ago
Blaž Hrastnik d11b652139 Allow static strings in set_status/set_error so API is nicer 2 years ago
Blaž Hrastnik fd0e4b1159 dap: Reduce amount of block_on uses 2 years ago
Blaž Hrastnik 1422449537 .. 2 years ago
Blaž Hrastnik eeb9b39857 Fix build on master 2 years ago
Blaž Hrastnik bd549d8a20 Merge remote-tracking branch 'origin/master' into debug 2 years ago
Blaž Hrastnik 7ad8eaaef0 wip 2 years ago
Blaž Hrastnik df3b88387b dap: Improve variables UI 2 years ago
Blaž Hrastnik dac317e620 TODO 2 years ago
Blaž Hrastnik 60c86eff89 dap: Simplify a few more statements that could use the debugger macro 2 years ago
Blaž Hrastnik d8351d35ab dap: Extract a macro that fetches a debugger or returns 2 years ago
Blaž Hrastnik e98993d609 dap: Fix an off-by-one error when jumping 2 years ago
Blaž Hrastnik bf8437d098 clippy lint 2 years ago
Blaž Hrastnik dc8df7ba21 Make thread_picker non-blocking 2 years ago
Blaž Hrastnik d5d1a9b1ae
Apply suggestions from code review
Co-authored-by: Gokul Soumya <gokulps15@gmail.com>
2 years ago
Blaž Hrastnik 43fbb6d965 Make dap_start non-blocking 2 years ago
Blaž Hrastnik 2dbf966293 dap: Start working on runInTerminal support 2 years ago
Blaž Hrastnik d14ca05d6b Simplify some cases that use return None to use ? 2 years ago
Blaž Hrastnik de5e5863aa dap: Use cursor_line over cursor + char_to_line 2 years ago
Blaž Hrastnik 54f8e5c9c3 dap: Fix an off-by-one and move the function over to commands/dap 2 years ago
Blaž Hrastnik 573cb39926 dap: Remove some unwraps 2 years ago
Blaž Hrastnik ffc89e483b Mark some more TODOs as resolved 3 years ago
Blaž Hrastnik b4fd3148e3 These TODOs have been resolved 3 years ago
Blaž Hrastnik 8ffafb826f dap: Rewrite breakpoints so that there's a single set maintained 3 years ago
Blaž Hrastnik 3633f85b38 Pass editor into render_view & gutter, reducing the number of params 3 years ago
Blaž Hrastnik 85b4410703 dap: Toggle breakpoints without changing selection, fix offset calc 3 years ago
Blaž Hrastnik b55ca8fdb8 dap: Always edit breakpoints on the correct document 3 years ago
Blaž Hrastnik 0eadeab8c7 dap: Remove the prompt line parameter, use insert_str instead 3 years ago
Blaž Hrastnik 5f329a22c4 dap: Modify breakpoints in place with no cloning 3 years ago
Blaž Hrastnik 05d3ad4a0e dap: Remove an excess clone on enable_exceptions 3 years ago
Blaž Hrastnik c39d9f44a0 dap: Simplify debug_parameter_prompt 3 years ago
Blaž Hrastnik 3042ff3e5a dap: Clean up dap_start_impl, no need to clone arg keys 3 years ago
Blaž Hrastnik 9963a5614d dap: Minor simplifications 3 years ago
Blaž Hrastnik 65868081fc dap: Simplify launch & start
There's no need to re-detect language config, just use the one available
on the document.
3 years ago
Blaž Hrastnik 4f2a01cc09 dap: Error implements Display so we can format with {} 3 years ago
Blaž Hrastnik 2bd8a9b39d dap: Consistently rename type as ty 3 years ago
Blaž Hrastnik 9dd17c46a2 dap: Avoid cloning old_breakpoints if we are immediately replacing them 3 years ago
Blaž Hrastnik 757babb1b4 dap: Avoid cloning *entire* stack frames when picking a thread 3 years ago
Blaž Hrastnik 5803de2067 dap: Simplify more calls 3 years ago