96 Commits (e20886dd6058a0b31fb99fb71a523b2ec3dfec64)

Author	SHA1	Message	Date
trivernis	e20886dd60	Merge branch 'master'	1 year ago
Filipe Azevedo	f0f295a667	reload-all: Only update viewport when view focuses on the doc (#4901)	1 year ago
Michael Davis	fd00f3a70e	Don't apply transactions to Views in undo/redo ... View::apply should only be called by EditorView after 42e37a571e. This change removes the duplicate calls within undo/redo which could cause a panic.	2 years ago
Filipe Azevedo	8dac863a5b	Add `:reload-all` command (#4663)	2 years ago
Michael Davis	c6b83368b3	Capture word parts while calculating shellwords (#4632) ... This fixes an edge case for completing shellwords. With a file "a b.txt" in the current directory, the sequence `:open a\<tab>` will result in the prompt containing `:open aa\ b.txt`. This is because the length of the input which is trimmed when replacing with completion is calculated on the part of the input which is parsed by shellwords and then escaped (in a separate operation), which is lossy. In this case it loses the trailing backslash. The fix provided here refactors shellwords to track both the _words_ (shellwords with quotes and escapes resolved) and the _parts_ (chunks of the input which turned into each word, with separating whitespace removed). When calculating how much of the input to delete when replacing with the completion item, we now use the length of the last part. This also allows us to eliminate the duplicate work done in the `ends_with_whitespace` check.	2 years ago
Matthias Deiml	dee5b2a983	Add LSP workspace command picker (#3140) ... * Add workspace command picker * Make command typable * Add optional argument to lsp-workspace-command	2 years ago
Michael Davis	140df92d79	Fix command-mode completion behavior when input is escaped ... If `a\ b.txt` were a local file, `:o a\ <tab>` would fill the prompt with `:o aa\ b.txt` because the replacement range was calculated using the shellwords-parsed part. Escaping the part before calculating its length fixes this edge-case.	2 years ago
Michael Davis	3d283b2ca4	Escape filenames in command completion ... This changes the completion items to be rendered with shellword escaping, so a file `a b.txt` is rendered as `a\ b.txt` which matches how it should be inputted.	2 years ago
Michael Davis	1536a65289	Fix whitespace handling in command-mode completion ... 8584b38cfb switched to shellwords for completion in command-mode. This changes the conditions for choosing whether to complete the command or use the command's completer. This change processes the input as shellwords up-front and uses shellword logic about whitespace to determine whether the command or argument should be completed.	2 years ago
trivernis	3893898ffc	Merge branch 'master'	2 years ago
Armin Ronacher	8584b38cfb	Correctly handle escaping in completion (#4316) ... * Correctly handle escaping in completion * Added escaping tests	2 years ago
James O. D. Hunt	ac0fe29867	commands: Make no arg ':theme' show name (#3740) ... Most commands that accept an argument show their current value if no argument is specified. The `:theme` command previously displayed an error message in the status bar if not provided with an argument: ``` Theme name not provided ``` It now shows the current theme name in the status bar if no argument is specified. Signed-off-by: James O. D. Hunt <jamesodhunt@gmail.com> Signed-off-by: James O. D. Hunt <jamesodhunt@gmail.com>	2 years ago
Gaurav Tyagi	ba9e50e93b	Add `:update` that will write the changes if the file has been modified. (#4426) ... * add command update that will write the changes if file hasn been modified * add docs * update the docs	2 years ago
trivernis	46b135bdc5	Merge branch 'master'	2 years ago
Skyler Hawthorne	5a848344a9	fix: write-all crash (#4384) ... When we do auto formatting, the code that takes the LSP's response and applies the changes to the document are just getting the currently focused view and giving that to the function, basically always assuming that the document that we're applying the change to is in focus, and not in a background view. This is usually fine for a single view, even if it's a buffer in the background, because it's still the same view and the selection will get updated accordingly for when you switch back to it. But it's obviously a problem for when there are multiple views, because if you don't have the target document in focus, it will ask the document to update the wrong view, hence the crash. The problem with this is picking which view to apply any selection change to. In the absence of any more data points on the views themselves, we simply pick the first view associated with the document we are saving.	2 years ago
Skyler Hawthorne	f486f34ebe	flush writes on force quit (#4397) ... When force quitting, we need to block on the pending writes to ensure that write commands succeed before exiting, and also to avoid a crash when all the views are gone before the auto format call returns from the LS.	2 years ago
Charlie Groves	7e29ee6dae	Autosave all when the terminal loses focus (#3178) ... * Autosave all when the terminal loses focus * Correct comment on focus config Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> * Need a block_try_flush_writes in all quit_all paths Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>	2 years ago
Blaž Hrastnik	78c0cdc519	Merge pull request #2267 from dead10ck/fix-write-fail ... Write path fixes	2 years ago
Fisher Darling	4174b25b3d	Pretty print `tree-sitter-subtree` expression (#4295)	2 years ago
Skyler Hawthorne	756253b43f	fix tree_sitter_scopes	2 years ago
Skyler Hawthorne	e645804b0a	Editor::flush_writes returns an error	2 years ago
Blaž Hrastnik	b0212b3611	Deduplicate flush_writes	2 years ago
Blaž Hrastnik	30c93994b5	Use a single save_queue on the editor	2 years ago
Skyler Hawthorne	31d1bbfddb	review comments	2 years ago
Skyler Hawthorne	af03df3413	fix write scratch buffer to file	2 years ago
Skyler Hawthorne	57de4e6251	various fixes in write-all path	2 years ago
Skyler Hawthorne	e5fd5e2a9c	fix panic when view of pending write is closed	2 years ago
Skyler Hawthorne	aaa1450678	fix write-quit with auto format ... write-quit will now save all files successfully even when there is auto formatting	2 years ago
Skyler Hawthorne	c9418582d2	fix modified status with auto format	2 years ago
Skyler Hawthorne	cb23399dee	improve reliability of shutdown	2 years ago
Skyler Hawthorne	b8a07f7d15	add conditional noop render back ... It makes it much slower without stubbing this out	2 years ago
Skyler Hawthorne	69c9e44ef2	update write-quit to wait for saves	2 years ago
Skyler Hawthorne	e1f7bdb1d2	fix buffer-close	2 years ago
Skyler Hawthorne	83b6042b97	fix(write): do not set new path on document until write succeeds ... If a document is written with a new path, currently, in the event that the write fails, the document still gets its path changed. This fixes it so that the path is not updated unless the write succeeds.	2 years ago
Skyler Hawthorne	a5a93182cd	fix: buffer-close ensuring writes ... Make sure buffer-close waits for the document to finish its writes.	2 years ago
Skyler Hawthorne	d706194597	chore(write): serialize write operations within a Document ... The way that document writes are handled are by submitting them to the async job pool, which are all executed opportunistically out of order. It was discovered that this can lead to write inconsistencies when there are multiple writes to the same file in quick succession. This seeks to fix this problem by removing document writes from the general pool of jobs and into its own specialized event. Now when a user submits a write with one of the write commands, a request is simply queued up in a new mpsc channel that each Document makes to handle its own writes. This way, if multiple writes are submitted on the same document, they are executed in order, while still allowing concurrent writes for different documents.	2 years ago
Roberto Vidal	1f74cf45d4	display tree sitter scopes in a popup (#4337)	2 years ago
ZJPzjp	0e8e7cae3b	fix `:insert-output` doc: inserting output **before** each selection (#4286)	2 years ago
Michael Davis	e16c632760	Apply transactions to the jumplist for undo/redo (#4227) ... Undo/redo/earlier/later call `Document::apply_impl` which applies transactions to the document. These transactions also need to be applied to the view as in 0aedef0.	2 years ago
trivernis	1ad06ee586	Merge branch 'master'	2 years ago
trivernis	8b789b6b86	Merge branch 'seperate_code_action'	2 years ago
Michael Davis	c388e16e09	Add a helper function for applying transactions ... It is easy to forget to call `Document::apply` and/or `View::apply` in the correct order. This commit introduces a helper function which closes over both calls.	2 years ago
Michael Davis	0aedef0333	Apply transactions to Views ... This change adds View::apply calls for all Document::apply call-sites, ensuring that changes to a document do not leave invalid entries in the View's jumplist.	2 years ago
A-Walrus	1d8bb2249b	Change focus to modified docs on quit (#3872) ... * Change focus to modified docs on quit When quitting with modified documents, automatically switch focus to one of them. * Update helix-term/src/commands/typed.rs Co-authored-by: Poliorcetics <poliorcetics@users.noreply.github.com> * Make it work with buffer-close-all and the like * Cleanup Use Cow instead of String, and rename DoesntExist -> DoesNotExist Co-authored-by: Poliorcetics <poliorcetics@users.noreply.github.com>	2 years ago
ath3	7c9809eeb2	Find workspace from document path (#3553)	2 years ago
Joe	bcba5d67f9	Add goto preview (#2982)	2 years ago
trivernis	817c2a7e6d	Add blocking on file deletion ... Signed-off-by: trivernis <trivernis@protonmail.com>	2 years ago
trivernis	092163bd8f	Add command to delete the file of the current buffer	2 years ago
trivernis	9d1d6a74ec	Merge remote-tracking branch 'tree-explorer-icons/tree_explorer_icons'	2 years ago
trivernis	beeca2d823	Merge branch 'master' of github.com:helix-editor/helix	2 years ago