210 Commits (e20886dd6058a0b31fb99fb71a523b2ec3dfec64)

Author	SHA1	Message	Date
trivernis	e20886dd60	Merge branch 'master'	2 years ago
Michael Davis	fd00f3a70e	Don't apply transactions to Views in undo/redo ... View::apply should only be called by EditorView after 42e37a571e. This change removes the duplicate calls within undo/redo which could cause a panic.	2 years ago
Blaž Hrastnik	c94feed83d	core: Move state into the history module	2 years ago
trivernis	46b135bdc5	Merge branch 'master'	2 years ago
Blaž Hrastnik	511d9d8a52	cargo fmt	2 years ago
Kirawi	ce399471f0	simplify encoding test macro (#4385)	2 years ago
Matouš Dzivjak	4cff625054	chore(view): remove indent_unit helper fn (#4389)	2 years ago
Blaž Hrastnik	2a43ee0164	doc.close() now unused	2 years ago
Blaž Hrastnik	30c93994b5	Use a single save_queue on the editor	2 years ago
Skyler Hawthorne	31d1bbfddb	review comments	2 years ago
Skyler Hawthorne	9e64974f13	remove Document::format_and_save	2 years ago
Skyler Hawthorne	af03df3413	fix write scratch buffer to file	2 years ago
Skyler Hawthorne	18c32118b1	Save text in document saved events, use in status message	2 years ago
Skyler Hawthorne	f82a551b98	Rename doc save event names to past tense	2 years ago
Skyler Hawthorne	7b11e9ac69	fix erroneous write sender close ... This was not distinguishing the error types when trying a receive on an empty receiver, which was erroneously causing the sender to be closed when trying to flush the writes when there were none	2 years ago
Skyler Hawthorne	c9418582d2	fix modified status with auto format	2 years ago
Skyler Hawthorne	cb23399dee	improve reliability of shutdown	2 years ago
Skyler Hawthorne	e1f7bdb1d2	fix buffer-close	2 years ago
Skyler Hawthorne	83b6042b97	fix(write): do not set new path on document until write succeeds ... If a document is written with a new path, currently, in the event that the write fails, the document still gets its path changed. This fixes it so that the path is not updated unless the write succeeds.	2 years ago
Skyler Hawthorne	a5a93182cd	fix: buffer-close ensuring writes ... Make sure buffer-close waits for the document to finish its writes.	2 years ago
Skyler Hawthorne	d706194597	chore(write): serialize write operations within a Document ... The way that document writes are handled are by submitting them to the async job pool, which are all executed opportunistically out of order. It was discovered that this can lead to write inconsistencies when there are multiple writes to the same file in quick succession. This seeks to fix this problem by removing document writes from the general pool of jobs and into its own specialized event. Now when a user submits a write with one of the write commands, a request is simply queued up in a new mpsc channel that each Document makes to handle its own writes. This way, if multiple writes are submitted on the same document, they are executed in order, while still allowing concurrent writes for different documents.	2 years ago
Michael Davis	e16c632760	Apply transactions to the jumplist for undo/redo (#4227) ... Undo/redo/earlier/later call `Document::apply_impl` which applies transactions to the document. These transactions also need to be applied to the view as in 0aedef0.	2 years ago
trivernis	1ad06ee586	Merge branch 'master'	2 years ago
trivernis	8b789b6b86	Merge branch 'seperate_code_action'	2 years ago
Michael Davis	c388e16e09	Add a helper function for applying transactions ... It is easy to forget to call `Document::apply` and/or `View::apply` in the correct order. This commit introduces a helper function which closes over both calls.	2 years ago
Michael Davis	0aedef0333	Apply transactions to Views ... This change adds View::apply calls for all Document::apply call-sites, ensuring that changes to a document do not leave invalid entries in the View's jumplist.	2 years ago
A-Walrus	1d8bb2249b	Change focus to modified docs on quit (#3872) ... * Change focus to modified docs on quit When quitting with modified documents, automatically switch focus to one of them. * Update helix-term/src/commands/typed.rs Co-authored-by: Poliorcetics <poliorcetics@users.noreply.github.com> * Make it work with buffer-close-all and the like * Cleanup Use Cow instead of String, and rename DoesntExist -> DoesNotExist Co-authored-by: Poliorcetics <poliorcetics@users.noreply.github.com>	2 years ago
trivernis	092163bd8f	Add command to delete the file of the current buffer	2 years ago
trivernis	c7492aea1f	Merge branch 'completion'	2 years ago
Michael Davis	8988c1ecc7	Re-sort diagnostics after transaction transform (#3895) ... Applying document-change transactions to diagnostic ranges is not stable with respect to the ordering of diagnostics. This can cause diagnostics to become temporarily unordered with some edits to a document, which can eventually break some invariants/assumptions in syntax::merge. With this change, Document::diagnostics are always sorted.	2 years ago
cossonleo	aec001ad84	completion fix	2 years ago
A-Walrus	75e6a64327	Switch to Result for invalid language	2 years ago
A-Walrus	e8add6f46d	Add error handling to set language command ... If you type a nonexistant language an appropriate message will show, and the language won't be changed.	2 years ago
A-Walrus	fe37a66046	Handle formatter errors, and save anyway (#3684) ... If formatting fails, report error to log and save without formatting.	2 years ago
Michael Davis	f0d1caafcf	Look for the external formatter before invoking it (#3670) ... Currently it is not possible to save a file with a language that has an external formatter configuration unless the external formatter is installed, even if the language has a Language Server configuration capable of auto-format. This change checks that the external formatter exists before using it to create a formatting callback.	2 years ago
Blaž Hrastnik	5c2b77b41f	Make mode editor-wide rather than per-document	2 years ago
PiergiorgioZagaria	d2cec25395	Fix process spawning error handling (#3349) ... * Fix process spawning error handling * Log stderr in any case	2 years ago
Michael Davis	5f043dde56	Derive Document language name from languages.toml name key (#3338) ... * Derive Document language name from `languages.toml` `name` key This changes switches from deriving the language name from the `languages.toml` `scope` key to `name` (`language_id` in the `LanguageConfiguration` type). For the most part it works to derive the language name from scope by chopping off `source.` or `rsplit_once` on `.` but for some languages we have now like html (`text.html.basic`), it doesn't. This also should be a more accurate fallback for the `language_id` method which is used in LSP and currently uses the `rsplit_once` strategy. Here we expose the language's name as `language_name` on `Document` and replace ad-hoc calculations of the language name with the new method. This is most impactful for the `file-type` statusline element which is using `language_id`. * Use `Document::language_name` for the `file-type` statusline element The `file-type` indicator element in the statusline was using `Document::language_id` which is meant to be used to for telling Language Servers what language we're using. That works for languages with `language-server` configurations in `languages.toml` but shows text otherwise. The new `Document::language_name` method from the parent commit is a more accurate way to determine the language.	2 years ago
Kyle L. Davis	63ec10950f	Fix comment (#3334)	2 years ago
PiergiorgioZagaria	219d2c2515	Change default formatter for any language (#2942) ... * Change default formatter for any language * Fix clippy error * Close stdin for Stdio formatters * Better indentation and pattern matching * Return Result<Option<...>> for fn format instead of Option * Remove unwrap for stdin * Handle FormatterErrors instead of Result<Option<...>> * Use Transaction instead of LspFormatting * Use Transaction directly in Document::format * Perform stdin type formatting asynchronously * Rename formatter.type values to kebab-case * Debug format for displaying io::ErrorKind (msrv fix) * Solve conflict? * Use only stdio type formatters * Remove FormatterType enum * Remove old comment * Check if the formatter exited correctly * Add formatter configuration to the book * Avoid allocations when writing to stdin and formatting errors * Remove unused import Co-authored-by: Gokul Soumya <gokulps15@gmail.com>	2 years ago
Mr. E	b05fcaadad	Indent with tabs by default (#3095)	2 years ago
Skyler Hawthorne	0f3c10a021	Fix initial selection of Document in new view ... When a new View of a Document is created, a default cursor of 0, 0 is created, and it does not get normalized to a single width cursor until at least one movement of the cursor happens. This appears to have no practical negative effect that I could find, but it makes tests difficult to work with, since the initial selection is not what you expect it to be. This changes the initial selection of a new View to be the width of the first grapheme in the text.	2 years ago
Blaž Hrastnik	3d9923969a	minor: Simplify Document.language_id()	2 years ago
farwyler	f92a25a856	Passing extra formatting options to LSPs (#2635) ... * allows passing extra formatting options to LSPs - adds optional field 'format' to [[language]] sections in 'languages.toml' - passes specified options the LSPs via FormattingOptions * cleaner conversion of formatting properties * move formatting options inside lsp::Client * cleans up formatting properties merge	2 years ago
chunghha	3a398eec56	fix typos (#2304)	3 years ago
Omnikar	660e0e44b2	Add `:write!` to create nonexistent subdirectories (#1839) ... * Make `:write` create nonexistent subdirectories Prompting as to whether this should take place remains a TODO. * Move subdirectory creation to new `w!` command	3 years ago
Roland Kovacs	d962e06e91	Add runtime language configuration (#1794) (#1866) ... * Add runtime language configuration (#1794) * Add set-language typable command to change the language of current buffer. * Add completer for available language options. * Update set-language to refresh language server as well * Add language id based config lookup on `syntax::Loader`. * Add `Document::set_language3` to set programming language based on language id. * Update `Editor::refresh_language_server` to try language detection only if language is not already set. * Remove language detection from Editor::refresh_language_server * Move document language detection to where the scratch buffer is saved. * Rename Document::set_language3 to Document::set_language_by_language_id. * Remove unnecessary clone in completers::language	3 years ago
Blaž Hrastnik	c18de0e8f0	fix: Don't rely on FormattingOptions::default() ... Refs #1884	3 years ago
Skyler Hawthorne	a494f47a5d	Configurable auto pairs (#1624) ... * impl auto pairs config Implements configuration for which pairs of tokens get auto completed. In order to help with this, the logic for when *not* to auto complete has been generalized from a specific hardcoded list of characters to simply testing if the next/prev char is alphanumeric. It is possible to configure a global list of pairs as well as at the language level. The language config will take precedence over the global config. * rename AutoPair -> Pair * clean up insert_char command * remove Rc * remove some explicit cloning with another impl * fix lint * review comments * global auto-pairs = false takes precedence over language settings * make clippy happy * print out editor config on startup * move auto pairs accessor into Document * rearrange auto pair doc comment * use pattern in Froms	3 years ago
Blaž Hrastnik	a449156702	Extract a lsp position helper	3 years ago