You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
helix-plus/helix-view/src
Gabriel Hansson c1488267e5
(Updated) Apply motion API refinements (#6078)
* _apply_motion generalization where possible

API encourages users to not forget setting `editor.last_motion` when
applying a motion. But also not setting `last_motion` without applying a
motion first.

* (rename) will_find_char -> find_char

method name makes it sound like it would be returning a boolean.

* use _apply_motion in find_char

Feature that falls out from this is that repetitions of t,T,f,F are
saved with the context extention/move and count. (Not defaulting to extend
by 1 count).

* Finalize apply_motion API

last_motion is now a private field and can only be set by calling
Editor.apply_motion(). Removing need (and possibility) of writing:

`motion(editor); editor.last_motion = motion`

Now it's just: `editor.apply_motion(motion)`

* editor.last_message: rm Box wrap around Arc

* Use pre-existing `Direction` rather than custom `SearchDirection`.

* `LastMotion` type alias for `Option<Arc<dyn Fn(&mut Editor)>>`

* Take motion rather than cloning it.

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

* last_motion as Option<Motion>.

* Use `Box` over `Arc` for `last_motion`.

---------

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
1 year ago
..
handlers Fix unwrap bug in DAP (#6786) 1 year ago
base64.rs Fix new clippy lints (#5892) 1 year ago
clipboard.rs Fix warnings from clippy (#7013) 1 year ago
document.rs correctly map unsorted positions (#7471) 1 year ago
editor.rs (Updated) Apply motion API refinements (#6078) 1 year ago
env.rs Use OSC 52 as a fallback for setting the system clipboard (#3220) 2 years ago
graphics.rs build(deps): bump bitflags from 1.3.2 to 2.0.2 (#6387) 1 year ago
gutter.rs Apply all review suggestions (doc_id -> id, error message, unnecessary if) 1 year ago
info.rs Place `Info::from_keymap()` contents in `keymap.infobox()`: 1 year ago
input.rs Fix new clippy lints (#5892) 1 year ago
keyboard.rs build(deps): bump bitflags from 1.3.2 to 2.0.2 (#6387) 1 year ago
lib.rs rework positioning/rendering and enable softwrap/virtual text (#5420) 1 year ago
macros.rs Apply transactions to all views (#4733) 2 years ago
theme.rs Allow ANSI colors in themes (#5119) 1 year ago
tree.rs Fix warnings from clippy (#7013) 1 year ago
view.rs fix view anchors not at start of a visual line 1 year ago