From f7297130e72c60a7cde1bb2d3dbf1f7701e91e6f Mon Sep 17 00:00:00 2001 From: Fries Date: Tue, 4 Oct 2022 18:15:12 -0700 Subject: [PATCH] operations/upgrade: use vercmp to compare versions this fixes a bug where git pkgs will upgrade everytime with the old logic so were using an alpm function that uses pacmans version compare logic Fixes #93 --- src/operations/upgrade.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/operations/upgrade.rs b/src/operations/upgrade.rs index 4c2ed8c..bdee8c2 100644 --- a/src/operations/upgrade.rs +++ b/src/operations/upgrade.rs @@ -1,3 +1,5 @@ +use alpm::vercmp; + use crate::args::UpgradeArgs; use crate::builder::pacman::{PacmanColor, PacmanQueryBuilder, PacmanUpgradeBuilder}; use crate::internal::detect; @@ -63,7 +65,7 @@ async fn upgrade_aur(options: Options) { .silent_unwrap(AppExitCode::RpcError); if let Some(remote_package) = remote_package { - if remote_package.metadata.version != pkg.version { + if vercmp(remote_package.metadata.version.clone(), pkg.version.clone()).is_ge() { tracing::debug!( "local version: {}, remote version: {}", pkg.version,