address more comments

pull/8675/merge^2
mattwparas 10 months ago
parent 392275ddb2
commit a4145826cd

@ -161,7 +161,6 @@ where
helix_view::editor::StatusLineElement::Separator => render_separator, helix_view::editor::StatusLineElement::Separator => render_separator,
helix_view::editor::StatusLineElement::Spacer => render_spacer, helix_view::editor::StatusLineElement::Spacer => render_spacer,
helix_view::editor::StatusLineElement::VersionControl => render_version_control, helix_view::editor::StatusLineElement::VersionControl => render_version_control,
helix_view::editor::StatusLineElement::Custom => render_custom_text,
helix_view::editor::StatusLineElement::Register => render_register, helix_view::editor::StatusLineElement::Register => render_register,
} }
} }
@ -509,15 +508,6 @@ where
write(context, head, None); write(context, head, None);
} }
fn render_custom_text<F>(context: &mut RenderContext, write: F)
where
F: Fn(&mut RenderContext, String, Option<Style>) + Copy,
{
// if let Some(message) = StatusLineMessage::get() {
// write(context, message, None);
// }
}
fn render_register<F>(context: &mut RenderContext, write: F) fn render_register<F>(context: &mut RenderContext, write: F)
where where
F: Fn(&mut RenderContext, String, Option<Style>) + Copy, F: Fn(&mut RenderContext, String, Option<Style>) + Copy,

@ -529,9 +529,6 @@ pub enum StatusLineElement {
/// Current version control information /// Current version control information
VersionControl, VersionControl,
/// Custom
Custom,
/// Indicator for selected register /// Indicator for selected register
Register, Register,
} }

@ -27,7 +27,6 @@ mod steel_implementations {
impl steel::rvals::Custom for Mode {} impl steel::rvals::Custom for Mode {}
impl steel::rvals::Custom for Event {} impl steel::rvals::Custom for Event {}
// Reference types along with value types - This should allow for having users
impl CustomReference for Event {} impl CustomReference for Event {}
impl Custom for Rect {} impl Custom for Rect {}
impl Custom for crate::graphics::CursorKind {} impl Custom for crate::graphics::CursorKind {}
@ -48,5 +47,4 @@ mod steel_implementations {
impl Custom for IndentGuidesConfig {} impl Custom for IndentGuidesConfig {}
impl Custom for LineEndingConfig {} impl Custom for LineEndingConfig {}
impl Custom for SmartTabConfig {} impl Custom for SmartTabConfig {}
// impl Custom for SoftW
} }

@ -62,7 +62,6 @@ impl Info {
Self { Self {
title: title.to_string(), title: title.to_string(),
width: text.lines().map(|l| l.width()).max().unwrap_or(body.len()) as u16, width: text.lines().map(|l| l.width()).max().unwrap_or(body.len()) as u16,
// height: (body.len() + newlines) as u16,
height, height,
text, text,
} }

Loading…
Cancel
Save