57a18e22e5
lsp_types: Make `Url::from_file/directory_path` infallible
...
These functions return `Result<Self, ()>` in the `url` crate but the
result is unnecessary since the functions never return the error branch.
We can eliminate the Result to remove some `expect`s in the calling
code.
1 month ago
636902ea3e
Handle conversion to/from new LSP URL type
1 month ago
b56f09a6fc
Replace url::Url with a String wrapper
1 month ago
1183c6c244
minor: `use bitflags::bitflags` rather than extern crate
...
This seems to be a historical artifact in `lsp_types` - we can use a
regular `use` statement to pull in the `bitflags!` macro rather than
an external crate definition. This fixes rust-analyzer's ability to find
the macro at least on rust-analyzer 2024-02-26.
1 month ago
6cff3124cb
lsp_types: Prefer `crate::Url` to `url::Url`
...
This is a cosmetic change to replace all direct `use`s of the `url::Url`
type in the `helix-lsp-types` crate with `use crate::Url;`.
It's the same type currently but will diverge in the child commits and
this refactor makes that change simpler.
1 month ago
7b034e719b
LSP: Use PathBufs for workspace folders
...
Internally the LSP client should hold workspace folders as paths. Using
URLs for this type is inconvenient (since we compare it to paths) and
might cause mismatches because of URLs not being normalized. The URLs
must be paths anyways so we can convert these types lazily when we need
to send them to a server.
1 month ago
a7651f5bf0
build(deps): bump the rust-dependencies group with 4 updates ( #11850 )
...
Bumps the rust-dependencies group with 4 updates: [once_cell](https://github.com/matklad/once_cell ), [futures-util](https://github.com/rust-lang/futures-rs ), [futures-executor](https://github.com/rust-lang/futures-rs ) and [cc](https://github.com/rust-lang/cc-rs ).
Updates `once_cell` from 1.20.1 to 1.20.2
- [Changelog](https://github.com/matklad/once_cell/blob/master/CHANGELOG.md )
- [Commits](https://github.com/matklad/once_cell/compare/v1.20.1...v1.20.2 )
Updates `futures-util` from 0.3.30 to 0.3.31
- [Release notes](https://github.com/rust-lang/futures-rs/releases )
- [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/futures-rs/compare/0.3.30...0.3.31 )
Updates `futures-executor` from 0.3.30 to 0.3.31
- [Release notes](https://github.com/rust-lang/futures-rs/releases )
- [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/futures-rs/compare/0.3.30...0.3.31 )
Updates `cc` from 1.1.23 to 1.1.28
- [Release notes](https://github.com/rust-lang/cc-rs/releases )
- [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/cc-rs/compare/cc-v1.1.23...cc-v1.1.28 )
---
updated-dependencies:
- dependency-name: once_cell
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: futures-util
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: futures-executor
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: cc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 month ago
761f70d611
build(deps): bump cachix/install-nix-action from 29 to 30 ( #11852 )
...
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action ) from 29 to 30.
- [Release notes](https://github.com/cachix/install-nix-action/releases )
- [Commits](https://github.com/cachix/install-nix-action/compare/v29...v30 )
---
updated-dependencies:
- dependency-name: cachix/install-nix-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 month ago
f55f1f8b43
Remove auto-pair for single quote in SML. ( #11838 )
...
Similar to OCaml and other ML languages, single quote is a normal
character that can appear in identifiers and is also used in type
parameters. It is not used for strings or character literals, which both
use double quote.
Co-authored-by: Rose Hogenson <rosehogenson@posteo.net>
2 months ago
048973fc55
Add support for dune project language ( #11829 )
2 months ago
f6d39cbc1d
refactor(lsp): handle out-of-range `active_signature` ( #11825 )
2 months ago
162028d444
Merge pull request #11486 from helix-editor/lsp-location-refactor
...
Replace uses of `lsp::Location` with a custom Location type
2 months ago
02b6f1488a
fix git repo detection on symlinks ( #11732 )
2 months ago
57ec3b7330
Add a highlight for the keyword.storage scope to the onedark theme ( #11802 )
...
Rust highlight queries make use of keyword.storage for keywords like
`struct`, `enum`, and also for modifiers like `mut` and `ref`.
Using a color that's different to the one used for
`"variable.parameter"` (red) improves differentiation for mutable
function arguments.
2 months ago
083bb0118f
Fix some odin highlights ( #11804 )
...
Some of the odin highlights seemed wrong or lacking, like the import names were not being matched:
```odin
// color both "rl" here to same value
import rl "vendor:raylib"
...
rl.Vector3
```
Import color was also not being used correctly
2 months ago
cb9307bb03
build(deps): bump the rust-dependencies group with 5 updates ( #11805 )
...
Bumps the rust-dependencies group with 5 updates:
| Package | From | To |
| --- | --- | --- |
| [once_cell](https://github.com/matklad/once_cell ) | `1.19.0` | `1.20.1` |
| [regex](https://github.com/rust-lang/regex ) | `1.10.6` | `1.11.0` |
| [tempfile](https://github.com/Stebalien/tempfile ) | `3.12.0` | `3.13.0` |
| [libc](https://github.com/rust-lang/libc ) | `0.2.158` | `0.2.159` |
| [cc](https://github.com/rust-lang/cc-rs ) | `1.1.21` | `1.1.23` |
Updates `once_cell` from 1.19.0 to 1.20.1
- [Changelog](https://github.com/matklad/once_cell/blob/master/CHANGELOG.md )
- [Commits](https://github.com/matklad/once_cell/compare/v1.19.0...v1.20.1 )
Updates `regex` from 1.10.6 to 1.11.0
- [Release notes](https://github.com/rust-lang/regex/releases )
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/regex/compare/1.10.6...1.11.0 )
Updates `tempfile` from 3.12.0 to 3.13.0
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Stebalien/tempfile/compare/v3.12.0...v3.13.0 )
Updates `libc` from 0.2.158 to 0.2.159
- [Release notes](https://github.com/rust-lang/libc/releases )
- [Changelog](https://github.com/rust-lang/libc/blob/0.2.159/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/libc/compare/0.2.158...0.2.159 )
Updates `cc` from 1.1.21 to 1.1.23
- [Release notes](https://github.com/rust-lang/cc-rs/releases )
- [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/cc-rs/compare/cc-v1.1.21...cc-v1.1.23 )
---
updated-dependencies:
- dependency-name: once_cell
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
- dependency-name: regex
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
- dependency-name: tempfile
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
- dependency-name: libc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: cc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 months ago
e28b0da1fb
build(deps): bump cachix/install-nix-action from V28 to 29 ( #11806 )
...
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action ) from V28 to 29. This release includes the previously tagged commit.
- [Release notes](https://github.com/cachix/install-nix-action/releases )
- [Commits](https://github.com/cachix/install-nix-action/compare/V28...v29 )
---
updated-dependencies:
- dependency-name: cachix/install-nix-action
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 months ago
e5dd60f794
Add Erlang Language Platform (ELP) support to Erlang ( #11499 )
...
* Add ELP LSP to Erlang
* generate docs
---------
Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>
2 months ago
d103248cb8
Small bogster theme improvements ( #11353 )
...
* Add a distinct jump-label to bogster theme
* Make the primary label visible in the bogster theme
2 months ago
42453786a0
add key concepts to usage.md ( #11485 )
2 months ago
e1cacd149c
chore: add "ui.virtual.jump-label" to gruber-darker theme ( #11547 )
2 months ago
5975e53600
Add vale language server ( #11636 )
...
Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>
2 months ago
24f24299f2
feat(languages): add `superhtml` as lsp for `html` ( #11609 )
2 months ago
5ffd4ae529
Add undocumented keybindings to book ( #11662 )
2 months ago
8cdce9212c
Improve tree-sitter-subtree ( #11663 )
...
* Make unnamed nodes visible in subtree view
* Refine command description
* Update generated docs
* Update unit test expected output
2 months ago
48b89d4dcf
fix: fish builtin functions are highlighted as such ( #11792 )
...
* fix: fish builtin functions are highlighted as such
* fix: single-character commands recognized as builtins
???? how did that query even happen
* fix: update builtins to fish 3.7.1
* fix: add back `alias` and `isatty`
they are builtins, but aren't reported by builtin -n for some reason
2 months ago
dd45ae1289
languages.toml: recognize ldtk files ( #11793 )
2 months ago
2c3a00e96a
Fix typo in tutor ch 13.5 ( #11765 )
...
It said "split" instead of "swap"
2 months ago
2ce4c6d5fa
Bump tree-sitter-nickel ( #11771 )
2 months ago
82dd963693
Add: validation of bundled themes in build workflow ( #11627 )
...
* Add: xtask to check themes for validation warnings
* Update: tidied up runtime paths
* Update: test build workflow
* Update: address clippy lints
* Revert: only trigger workflow on push to master branch
* Add: Theme::from_keys factory method to construct theme from Toml keys
* Update: returning validation failures in Loader.load method
* Update: commented out invalid keys from affected themes
* Update: correct invalid keys so that valid styles still applied
* Update: include default and base16_default themes in check
* Update: renamed validation_failures to load_errors
* Update: introduce load_with_warnings helper function and centralise logging of theme warnings
* Update: use consistent naming throughout
2 months ago
70bbc9d526
Add .rbs files to ruby language ( #11786 )
2 months ago
b18a471ed1
Remove "true" from odinfmt line ( #11759 )
...
The `-stdin` in `odinfmt` does not take any arguments, the `true` part here just confuses the formatter, and makes it ignore `odinfmt.json` file.
Removing it fixes the issue.
2 months ago
f49b18d157
chore: Update slint tree-sitter grammar to version 1.8 ( #11757 )
...
Bump the commit to the tree-sitter corresponding to the
latest Slint release.
2 months ago
50ba848b59
Update HCL grammar ( #11749 )
...
* Point HCL grammer to newest
This adds support for provider-defined function calls in Terraform.
* Update HCL grammar repo
The repository was moved from the original authors personal GitHub to the `tree-sitter-grammars` organization.
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
---------
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2 months ago
30aa375f2d
build(deps): bump the rust-dependencies group with 2 updates ( #11761 )
...
Bumps the rust-dependencies group with 2 updates: [thiserror](https://github.com/dtolnay/thiserror ) and [cc](https://github.com/rust-lang/cc-rs ).
Updates `thiserror` from 1.0.63 to 1.0.64
- [Release notes](https://github.com/dtolnay/thiserror/releases )
- [Commits](https://github.com/dtolnay/thiserror/compare/1.0.63...1.0.64 )
Updates `cc` from 1.1.19 to 1.1.21
- [Release notes](https://github.com/rust-lang/cc-rs/releases )
- [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/cc-rs/compare/cc-v1.1.19...cc-v1.1.21 )
---
updated-dependencies:
- dependency-name: thiserror
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: cc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 months ago
73deabaa40
Fix panic when drawing at the edge of the screen. ( #11737 )
...
When pressing tab at the edge of the screen, Helix panics in debug mode
subtracting position.col - self.offset.col.
To correctly account for graphemes that are partially visible,
column_in_bounds takes a width and returns whether the whole range is
in bounds.
Co-authored-by: Rose Hogenson <rosehogenson@posteo.net>
2 months ago
8b1764d164
Join single-line comments with J. ( #11742 )
...
Fixes #8565 .
Co-authored-by: Rose Hogenson <rosehogenson@posteo.net>
2 months ago
d6eb10d9f9
Update README.md ( #11665 )
...
Readability Clarification
2 months ago
896bf47d8d
adding support for jujutsu VCS inside find_workspace resolution ( #11685 )
2 months ago
c850b90f67
add circom tree-sitter, syntax-highlighting, and lsp support ( #11676 )
...
* add circom tree-sitter and lsp support
* add circom syntax highlighting queries
* cargo xtask docgen
* updated highlights to reflect helix themes typing
* bugfix: ~= operator causing issues
* minor adjustment: add = and ; operator and delimiter
2 months ago
274c660a0e
small fix syntax highlighting in vue.js files ( #11706 )
...
* small fix syntax highlighting in vue.js files
* changes after review by mikedavis
2 months ago
5717aa8e35
Fix Rope.starts_with. ( #11739 )
...
Co-authored-by: Rose Hogenson <rosehogenson@posteo.net>
2 months ago
9f93de5a4b
fix(themes): fix diagnostics in snazzy ( #11731 )
...
* fix(themes): fix diagnostics in snazzy
Before this change, the color scheme makes most diagnostics difficult
to read. This fix makes diagnostic much less obtrusive when using
snazzy.
* chore(fmt): nicely format snazzy theme file
2 months ago
b85e824ba9
Handle window/showMessage and display it bellow status line ( #5535 )
...
* Handle window/showMessage and display it bellow status line
* Enable `editor.lsp.display_messages` by default
---------
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
2 months ago
a7b8b27abf
chore: add ruff and jedi lsp servers ( #11630 )
...
* chore: add ruff lsp server
Ruff provide a `server` command that starts a LSP server:
https://docs.astral.sh/ruff/editors/#language-server-protocol
* chore: add jedi lsp server
[jedi-language-server](https://github.com/pappasam/jedi-language-server ) is a Python LSP server based the popular [jedi](https://jedi.readthedocs.io/en/latest/ ) library.
* docs: add ruff and jedi as python lsp servers
2 months ago
84fbadbdde
Update picker headers styling in Darcula themes ( #11620 )
...
* Apply styling to picker headers in Darcula themes
* Add background to active picker column in Darcula.
2 months ago
f4df4bf5f2
Stylize horizon-dark picker v2 columns ( #11649 )
2 months ago
c754949454
build(deps): bump the rust-dependencies group with 4 updates ( #11712 )
...
Bumps the rust-dependencies group with 4 updates: [unicode-segmentation](https://github.com/unicode-rs/unicode-segmentation ), [anyhow](https://github.com/dtolnay/anyhow ), [rustix](https://github.com/bytecodealliance/rustix ) and [cc](https://github.com/rust-lang/cc-rs ).
Updates `unicode-segmentation` from 1.11.0 to 1.12.0
- [Commits](https://github.com/unicode-rs/unicode-segmentation/compare/v1.11.0...v1.12.0 )
Updates `anyhow` from 1.0.87 to 1.0.89
- [Release notes](https://github.com/dtolnay/anyhow/releases )
- [Commits](https://github.com/dtolnay/anyhow/compare/1.0.87...1.0.89 )
Updates `rustix` from 0.38.36 to 0.38.37
- [Release notes](https://github.com/bytecodealliance/rustix/releases )
- [Changelog](https://github.com/bytecodealliance/rustix/blob/main/CHANGELOG.md )
- [Commits](https://github.com/bytecodealliance/rustix/compare/v0.38.36...v0.38.37 )
Updates `cc` from 1.1.18 to 1.1.19
- [Release notes](https://github.com/rust-lang/cc-rs/releases )
- [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rust-lang/cc-rs/compare/cc-v1.1.18...cc-v1.1.19 )
---
updated-dependencies:
- dependency-name: unicode-segmentation
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: rust-dependencies
- dependency-name: anyhow
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: rustix
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
- dependency-name: cc
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: rust-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 months ago
9851edf477
build(deps): bump cachix/install-nix-action from V27 to 28 ( #11713 )
...
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action ) from V27 to 28. This release includes the previously tagged commit.
- [Release notes](https://github.com/cachix/install-nix-action/releases )
- [Commits](https://github.com/cachix/install-nix-action/compare/V27...V28 )
---
updated-dependencies:
- dependency-name: cachix/install-nix-action
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 months ago
5ce77de0dc
fix: Lean language server consuming excessive memory ( #11683 )
...
The Lean process, spawned by the language server, might use excessive
memory in certain situation, causing the entire system to freeze. See:
https://github.com/leanprover/lean4/issues/5321
The language server accepts a CLI flag for limiting memory use. I set
it to 1024MB, which might be a bit arbitrary, but definitly prevents
the system from crashing.
2 months ago
Michael Davis
dependabot[bot]
rhogenson
Christopher Kaster
RoloEdits
Pascal Kuthe
Skyler Hawthorne
Ian Hobson
Akseli
offsetcyan
Denis Krienbühl
David Crespo
Oren Mittman
David Else
chtenb
Axlefublr
Dmitriy Sokolov
Ian J Sikes
jneem
Tim
Konstantin Munteanu
Tobias Hunger
Lukas Knuth
James Munger
Théo Daron
Thor 🪁
Mykyta
timd
Ayoub Benali
Nicolas Karolak
Jesús González
ves
Niklas Gruhn