Ivan Tham
9640ed1425
Add clarification to last buffer
3 years ago
Robin
9baf1ecc90
add symbol picker ( #230 )
...
* add symbol picker
use the lsp document_symbol request
* fix errors from merging in master
* add docs for symbol picker
3 years ago
Robin
44cc0d8eb0
add alternate file ( #223 )
...
* add alternate file
inspired by vim ctrl-6/kak ga commands. the alternate file is kept per view
* apply feedback from #223
* rename to last_accessed
* add ga doc
* add fail message for ga
3 years ago
Wojciech Kępka
c754df12b3
lsp: Check bounds when converting lsp positions ( #204 )
...
* lsp: Make position conversion funcs return `Option`
* Add tests
* Fixes
* Revert pos_to_lsp_pos to panic
3 years ago
Blaž Hrastnik
278361a086
Only auto-format for certain languages
...
Fixes #53
Fixes #207
3 years ago
Jakub Bartodziej
69fe46a122
Add :earlier and :later commands that can be used to navigate the full edit history. ( #194 )
...
* Disable deleting from an empty buffer which can cause a crash.
* Improve on the fix for deleting from the end of the buffer.
* Clean up leftover log.
* Avoid theoretical underflow.
* Implement :before which accepts a time interval and moves the editor to
the closest history state to the commit of the current time minus that
interval. Current time is now by default, or the commit time if :before
has just been used.
* Add :earlier an :later commands that can move through
the edit history and retrieve changes hidded by undoing
and commiting new changes. The commands accept a number
of steps or a time period relative to the currrent change.
* Fix clippy lint error.
* Remove the dependency on parse_duration, add a custom parser instead.
* Fix clippy errors.
* Make helix_core::history a public module.
* Use the helper for getting the current document and view.
* Handled some PR comments.
* Fix the logic in :later n.
Co-authored-by: Ivan Tham <pickfire@riseup.net>
* Add an alias for :earlier.
Co-authored-by: Ivan Tham <pickfire@riseup.net>
* Add an alias for later.
Co-authored-by: Ivan Tham <pickfire@riseup.net>
* Run cargo fmt.
* Add some tests for earlier and later.
* Add more tests and restore the fix for later that diappeared somehow.
* Use ? instead of a match on an option.
Co-authored-by: Ivan Tham <pickfire@riseup.net>
* Rename to UndoKind.
* Remove the leftover match.
* Handle a bunch of review comments.
* More systemd.time compliant time units and additional description for the new commands.
* A more concise rewrite of the time span parser using ideas from PR discussion.
* Replace a match with map_err().
Co-authored-by: Ivan Tham <pickfire@riseup.net>
Co-authored-by: Jakub Bartodziej <jqb@google.com>
Co-authored-by: Ivan Tham <pickfire@riseup.net>
3 years ago
PabloMansanet
86af55c379
Movement fixes, refactor and unit test suite ( #217 )
...
* Add convenience/clarity wrapper for Range initialization
* Test horizontal moves
* Add column jumping tests
* Add failing movement conditions for multi-word moves
* Refactor skip_over_next
* Add complex forward movement unit tests
* Add strict whitespace checks and edge case tests
* Restore formatting
* Remove unused function
* Add empty test case for deletion and fix nth_prev_word_boundary
* Add tests for backward motion
* Refactor word movement
* Address review comments and finish refactoring backwards move
* Finish unit test suite
* Fmt pass
* Fix lint erors
* Clean up diff restoring bad 'cargo fmt' actions
* Simplify movement closures (thanks Pickfire)
* Fmt pass
* Replace index-based movement with iterator based movement, ensuring that each move incurs a single call to the RopeSlice API
* Break down tuple function
* Extract common logic to all movement functions
* Split iterator helpers away into their own module
* WIP reducing clones
* Operate on spans
* WIP simplifying iterators
* Simplify motion helpers
* Fix iterator
* Fix all unit tests
* Refactor and simplify
* Simplify fold
3 years ago
Wojciech Kępka
0c2b99327a
commands: Handle `t<ENTER>` as till newline
3 years ago
Robin van Dijk
c0d32707d0
move to first nonwhitespace on shift-i
...
This matches the behaviour in vim and kak
3 years ago
Ivan Tham
6b3c9d8ed3
Fix jump behavior, goto_implementation now jump
...
Better jump behavior since we override the first jump if it's on the
first document. At the same time, ctrl-i is now working with gd jumps.
3 years ago
Zheming Li
ae51065213
Support go to line 1
3 years ago
Wojciech Kępka
4e3a343602
Make `r<ENTER>` work
3 years ago
Wojciech Kępka
81e02e1ba4
Remove unwanted `as_str`
3 years ago
Wojciech Kępka
c349ceb61f
Don't replace newlines
3 years ago
Wojciech Kępka
2e4a338944
Add bounds checks to replace
3 years ago
Wojciech Kępka
9c83a98469
commands: Replace all characters in selection
3 years ago
Wojciech Kępka
c978d811d9
Cleanup find_first_non_whitespace_char funcs
3 years ago
Wojciech Kępka
48df05b16d
commands: Add goto first non-whitespace char of line
3 years ago
Kirawi
b873fb9897
Fix Unicode ( #135 )
...
* init
* wip
* wip
* fix unicode break
* fix unicode break
* Update helix-core/src/transaction.rs
Co-authored-by: Benoît Cortier <benoit.cortier@fried-world.eu>
* clippy
* fix
* add changes
* added test
* wip
* wip
* wip
* wip
* fix
* fix view
* fix #88
Co-authored-by: Benoît Cortier <benoit.cortier@fried-world.eu>
3 years ago
Wojciech Kępka
c65b4dea09
commands: Add replace with yanked as `R`
3 years ago
Blaž Hrastnik
0201ef9205
ui: completion: Use the correct type_name
...
Fixes #166
3 years ago
Blaž Hrastnik
9821beb5c4
Make gh/gl extend selection in select mode
3 years ago
Benoît CORTIER
68affa3c59
Implement register selection
...
User can select register to yank into with the " command.
A new state is added to `Editor` and `commands::Context` structs.
This state is managed by leveraging a new struct `RegisterSelection`.
3 years ago
Blaž Hrastnik
8d6fad4cac
lsp: Provide workspace root on client.initialize()
3 years ago
Blaž Hrastnik
4f561e93b8
View mode: Use saturating_sub when calculating first_col
3 years ago
Blaž Hrastnik
01b1bd15a1
commands: use chars().count() over .len() on strings
3 years ago
Wojciech Kępka
16b1cfa3be
Add diagnostics keybindings
3 years ago
Ivan Tham
2066e866c7
Add spc w w for window mode
3 years ago
Ivan Tham
40744ce835
Add ctrl-w in insert mode
...
It seemed to panic when I pressed too many times, but that is from
lsp side.
3 years ago
Ivan Tham
8c2fa12ffc
Add window mode
...
Fix #93
3 years ago
ahkrr
444cd0b068
fix: make find_prev_char and till_prev_char work
...
Bevore this PR `commands::find_prev_char` and `commands::till_prev_char` were triggerable through keys
but `seach::find_nth_next()` was hardcoded in `_find_char`.
The passed `fn` was nerver used. With this PR the passed `fn` is used.
The change in search.rs resolves an off by one error in the behivor of `find_nth_prev`
3 years ago
Kirawi
c17dcb8633
Fixing Multiple Panics ( #121 )
...
* init
* wip
* wip
3 years ago
Antoni Stevenet
a1f4b8f92b
Add home-end keymaps, (as kakoune/vim do) ( #83 )
...
* add home-end keymaps
* implement extend methods for extend_line_start, extend_line_end
* add home-end mappings to keymaps.md
* add ^-$ extend mappings for extend mode
* pass cargo linter
3 years ago
notoria
adcfcf9044
Replace ^/$ with gh/gl
3 years ago
Blaž Hrastnik
4f0e3aa948
Implement gt/gm/gb, remap goto tYpe to gy
3 years ago
Blaž Hrastnik
bd4552cd2b
scroll: Fix the clamping
3 years ago
Blaž Hrastnik
8afd4e1bc2
Exit select mode on delete_selection
3 years ago
Kevin Sjöberg
fdb5bfafae
Limit goto count
...
Giving a goto count greater than the number of lines in the buffer
would cause Helix to panic.
3 years ago
Jakub Bartodziej
09a7db637e
Avoid theoretical underflow.
3 years ago
Jakub Bartodziej
31ed4db153
Clean up leftover log.
3 years ago
Jakub Bartodziej
3c5dfb0633
Improve on the fix for deleting from the end of the buffer.
3 years ago
Jakub Bartodziej
6cbc0aea92
Disable deleting from an empty buffer which can cause a crash.
3 years ago
Blaž Hrastnik
cbb3ebafdc
Support ctrl-f and ctrl-b to page up/down, fixes #41
3 years ago
Daichi Takamiya
4d12c7c3cf
Fix empty command cause panic
3 years ago
Blaž Hrastnik
ce25aa951e
Allow setting a filepath on :write
3 years ago
Blaž Hrastnik
d8e16554bf
Don't crash if no filename specified on open
3 years ago
Blaž Hrastnik
2c48d65b15
Format document on save
3 years ago
Blaž Hrastnik
094203c74e
Update deps, introduce the new tree-sitter lifetimes
3 years ago
Blaž Hrastnik
f1dc25a774
Support count for indent too
4 years ago
Blaž Hrastnik
4f335fabc8
Fix unindent to work with tabs, take a count
4 years ago
Blaž Hrastnik
9c24f1ec0e
Drop selection_lines completely, change move_line_start binding
4 years ago
Blaž Hrastnik
f99a683991
Fix crash if appending at end of line on the last line of the file
4 years ago
Blaž Hrastnik
5a245b83a0
Append :fmt as a separate history state
4 years ago
Blaž Hrastnik
54de768915
Fix crash if typing | (regex or) into the prompt.
...
Zero-width matches at the start of the file make no sense to us.
4 years ago
Blaž Hrastnik
5e6b46e7c5
Use array::IntoIter.
4 years ago
Blaž Hrastnik
354b822d21
Fix crash on xa<Enter> if we were on the last line.
4 years ago
Blaž Hrastnik
fae2127a11
Drop cx.view_id, it was used before we had cx.current.
4 years ago
Blaž Hrastnik
0e5b421646
When calculating a new selection, we need to take newly inserted text into account.
4 years ago
Blaž Hrastnik
4a9d1163e0
Hacky way to specify indent scopes per language via toml configs.
...
Can't do it via a scm query nicely because it returns an iterator over
all the matches, whereas we want to traverse the tree ourselves.
Can't extract the pattern data from a parsed query either.
Oh well, toml files for now.
4 years ago
Blaž Hrastnik
e4ff75b4d4
Add :fmt (formats the whole file).
4 years ago
Blaž Hrastnik
1255bcb8a3
Simplify the compositor callback.
4 years ago
Blaž Hrastnik
ed827e993f
Fix jumplist jumps, keep the selection on vsplit.
4 years ago
Blaž Hrastnik
caf4349925
Remove some of the panics, just log instead.
4 years ago
Blaž Hrastnik
d24844b73d
ui: Render command mode doc text if available.
4 years ago
Blaž Hrastnik
d4d5e88ade
Show a message if no definition was found.
4 years ago
Blaž Hrastnik
1be8b2005d
Extract a method for view alignment.
4 years ago
Blaž Hrastnik
adaf861881
vsplit can now split scratch buffers.
4 years ago
Blaž Hrastnik
ff84c8e394
Command mode: Per command completers.
4 years ago
Blaž Hrastnik
87e7a0de3f
Save space by having the command hashmap use const static refs.
4 years ago
Blaž Hrastnik
9604a0c294
Improve command mode handling.
4 years ago
Blaž Hrastnik
243456a583
Disallow quitting on last view if unsaved changes present.
4 years ago
Blaž Hrastnik
c0a8b81487
Only send the document close event if we're closing the underlying buffer
4 years ago
Blaž Hrastnik
c20813690f
View::new is infallible, so is editor.switch/new_file.
4 years ago
Blaž Hrastnik
f2c79e245b
Allow switching views back to scratch buffers.
4 years ago
Blaž Hrastnik
7c915dc065
Add the :new command, don't crash if saving without filename.
4 years ago
Blaž Hrastnik
f8844c6811
Implement pair expansion when pressing new line between bracket pairs.
...
From:
{|}
To:
{
|
}
4 years ago
Blaž Hrastnik
ba97005495
Work around the rest of the blocking issues.
4 years ago
Blaž Hrastnik
d00414f81a
Start moving more LSP calls into callbacks/futures without capturing self
4 years ago
Blaž Hrastnik
355ad3cb82
Tokio migration.
4 years ago
Blaž Hrastnik
0e5308bce1
Need to allow this lint, the Hook signature requires Option<>.
4 years ago
Blaž Hrastnik
ab4decfd6d
Make post hooks trigger even when a different handler processes input.
...
The default handler is now simply a fallback.
4 years ago
Blaž Hrastnik
594575ba3f
Center forward and backward jumps too.
4 years ago
Blaž Hrastnik
c64240b6ef
Implement most of the view mode (z).
4 years ago
Blaž Hrastnik
3e5f24a9d5
lsp: support both utf-8 and utf-16 offsets.
...
Still need to implement the clangd encoding negotiation, but it's
a start. Should also manually override to utf8 for pyls.
4 years ago
Blaž Hrastnik
811f952a41
Center search results.
4 years ago
Blaž Hrastnik
180521fefe
Adjust scroll() to match kakoune: only scroll the view if cursor in bounds.
4 years ago
Blaž Hrastnik
2a1f10d1b5
Center the new position on screen after doing a goto jump.
4 years ago
Blaž Hrastnik
95dd55ba94
Fix overlap calculation.
4 years ago
Blaž Hrastnik
392c4a9c02
Keep primary selection as space+space.
4 years ago
Blaž Hrastnik
73f4abbb37
N as extend with search (for now, N should be search_prev).
4 years ago
Blaž Hrastnik
865429643b
<space>w for save, <space>c for close current split.
4 years ago
Blaž Hrastnik
9ca2909c80
Loop around the end on regex searches.
4 years ago
Blaž Hrastnik
8b33ba2284
Correct the naming issue with vsplit and hsplit being swapped.
4 years ago
Blaž Hrastnik
58c5fec592
minor: This comment was resolved.
4 years ago
Blaž Hrastnik
12961d657f
Implement P as paste_before.
4 years ago
Blaž Hrastnik
82ff996662
Yank selection when deleting.
4 years ago
Blaž Hrastnik
463f58dfda
Fix clamping scroll in certain cases.
...
.clamp(min, max) requires that min < max. In some cases
first + scrolloff > last - scrolloff and we would panic.
4 years ago
Blaž Hrastnik
0e9ecccfc1
clippy: Drop or-patterns for now because they're not on stable rust yet
4 years ago
Blaž Hrastnik
95d0bba81a
ui: Improve completion state handling.
4 years ago
Blaž Hrastnik
59a0fc7b59
w, b, e: Match kakoune's behavior in selecting by default.
...
I initially preferred only moving the cursor, but selecting the whole
word is a lot nicer for things like wd (instead of vwd).
4 years ago
Blaž Hrastnik
ab1d11088f
Import some lsp utilities.
4 years ago
Blaž Hrastnik
77cab5a715
Merge open_above and open_below definitions.
4 years ago
Blaž Hrastnik
cc058ad78f
Simplify some code.
4 years ago
Blaž Hrastnik
0dbd5b61ef
Simplify code by providin cx.current() = (view, doc).
4 years ago
Blaž Hrastnik
ceea5eacd8
clippy lint
4 years ago
Blaž Hrastnik
7dfd7f51a0
Implement space-v as view same file in split.
4 years ago
Blaž Hrastnik
6c4093c946
Weave through view_id references so that views into one file have independent selects.
4 years ago
Blaž Hrastnik
dfc17becd5
Move pickers under my leader key mode (space).
4 years ago
Blaž Hrastnik
e166da2ab0
fix: A (append to line) was inserting before last char.
4 years ago
Blaž Hrastnik
1b5316ea74
Track document modified state.
4 years ago
Blaž Hrastnik
88bb7a1f38
Repeat insert command (.).
4 years ago
Blaž Hrastnik
e833d65b77
Teach file picker how to find the project root (.git).
4 years ago
Blaž Hrastnik
8098e9bdcd
Allow setting a status message.
4 years ago
Blaž Hrastnik
742b3a709f
Store intra-files jumps (goto) on the jumplist.
4 years ago
Blaž Hrastnik
0083a6c325
commands: Simplify _goto.
4 years ago
Blaž Hrastnik
ea407ccdba
Implement <n>g as goto line n.
4 years ago
Blaž Hrastnik
5c2d2fda21
Wire up opening in splits via pickers.
4 years ago
Blaž Hrastnik
aefafc25cd
Replace Mode::Goto with just using on_next_key.
4 years ago
Blaž Hrastnik
a24c3fff54
Filter the completion menu based on text entered.
4 years ago
Blaž Hrastnik
2a3910c1d9
wip: Async async. Delay response handling with a callback.
4 years ago
Blaž Hrastnik
ad3325db8e
minor: Remove a few unwraps.
4 years ago
Blaž Hrastnik
9a36d2c2a8
wip: Hooks & trigger characters for completion/signature_help.
4 years ago
Blaž Hrastnik
8657c57cf2
Trivial jumplist implementation.
4 years ago
Blaž Hrastnik
915fd9ebaf
Restore buffer_picker.
4 years ago
Blaž Hrastnik
8a0ab447ec
editor.open can now either replace the current view or open in a split.
4 years ago
Blaž Hrastnik
8328fe926d
Drop refcell use, make view simply ref doc.id.
4 years ago
Blaž Hrastnik
d0530fb839
Fix a scrolling crash where it would jump past the end of the buffer.
4 years ago
Blaž Hrastnik
73c92a0bc1
Implement m / match_brackets (using tree sitter).
4 years ago
Blaž Hrastnik
df306fe031
Implement open_above (O).
4 years ago
Blaž Hrastnik
42d07b0621
Implement replace command (r<key>).
4 years ago
Blaž Hrastnik
bf95ee27aa
Store Document on the Editor type, make View reference it.
4 years ago
Blaž Hrastnik
5e6716c89c
Add tab_width and indent_unit config.
4 years ago
Blaž Hrastnik
cbcacb1063
Merge some imports.
4 years ago
Blaž Hrastnik
71999cce43
Implement auto-pairs behavior for open and close.
4 years ago
Blaž Hrastnik
a32806b490
Improve completion: src/<tab> will now correctly complete to src/main.rs
4 years ago
Blaž Hrastnik
f29f01858d
Implement iter() and len() directly on Selection.
4 years ago
Blaž Hrastnik
e9bd9e72c3
Pos conversions always operate on whole documents.
4 years ago
Blaž Hrastnik
175d38c88c
toggle_comments needs to append to history.
4 years ago
Blaž Hrastnik
c331721565
Finish hiding doc.state / State as an implementation detail.
4 years ago
Blaž Hrastnik
8ba1e15d29
Expose doc.syntax() via accessor.
4 years ago
Blaž Hrastnik
e261f3c50d
Expose doc.language_server as an accessor.
4 years ago
Blaž Hrastnik
59e6024186
Remove State from a few more signatures.
4 years ago
Blaž Hrastnik
dbcc099f48
Move things out of state.rs.
4 years ago
Blaž Hrastnik
0f6624491b
Fix completion panicking if text changed before insert completed.
4 years ago
Blaž Hrastnik
8eaf9a432d
Make Transaction::change only rely on the rope.
4 years ago
Blaž Hrastnik
51c15da3c3
Hold a reference to executor on the Editor type.
4 years ago
Blaž Hrastnik
e3ec5e31ec
Fix goto code before merging.
4 years ago
Jan Hrastnik
eadad13efa
preparing for gd merge
4 years ago
Jan Hrastnik
4e461bea2f
editor.open now checks if view already exists
4 years ago
Jan Hrastnik
0828d1fdea
picker wip
4 years ago