Warn users about the dangers of `vimdiff`

src/internal/detect.rs

@@ -1,7 +1,7 @@
 use crate::internal::commands::ShellCommand;
 use crate::internal::error::SilentUnwrap;
 use crate::internal::exit_code::AppExitCode;
-use crate::internal::strings::prompt;
+use crate::internal::strings::{prompt, warn};
 
 pub fn detect() {
     let mut pacnew = vec![];
@@ -16,12 +16,16 @@ pub fn detect() {
     }
 
     if !pacnew.is_empty() {
-        let choice = prompt("It appears that at least one program you have installed / upgraded has installed a .pacnew/.pacsave config file. Would you like to run pacdiff to deal with this?".to_string(), true);
+        let choice = prompt("It appears that at least one program you have installed / upgraded has installed a .pacnew/.pacsave config file. Would you like to run pacdiff to deal with this? You can always deal with this later by running `sudo pacdiff`".to_string(), false);
         if choice {
-            ShellCommand::pacdiff()
+            warn("Unless you've set an alternative using the DIFFPROG environment variable, pacdiff uses `vimdiff` by default to edit files for merging. Make sure you know how to exit vim before proceeding".to_string());
-                .elevated()
+            let cont = prompt("Continue?".to_string(), false);
-                .wait()
+            if cont {
-                .silent_unwrap(AppExitCode::PacmanError);
+                ShellCommand::pacdiff()
+                    .elevated()
+                    .wait()
+                    .silent_unwrap(AppExitCode::PacmanError);
+            }
         }
     }
 }

src/internal/strings.rs

@@ -13,7 +13,6 @@ pub fn info<S: ToString>(msg: S) {
     println!("\x1b[2;22;35m❖\x1b[0m \x1b[1;37m{}\x1b[0m", a)
 }
 
-#[allow(dead_code)]
 pub fn warn<S: ToString>(msg: S) {
     let a = msg.to_string();
     let a = if internal::uwu_enabled() { uwu!(&a) } else { a };

src/main.rs

@@ -6,8 +6,7 @@ use internal::error::SilentUnwrap;
 use crate::args::{InstallArgs, Operation, QueryArgs, RemoveArgs, SearchArgs};
 use crate::internal::detect;
 use crate::internal::exit_code::AppExitCode;
-#[allow(unused_imports)]
+use crate::internal::{crash, info, init, log, prompt, sort, structs::Options};
-use crate::internal::{crash, info, init, log, prompt, sort, structs::Options, warn};
 
 #[global_allocator]
 static GLOBAL: mimalloc::MiMalloc = mimalloc::MiMalloc;